[bug#29144] [PATCH 1/3] gnu: Add pydot.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

Gábor Boskovits <boskovits@gmail.com> writes:

>     * gnu/packages/python.scm (python-pydot): New variable.

Thanks!  I think we can add this package to graphviz.scm instead, since
python.scm is very generic (and huge!).  A few comments..

> +(define-public python-pydot
> +  (package
> +    (name "python-pydot")
> +    (version "1.2.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "pydot" version))
> +       (sha256
> +        (base32
> +         "00imlz0033dygb9gdag1xr0cybn33gk5jsdi9ffbszzr97rd7dgd"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-pyparsing",python-pyparsing)
> +       ("python-chardet",python-chardet)))

According to setup.py, chardet is only needed for tests, so it should be
a "native-input.  Pyparsing OTOH should be a propagated-input since it
is required at runtime.

I haven't tried building it since it does not apply on current 'master'
after 2e15906c1c1337945b6578c7f58a4fd4af52aaf3.  Can you send an updated
patch please, for 'graphviz.scm'?  Please also try to get the unit tests
running if they are not already, see the '.travis.yml' file for how
upstream does it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]