From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edzF9-00083L-7c for guix-patches@gnu.org; Tue, 23 Jan 2018 09:08:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edzF4-0000e8-82 for guix-patches@gnu.org; Tue, 23 Jan 2018 09:08:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:59550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edzF4-0000e0-4W for guix-patches@gnu.org; Tue, 23 Jan 2018 09:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1edzF3-00067i-PN for guix-patches@gnu.org; Tue, 23 Jan 2018 09:08:01 -0500 Subject: [bug#30084] [PATCH] gnu: Add urho3d. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87y3l5ic8f.fsf@gmail.com> <87shbbqiq5.fsf@gnu.org> <87r2qgput3.fsf@gmail.com> Date: Tue, 23 Jan 2018 15:07:52 +0100 In-Reply-To: <87r2qgput3.fsf@gmail.com> (Oleg Pykhalov's message of "Tue, 23 Jan 2018 16:29:44 +0300") Message-ID: <87vafs653b.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 30084@debbugs.gnu.org Hello, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hi Oleg, >> >> Oleg Pykhalov skribis: >> >>> From 186090075a1ae515bb4893763e7c528568e15939 Mon Sep 17 00:00:00 2001 >>> From: Oleg Pykhalov >>> Date: Thu, 11 Jan 2018 01:14:41 +0300 >>> Subject: [PATCH] gnu: Add urho3d. >>> >>> * gnu/packages/game-development.scm (urho3d): New public variable. >> >> [...] >> >>> + (lambda* (#:key inputs #:allow-other-keys) >>> + (substitute* (string-append "../build/Source/ThirdParty" >>> + "/SDL/include/generated/SDL_c= onfig.h") >> >> IIUC there=E2=80=99s a bundled copy of SDL, right? Can we instead build= against >> our SDL? > > Yes, it's a bundled copy. We probably can, but how? The build system > probably configured look for 'Source/ThirdParty/SDL'. So should we make > a symbolic link like 'Source/ThirdParty/SDL' -> '/gnu/store/=E2=80=A6-SDL= '? Rather, we should adjust CMakeLists.txt (if needed) so that it links against our copy of SDL, like Fis Trivial did with =E2=80=98rct=E2=80=99 to= day. >> Ideally, to be safe from bundling, we should =E2=80=9Crm -rf ThirdParty= =E2=80=9D in a >> snippet. Is that possible? > > Unfortunately no. The contents of the 'Source/ThirdParty' has much more > than just SDL. It's too much work for now, but a good TODO. > > Source/ThirdParty/SDL > > AngelScript Assimp boost Box2D Bullet Civetweb Detour DetourCrowd > DetourTileCache FreeType GLEW ik JO kNet LibCpuId LICENSES Lua > LuaJIT LZ4 MojoShader Mustache nanodbc PugiXml rapidjson Recast SDL > SQLite StanHull STB toluapp WebP Ouch, that=E2=80=99s a lot of stuff! We should at least remove boost, Free= Type, GLEW, Lua, LuaJIT, LZ4, SDL, and SQLite, for which we have packages. > Actually I wonder will those libraries and the engine overall play nice > with OUR SDL library? Should we provide a Guix version and bundled > libraries version? We=E2=80=99ll have to try; hopefully they=E2=80=99re shipping an unmodified= SDL. > From 5a906d8a8a9ff50ed46b5ffc33714b11517e23ca Mon Sep 17 00:00:00 2001 > From: Oleg Pykhalov > Date: Thu, 11 Jan 2018 01:14:41 +0300 > Subject: [PATCH] gnu: Add urho3d. > > * gnu/packages/game-development.scm (urho3d): New public variable. Could you please try unbundling the things mentioned above, and add a FIXME for those we=E2=80=99re not unbundling yet? We should try and see how difficult it is; for =E2=80=98rct=E2=80=99 it was OK. Thank you! Ludo=E2=80=99.