From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eh0xD-00023Z-JS for guix-patches@gnu.org; Wed, 31 Jan 2018 17:34:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eh0x8-0007Rw-SZ for guix-patches@gnu.org; Wed, 31 Jan 2018 17:34:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43693) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eh0x8-0007RV-OW for guix-patches@gnu.org; Wed, 31 Jan 2018 17:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eh0x8-0001Zm-Ie for guix-patches@gnu.org; Wed, 31 Jan 2018 17:34:02 -0500 Subject: bug#28973: [PATCH 1/1] gnu: Add strongswan. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87r2tsbcer.fsf@vany.ca> <555ac710-dd1f-4c74-036a-ad14683e1e5e@tobias.gr> <87a80gb0us.fsf@vany.ca> <87k1ylzy6y.fsf@gnu.org> <87fu7cm5h8.fsf@gnu.org> <87wp0nf17i.fsf@vany.ca> <2cee2d58-f645-487f-eda6-9714eaad5e9f@tobias.gr> <87mv1eeu6i.fsf@vany.ca> <871si7vy6m.fsf@gnu.org> <87tvv1dd6t.fsf@vany.ca> Date: Wed, 31 Jan 2018 23:33:54 +0100 In-Reply-To: <87tvv1dd6t.fsf@vany.ca> (Adam Van Ymeren's message of "Wed, 31 Jan 2018 14:46:02 -0500") Message-ID: <87vafhr73h.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Adam Van Ymeren Cc: 28973-done@debbugs.gnu.org Adam Van Ymeren skribis: > Okay I think I've done all your comments. I figured out how to get some > of the tests that were failing to pass so I dropped one of the patches > and cleaned up the other one. > > I also added non-copyleft license for that one file. > > I spent some time trying to debug the remaining failing tests. They > make some assumptions about paths which are not true in the build > container, I managed to get some to pass when I run manually in a > container from guix environment -C, but they still fail when $ guix > build runs, so I've left in the patch to disable them. They're really > not essential tests. I=E2=80=99ve adjusted said file names in test_process.c and in the library, removed the patch (tests pass!), adjusted the commit log, and pushed as 5f645557a475696c17d936024018103811e1a525. Thanks! Ludo=E2=80=99.