[bug#30439] [PATCH] gnu: Add qqc2-desktop-style.

[bug#30439] [PATCH] gnu: Add qqc2-desktop-style.

[Hartmut Goebel]

* gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
  variable.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d5e3c796e..1b43b66ae 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1275,6 +1275,38 @@ which are used in DBus communication.")
 provides uniform access to generation of barcodes with data.")
     (license license:lgpl2.1+)))
 
+(define-public qqc2-desktop-style
+  (package
+    (name "qqc2-desktop-style")
+    (version "5.42.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kconfigwidgets" ,kconfigwidgets) ;; optional
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes) ;; optional
+       ("kirigami" ,kirigami)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "QtQuickControls2 style that integrates with the desktop")
+    (description "This is a style for QtQuicControls2 which is using QWidget's
+QStyle to paint the controls in order to give it a native look and feel.
+")
+    (license (list license:gpl3+ license:lgpl2.1+))))
+
 (define-public solid
   (package
     (name "solid")
-- 
2.13.6

[bug#30439] [PATCH] gnu: Add qqc2-desktop-style.

[Hartmut Goebel]

I missed adding this in [#30398] (Update KDE Frameworks to 5.42.0 and
other KDE stuff respectively)

[#30398] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30398

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[bug#30439] [PATCH] gnu: Add qqc2-desktop-style.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1881 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
>   variable.

[...]
  
> +(define-public qqc2-desktop-style
> +  (package
> +    (name "qqc2-desktop-style")
> +    (version "5.42.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("kauth" ,kauth)
> +       ("kconfigwidgets" ,kconfigwidgets) ;; optional
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kiconthemes" ,kiconthemes) ;; optional

Nit-pick: only a single semicolon for inline comments.

> +       ("kirigami" ,kirigami)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "QtQuickControls2 style that integrates with the desktop")
> +    (description "This is a style for QtQuicControls2 which is using QWidget's
                                             ^^^ missing 'k'
> +QStyle to paint the controls in order to give it a native look and feel.
> +")

This can be moved to the end of the previous line.

> +    (license (list license:gpl3+ license:lgpl2.1+))))

I'm not familiar with KDE, is everything dual licensed as
GPL3+/LGPL2.1+?  If not, please add a comment explaining what is covered
by which license (or clarify whether it's dual-licensed).

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#30439: [PATCH] gnu: Add qqc2-desktop-style.

[Hartmut Goebel]

Thanks for the review. I addressed your remarks and will push it later
together with [#30398] (Update KDE Frameworks to 5.42.0 and other KDE
stuff respectively)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |