From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ey7ph-0001GZ-Ip for guix-patches@gnu.org; Mon, 19 Mar 2018 23:21:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ey7pe-000119-EK for guix-patches@gnu.org; Mon, 19 Mar 2018 23:21:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34583) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ey7pe-000115-9u for guix-patches@gnu.org; Mon, 19 Mar 2018 23:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ey7pd-0001lu-VA for guix-patches@gnu.org; Mon, 19 Mar 2018 23:21:02 -0400 Subject: [bug#30572] [PATCH 4/7] gnu: When building in a VM, share a temporary directory. Resent-Message-ID: From: Chris Marusich References: <20180222102933.4978-1-cmmarusich@gmail.com> <20180315040915.5556-1-cmmarusich@gmail.com> <20180315040915.5556-5-cmmarusich@gmail.com> <20180316230045.63ad8439@scratchpost.org> Date: Tue, 20 Mar 2018 04:20:39 +0100 In-Reply-To: <20180316230045.63ad8439@scratchpost.org> (Danny Milosavljevic's message of "Fri, 16 Mar 2018 23:00:45 +0100") Message-ID: <87vadrwhyw.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 30572@debbugs.gnu.org, Chris Marusich --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Danny Milosavljevic writes: > There are now three manual "-virtfs" arguments to qemu. It's starting to= irk me > a little. It might make sense to generate those from %linux-vm-filesyste= ms > in order to not have so much duplication and places where things can go w= rong > when maintaining. > > If you'd like, could you maybe pass the %linux-vm-filesystems to > load-in-linux-vm and then automatically calculate those -virtfs entries? > > (In a future patchset - I don't wanna hold up this one) I agree this would be nice. I also agree we should do it in a future patch series. > There's already common-qemu-options which would support >, > and %store-mapping, so actually it would make sense to use those (probabl= y easiest > to move build/vm.scm's load-in-linux-vm into system/vm.scm > expression->derivation-in-linux-vm so the qemu stuff isn't scattered all = over > the place - right now, half is in gnu/system/vm.scm and a mostly redundan= t half > is in gnu/build/vm.scm ... not ideal). > > There's a "mapping->file-system" helper, so it might make sense to use > instead of in %linux-vm-filesystems. > > So all in all: > > * Modify %linux-vm-filesystems to be file-system-mappings instead of file= -systems. > Also modify the place it is used. > * Move load-in-linux-vm to gnu/system/vm.scm (maybe inline into caller). > * Modify load-in-linux-vm to use common-qemu-options. > Notice that the "-append" option is passed twice. Bug... <-- I just fixe= d that in master Good catch! Thank you for fixing it. > If you want I can do it. I wish I could say "I'll do it!", but honestly I might not be able to get to it for a few weeks. So if you have the time, by all means please do it! Otherwise, I might get around to it eventually. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAlqwfgcACgkQ3UCaFdgi Rp1qzQ//cRn3PuFOdUXe8uA3vhloM5bd4QpClK0fXxeBhXQxFUkR9wMarZkBbV98 cAFly/GtuPVDBQTUiTOcSdNxxPxupju0lBEBo9Z6tfjO0cZB64Y34Jouh0awemjR GQTjdiv7R+7hu85nYiJ9ALCn5yL2vLrnGK0dKXbORdleaH9Hl2HXJrzK9HMZCrcr f2AwAoiJH7xxhAfzRBBPchgnzxqVC2wz8fwqVx2Nb5f+0WmrFjVsSuZhQEvOw2qG 6wC1JXxPyVI0zOvguWwi2iq8P4sHOhxOmAQrA1VfQ54DUZeO5fZUrSQfOT368W3a B7YKzjGpzVXHxs6P6NwlfCk906xBru0zM86x8rN/GuPS2v3SnUNYE+fZO+XgRXn/ J7FbVHqDR4Hm8Bjap5dqKK5+Fna2ma+FeWv45ClSPCGW7rmnnMpQPW/A7A9tN2hU zW/mcI1EE7LhnRXXIzEWWDlvbmXX9ySkhHW4mCZK1S7WITdgM4dVKJ0UcWMjr1xt zRZ21fas7+gDUlncJWhhYeRlsEiDWZbeaB3eq4Lo8puMfMk6CsrjxwhjUqysiB/K 9CD7rgrgR9q+R/kbQp1lazPjqq/6nMnZhZu8U6ojmuRiAwFzwpGg5mt9mx+DJFMG 6MGRSgq8WcVYz5rNJDjzsmd/zFIKG2G7YUw2M9MI5AYtiBlKHN8= =NFz2 -----END PGP SIGNATURE----- --=-=-=--