unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
@ 2018-05-31 21:01 Oleg Pykhalov
  2018-05-31 21:07 ` Oleg Pykhalov
  2018-06-01  8:18 ` Ludovic Courtès
  0 siblings, 2 replies; 4+ messages in thread
From: Oleg Pykhalov @ 2018-05-31 21:01 UTC (permalink / raw)
  To: 31673

* gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
'mariadb'.
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9c799aeff..4850f6327 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -8084,7 +8084,7 @@ object has been freed.")
              #t)))))
     (inputs
      `(("emacs-minimal" ,emacs-minimal)
-       ("mysql" ,mysql)
+       ("mariadb" ,mariadb)
        ("postgresql" ,postgresql)))
     (propagated-inputs
      `(("emacs-finalize" ,emacs-finalize)
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
  2018-05-31 21:01 [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input Oleg Pykhalov
@ 2018-05-31 21:07 ` Oleg Pykhalov
  2018-06-01  8:18 ` Ludovic Courtès
  1 sibling, 0 replies; 4+ messages in thread
From: Oleg Pykhalov @ 2018-05-31 21:07 UTC (permalink / raw)
  To: 31673

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

Hello, Guix.

MySQL failed to build on core-updates branch and Mariadb is more Freedom
friendly.

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
  2018-05-31 21:01 [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input Oleg Pykhalov
  2018-05-31 21:07 ` Oleg Pykhalov
@ 2018-06-01  8:18 ` Ludovic Courtès
  2018-06-11  8:53   ` Oleg Pykhalov
  1 sibling, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-06-01  8:18 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 31673

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
> 'mariadb'.

LGTM!

Probably we should stick to a policy regarding mariadb vs. mysql, namely
choosing a default and using that in all the packages.  (I think we’ve
informally done that already, but doing it formally and systematically
would make sense.)

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input.
  2018-06-01  8:18 ` Ludovic Courtès
@ 2018-06-11  8:53   ` Oleg Pykhalov
  0 siblings, 0 replies; 4+ messages in thread
From: Oleg Pykhalov @ 2018-06-11  8:53 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 31673, 31673-done

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

Hello Ludovic,

Apologies for a delay and thank you for the review.

ludo@gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> * gnu/packages/emacs.scm (emacs-emacsql)[inputs]: Replace 'mysql' with
>> 'mariadb'.
>
> LGTM!

Pushed as e0cc7f669bec22c37481dd03a7941c7d11a64f1d to origin/master

> Probably we should stick to a policy regarding mariadb vs. mysql, namely
> choosing a default and using that in all the packages. […]

1+ :-)

Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-06-11  8:54 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-31 21:01 [bug#31673] [PATCH] gnu: emacs-emacsql: Replace mysql with mariadb input Oleg Pykhalov
2018-05-31 21:07 ` Oleg Pykhalov
2018-06-01  8:18 ` Ludovic Courtès
2018-06-11  8:53   ` Oleg Pykhalov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).