unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: Ricardo Wurmus <rekado@elephly.net>,
	Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>,
	31399@debbugs.gnu.org
Subject: [bug#31399] [PATCH] import: elpa: Implement recursive import.
Date: Fri, 01 Jun 2018 22:40:08 +0200	[thread overview]
Message-ID: <87vab26y1j.fsf@gnu.org> (raw)
In-Reply-To: <87efhtdruj.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 30 May 2018 19:35:16 +0300")

Hello Oleg!

Oleg Pykhalov <go.wigust@gmail.com> skribis:

>> Oleg, could you factorize what’s common between the two importers in
>> (guix import utils) like Ricardo suggests?
>
> OK, here is a patch:

That was fast.  :-)

> From 80015053776fb8b3aad6ae730c0e32f655536d9e Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Wed, 30 May 2018 19:08:50 +0300
> Subject: [PATCH] import: utils: Add recursive-import.
>
> * doc/guix.texi (Invoking guix import): Document elpa recursive import.
> * guix/import/cran.scm (cran-guix-name, cran-recursive-import): New
> procedures.
> (recursive-import): Remove procedure.
> * guix/import/elpa.scm (elpa-package->sexp): Return package and
> dependencies values.
> (elpa-guix-name, elpa-recursive-import): New procedures.
> * guix/import/utils.scm (guix-name, recursive-import): New procedures.
> * guix/scripts/import/cran.scm (guix-import-cran): Use
> 'cran-recursive-import' procedure.
> * guix/scripts/import/elpa.scm (show-help, %options): Add recursive
> option.
> (guix-import-elpa): Use 'elpa-recursive-import'.

Nice!

I’d find it clearer to have a first patch that moves code from cran.scm
to utils.scm, and a second patch containing the ELPA changes.  No big
deal though.

Please double-check that tests/{elpa,cran}.scm still pass, but if they
do, I think you can go ahead and push.

Thank you!

Ludo’.

  reply	other threads:[~2018-06-01 20:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  8:37 [bug#31399] [PATCH] import: elpa: Implement recursive import Oleg Pykhalov
2018-05-25 12:00 ` Ludovic Courtès
2018-05-25 12:50   ` Ricardo Wurmus
2018-05-29 14:31     ` Ludovic Courtès
2018-05-30 16:35       ` Oleg Pykhalov
2018-06-01 20:40         ` Ludovic Courtès [this message]
2018-06-08 12:08           ` Oleg Pykhalov
2018-06-08 12:59             ` Ricardo Wurmus
2018-06-08 19:35               ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vab26y1j.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31399@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    --cc=rekado@elephly.net \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).