From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fju6f-0002Lj-Dd for guix-patches@gnu.org; Sun, 29 Jul 2018 18:24:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fju6c-0002qg-8a for guix-patches@gnu.org; Sun, 29 Jul 2018 18:24:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fju6c-0002qW-0Q for guix-patches@gnu.org; Sun, 29 Jul 2018 18:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fju6b-0002v5-Qh for guix-patches@gnu.org; Sun, 29 Jul 2018 18:24:01 -0400 Subject: [bug#31999] [PATCH 2/7] gnu: Add ndctl. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180728220522.12078-1-ambrevar@gmail.com> References: <87o9fc6wnf.fsf@fastmail.com> <20180728220522.12078-1-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 00:23:36 +0200 Message-ID: <87va8x3clz.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > * gnu/package/disk.scm (ndctl): New variable. [...] > +(define-public ndctl > + (package > + (name "ndctl") > + (version "60.3") Version 61.2 is out. Can you see if that still works? > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/pmem/ndctl") > + (commit (string-append "v" version)))) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "0w19yh6f9skf5zy4bhdjlrn3wdx5xx9cq8j6h04cmw4nla6zj9ar")))) > + (build-system gnu-build-system) > + (native-inputs > + `(("asciidoc" ,asciidoc) > + ("automake" ,automake) > + ("autoconf" ,autoconf) > + ("bash-completion" ,bash-completion) That's an unusual input. Can you add a comment about why it's needed? > + ("docbook-xsl" ,docbook-xsl) > + ("libtool" ,libtool) > + ("libxml2" ,libxml2) > + ("pkg-config" ,pkg-config) > + ("xmlto" ,xmlto) > + ;; Required for offline docbook generation: > + ("which" ,which))) > + (inputs > + `(("eudev" ,eudev) > + ("json-c" ,json-c) > + ("kmod" ,kmod) > + ("util-linux" ,util-linux))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (substitute* "autogen.sh" > + (("/bin/sh") (which "sh"))) > + (substitute* "git-version-gen" > + (("/bin/sh") (which "sh"))) > + (substitute* "git-version" > + (("/bin/bash") (which "bash"))) > + (invoke "sh" "autogen.sh")))) Same here: please use the existing bootstrap phase if possible, or replace it. > + #:make-flags > + (let ((out (assoc-ref %outputs "out"))) > + (list (string-append "BASH_COMPLETION_DIR=" out > + "/share/bash-completion/completions"))))) > + (home-page "https://github.com/pmem/ndctl") > + (synopsis "Manage the non-volatile memory device sub-system in the Linux kernel") > + (description > + "Utility library for managing the libnvdimm (non-volatile memory device) > +sub-system in the Linux kernel.") Please use full sentences in descriptions. E.g. "This package provides a ...". > + (license (list license:lgpl2.1 license:gpl2)))) Please add comments when the licensing situation is not clear cut. I had a look, and while COPYING says LGPL2.1, most of the source headers were GPL2. In that situation GPL2 "wins", so I'd write this as: ;; COPYING says LGPL2.1, but many source files are GPL2 so that's ;; the effective license. Note that some files under ccan/ are ;; covered by BSD-3 or public domain, see the individual folders. (license license:gpl2))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAltePmgACgkQoqBt8qM6 VPp+FAf9GRwcGK0yFj3tbQxSpakWmOPEuXkKsLllvaAanBXLAoaENIYsh3e6I0S0 99GDh5W2IPJ14/j4s8VlEfX8bToACtmRm4gOCy5pEh5ZDJZngSmG6dDjPzDZjTAx GcG1l96du+TsvsBGEAg+cV7wzMbx9Aye1LOv1RucXGKz/MKpMUJXNHNN4dWW/1ud fzUGhtkrZ0/wxufnD93+RWuy4eAEB+D/1PY4rVy+ttg4j+G2g887JeMaGyTQOukq L6yU0fRxzr7UQFcAvPRmAQ3YQ5tz3oBkMvJPEXYPoB1nY21dY4ebJANW7s+2aUR3 gISp1IUhnC/oQG5oVveNuAEEzRYyJg== =0yPW -----END PGP SIGNATURE----- --=-=-=--