[bug#32565] [PATCH] Add python-falcon.

[bug#32565] [PATCH] Add python-falcon.

[Maxim Cournoyer]

[-- Attachment #1.1: Type: text/plain, Size: 86 bytes --]

Hello,

This adds Falcon, a Python library for creating web APIs.

Thank you,

Maxim


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-python-mimeparse-Update-to-1.6.0.patch --]
[-- Type: text/x-patch, Size: 1477 bytes --]

From 8149807aa4795faa8f3a23f5ed749c6eed1c6522 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:05:07 -0400
Subject: [PATCH 1/2] gnu: python-mimeparse: Update to 1.6.0.

* gnu/packages/python.scm (python-mimeparse): Update to 1.6.0.
[phases]: Enable tests with a custom check phase.
---
 gnu/packages/python.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 33bbc28ed..8e5bee49d 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1669,7 +1669,7 @@ software.")
 (define-public python-mimeparse
   (package
     (name "python-mimeparse")
-    (version "0.1.4")
+    (version "1.6.0")
     (source
      (origin
        (method url-fetch)
@@ -1678,10 +1678,14 @@ software.")
              version ".tar.gz"))
        (sha256
         (base32
-         "1hyxg09kaj02ri0rmwjqi86wk4nd1akvv7n0dx77azz76wga4s9w"))))
+         "0y2g6cl660bpz11srgqyvvm8gmywpgyx8g0xfvbiyr0af0yv1r3n"))))
     (build-system python-build-system)
     (arguments
-     '(#:tests? #f)) ; no setup.py test command
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "./mimeparse_test.py"))))))
     (home-page
      "https://github.com/dbtsai/python-mimeparse")
     (synopsis "Python library for parsing MIME types")
-- 
2.18.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-gnu-Add-python-falcon.patch --]
[-- Type: text/x-patch, Size: 2170 bytes --]

From a43e42b5e962684143023b67f994a8522700a640 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:06:28 -0400
Subject: [PATCH 2/2] gnu: Add python-falcon.

* gnu/packages/web.scm (python-falcon): New variable.
---
 gnu/packages/web.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index aea75654b..2912c94f8 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -3794,6 +3794,46 @@ http://opensearch.a9.com} compatible search engines.")
 their web site.")
     (home-page "https://metacpan.org/release/WWW-RobotRules")))
 
+(define-public python-falcon
+  (package
+    (name "python-falcon")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon" version))
+       (sha256
+        (base32
+         "1i0vmqsk24z4biirqhpvas9h28wy7nmpy3jvnb6rz2imq04zd09r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "pytest"))))))
+    (propagated-inputs
+     `(("python-mimeparse" ,python-mimeparse)
+       ("python-six" ,python-six)))
+    (native-inputs
+     `(("python-cython" ,python-cython) ;for faster binaries
+       ("python-pytest" ,python-pytest)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-testtools" ,python-testtools)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-msgpack" ,python-msgpack)))
+    (home-page "https://falconframework.org")
+    (synopsis
+     "Unladen web framework for building APIs and app backends")
+    (description
+     "Falcon is a bare-metal Python web API framework for building
+high-performance microservices, app backends, and higher-level frameworks.")
+    (license l:asl2.0)))
+
+(define-public python2-falcon
+  (package-with-python2 python-falcon))
+
 (define-public python-feedparser
   (package
     (name "python-feedparser")
-- 
2.18.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#32565] [PATCH] Add python-falcon-cors.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Hi again,

I'm adding this python-falcon-cors package here as well, since it
depends on the previous python-falcon patch.

Maxim


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0003-gnu-Add-python-falcon-cors.patch --]
[-- Type: text/x-patch, Size: 1461 bytes --]

From a2021511ee502bf4a29df7eb0ac657bd339e6bdc Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:33:17 -0400
Subject: [PATCH] gnu: Add python-falcon-cors.

* gnu/packages/web.scm (python-falcon-cors): New variable.
---
 gnu/packages/web.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 2912c94f8..8e43aad83 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -3834,6 +3834,29 @@ high-performance microservices, app backends, and higher-level frameworks.")
 (define-public python2-falcon
   (package-with-python2 python-falcon))
 
+(define-public python-falcon-cors
+  (package
+    (name "python-falcon-cors")
+    (version "1.1.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon-cors" version))
+       (sha256
+        (base32
+         "12pym7hwsbd8b0c1azn95nas8gm3f1qpr6lpyx0958xm65ffr20p"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-falcon" ,python-falcon)))
+    (home-page
+     "https://github.com/lwcolton/falcon-cors")
+    (synopsis "Falcon CORS middlware")
+    (description "This middleware provides CORS support for Falcon.")
+    (license l:asl2.0)))
+
+(define-public python2-falcon-cors
+  (package-with-python2 python-falcon-cors))
+
 (define-public python-feedparser
   (package
     (name "python-feedparser")
-- 
2.18.0

[bug#32565] [PATCHv2] Add python-falcon and python-falcon-cors.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

Hello,

I've noticed we had a python-web.scm module, so I've moved python-falcon
and python-falcon-cors there instead of in python.scm.

The mimeparse patch can be kept as-is.

Thank you!


[-- Attachment #2: 0001-gnu-Add-python-falcon.patch --]
[-- Type: text/x-patch, Size: 2540 bytes --]

From 88e94dc1e4dec3c1fb9bbf351377c498a351d9ce Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:06:28 -0400
Subject: [PATCH 1/2] gnu: Add python-falcon.

* gnu/packages/python-web.scm (python-falcon): New variable.
---
 gnu/packages/python-web.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index fd76c0c60..bb3eccfc0 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2018 Tomáš Čech <sleep_walker@gnu.org>
 ;;; Copyright © 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2018 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -126,6 +127,46 @@ asynchronous DNS resolutions with a synchronous looking interface by
 using @url{https://github.com/saghul/pycares,pycares}.")
     (license license:expat)))
 
+(define-public python-falcon
+  (package
+    (name "python-falcon")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon" version))
+       (sha256
+        (base32
+         "1i0vmqsk24z4biirqhpvas9h28wy7nmpy3jvnb6rz2imq04zd09r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "pytest"))))))
+    (propagated-inputs
+     `(("python-mimeparse" ,python-mimeparse)
+       ("python-six" ,python-six)))
+    (native-inputs
+     `(("python-cython" ,python-cython) ;for faster binaries
+       ("python-pytest" ,python-pytest)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-testtools" ,python-testtools)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-msgpack" ,python-msgpack)))
+    (home-page "https://falconframework.org")
+    (synopsis
+     "Unladen web framework for building APIs and app backends")
+    (description
+     "Falcon is a bare-metal Python web API framework for building
+high-performance microservices, app backends, and higher-level frameworks.")
+    (license l:asl2.0)))
+
+(define-public python2-falcon
+  (package-with-python2 python-falcon))
+
 (define-public python-furl
   (package
     (name "python-furl")
-- 
2.18.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-Add-python-falcon-cors.patch --]
[-- Type: text/x-patch, Size: 1493 bytes --]

From 83b94826205a8a7577d2ed1d606367c94d6500d2 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:33:17 -0400
Subject: [PATCH 2/2] gnu: Add python-falcon-cors.

* gnu/packages/python-web.scm (python-falcon-cors): New variable.
---
 gnu/packages/python-web.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index bb3eccfc0..0f2054f1a 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -167,6 +167,29 @@ high-performance microservices, app backends, and higher-level frameworks.")
 (define-public python2-falcon
   (package-with-python2 python-falcon))
 
+(define-public python-falcon-cors
+  (package
+    (name "python-falcon-cors")
+    (version "1.1.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon-cors" version))
+       (sha256
+        (base32
+         "12pym7hwsbd8b0c1azn95nas8gm3f1qpr6lpyx0958xm65ffr20p"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-falcon" ,python-falcon)))
+    (home-page
+     "https://github.com/lwcolton/falcon-cors")
+    (synopsis "Falcon CORS middlware")
+    (description "This middleware provides CORS support for Falcon.")
+    (license l:asl2.0)))
+
+(define-public python2-falcon-cors
+  (package-with-python2 python-falcon-cors))
+
 (define-public python-furl
   (package
     (name "python-furl")
-- 
2.18.0

[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hello again,

Hopefully the last update to the python-falcon, python-falcon-cors
packages. I had moved the packages to python-web.scm, but failed to
notice the license field should be adapted to use license:asl2.0 rather
than l:asl2.0.

Don't forget to merge the patch "gnu: python-mimeparse: Update to
1.6.0." in my original mail as well, as it is required for Falcon to
work properly.

Thank you,

Maxim


[-- Attachment #2: v3 --]
[-- Type: text/x-patch, Size: 2546 bytes --]

From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:06:28 -0400
Subject: [PATCH 1/2] gnu: Add python-falcon.

* gnu/packages/python-web.scm (python-falcon): New variable.
---
 gnu/packages/python-web.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index fd76c0c60..8cbb355ff 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2018 Tomáš Čech <sleep_walker@gnu.org>
 ;;; Copyright © 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2018 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -126,6 +127,46 @@ asynchronous DNS resolutions with a synchronous looking interface by
 using @url{https://github.com/saghul/pycares,pycares}.")
     (license license:expat)))
 
+(define-public python-falcon
+  (package
+    (name "python-falcon")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon" version))
+       (sha256
+        (base32
+         "1i0vmqsk24z4biirqhpvas9h28wy7nmpy3jvnb6rz2imq04zd09r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "pytest"))))))
+    (propagated-inputs
+     `(("python-mimeparse" ,python-mimeparse)
+       ("python-six" ,python-six)))
+    (native-inputs
+     `(("python-cython" ,python-cython) ;for faster binaries
+       ("python-pytest" ,python-pytest)
+       ("python-pyyaml" ,python-pyyaml)
+       ("python-requests" ,python-requests)
+       ("python-testtools" ,python-testtools)
+       ("python-jsonschema" ,python-jsonschema)
+       ("python-msgpack" ,python-msgpack)))
+    (home-page "https://falconframework.org")
+    (synopsis
+     "Unladen web framework for building APIs and app backends")
+    (description
+     "Falcon is a bare-metal Python web API framework for building
+high-performance microservices, app backends, and higher-level frameworks.")
+    (license license:asl2.0)))
+
+(define-public python2-falcon
+  (package-with-python2 python-falcon))
+
 (define-public python-furl
   (package
     (name "python-furl")
-- 
2.18.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: v3 --]
[-- Type: text/x-patch, Size: 1499 bytes --]

From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 29 Aug 2018 00:33:17 -0400
Subject: [PATCH 2/2] gnu: Add python-falcon-cors.

* gnu/packages/python-web.scm (python-falcon-cors): New variable.
---
 gnu/packages/python-web.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index 8cbb355ff..ef2cc3176 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -167,6 +167,29 @@ high-performance microservices, app backends, and higher-level frameworks.")
 (define-public python2-falcon
   (package-with-python2 python-falcon))
 
+(define-public python-falcon-cors
+  (package
+    (name "python-falcon-cors")
+    (version "1.1.7")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "falcon-cors" version))
+       (sha256
+        (base32
+         "12pym7hwsbd8b0c1azn95nas8gm3f1qpr6lpyx0958xm65ffr20p"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-falcon" ,python-falcon)))
+    (home-page
+     "https://github.com/lwcolton/falcon-cors")
+    (synopsis "Falcon CORS middlware")
+    (description "This middleware provides CORS support for Falcon.")
+    (license license:asl2.0)))
+
+(define-public python2-falcon-cors
+  (package-with-python2 python-falcon-cors))
+
 (define-public python-furl
   (package
     (name "python-furl")
-- 
2.18.0

[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.

[Ludovic Courtès]

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:06:28 -0400
> Subject: [PATCH 1/2] gnu: Add python-falcon.
>
> * gnu/packages/python-web.scm (python-falcon): New variable.

[...]

> +    (home-page "https://falconframework.org")
> +    (synopsis
> +     "Unladen web framework for building APIs and app backends")
> +    (description
> +     "Falcon is a bare-metal Python web API framework for building
> +high-performance microservices, app backends, and higher-level frameworks.")

If you could make it a bit less catchy and more concrete (giving example
of actual features), that would be great.  :-)

>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 29 Aug 2018 00:33:17 -0400
> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>
> * gnu/packages/python-web.scm (python-falcon-cors): New variable.

[...]

> +    (home-page
> +     "https://github.com/lwcolton/falcon-cors")
> +    (synopsis "Falcon CORS middlware")
                                  ^^
Typo.

What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?

> +    (description "This middleware provides CORS support for Falcon.")

Ditto here, and bonus points if you add a couple of sentences to explain
what it does concretely.  :-)

Last point: unless you need them, you can remove the “python2-” variants
since Python 2.x is reaching end-of-life.

OK to push with changes along these lines.

Thank you!

Ludo’.

[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.

[Ludovic Courtès]

Ping!  :-)

ludo@gnu.org (Ludovic Courtès) skribis:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 29 Aug 2018 00:06:28 -0400
>> Subject: [PATCH 1/2] gnu: Add python-falcon.
>>
>> * gnu/packages/python-web.scm (python-falcon): New variable.
>
> [...]
>
>> +    (home-page "https://falconframework.org")
>> +    (synopsis
>> +     "Unladen web framework for building APIs and app backends")
>> +    (description
>> +     "Falcon is a bare-metal Python web API framework for building
>> +high-performance microservices, app backends, and higher-level frameworks.")
>
> If you could make it a bit less catchy and more concrete (giving example
> of actual features), that would be great.  :-)
>
>>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 29 Aug 2018 00:33:17 -0400
>> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>>
>> * gnu/packages/python-web.scm (python-falcon-cors): New variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/lwcolton/falcon-cors")
>> +    (synopsis "Falcon CORS middlware")
>                                   ^^
> Typo.
>
> What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?
>
>> +    (description "This middleware provides CORS support for Falcon.")
>
> Ditto here, and bonus points if you add a couple of sentences to explain
> what it does concretely.  :-)
>
> Last point: unless you need them, you can remove the “python2-” variants
> since Python 2.x is reaching end-of-life.
>
> OK to push with changes along these lines.
>
> Thank you!
>
> Ludo’.

bug#32565: [PATCHv3] Add python-falcon, python-falcon-cors.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 4167 bytes --]

Hello Ludovic,

Sorry for keeping you waiting this long, and thank you for the friendly
ping! I've addressed the points of your review below.

ludo@gnu.org (Ludovic Courtès) writes:

> Hi Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>>>From c3a1955a2198310b3c096e539eaaaf57a79aa970 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 29 Aug 2018 00:06:28 -0400
>> Subject: [PATCH 1/2] gnu: Add python-falcon.
>>
>> * gnu/packages/python-web.scm (python-falcon): New variable.
>
> [...]
>
>> +    (home-page "https://falconframework.org")
>> +    (synopsis
>> +     "Unladen web framework for building APIs and app backends")
>> +    (description
>> +     "Falcon is a bare-metal Python web API framework for building
>> +high-performance microservices, app backends, and higher-level frameworks.")
>
> If you could make it a bit less catchy and more concrete (giving example
> of actual features), that would be great.  :-)

I've modified it like so:

--8<---------------cut here---------------start------------->8---
-     "Unladen web framework for building APIs and app backends")
+     "Web framework for building APIs and application backends")
     (description
-     "Falcon is a bare-metal Python web API framework for building
-high-performance microservices, app backends, and higher-level frameworks.")
+     "Falcon is a web API framework for building microservices, application
+backends and higher-level frameworks.  Among its features are:
+@itemize
+@item Optimized and extensible code base
+@item Routing via URI templates and REST-inspired resource
+classes
+@item Access to headers and bodies through request and response
+classes
+@item Request processing via middleware components and hooks
+@item Idiomatic HTTP error responses
+@item Straightforward exception handling
+@item Unit testing support through WSGI helpers and mocks
+@item Compatible with both CPython and PyPy
+@item Cython support for better performance when used with CPython
+@end itemize")
     (license license:asl2.0)))
--8<---------------cut here---------------end--------------->8---

I mostly took the feature list from their home page and removed some
extraneous adjectives that made it sound overly catchy.

>>>From 3ecfbe57465aed1062c56ae2b42165a5a07605b5 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 29 Aug 2018 00:33:17 -0400
>> Subject: [PATCH 2/2] gnu: Add python-falcon-cors.
>>
>> * gnu/packages/python-web.scm (python-falcon-cors): New variable.
>
> [...]
>
>> +    (home-page
>> +     "https://github.com/lwcolton/falcon-cors")
>> +    (synopsis "Falcon CORS middlware")
>                                   ^^
> Typo.

Fixed.

> What about “Falcon @dfn{cross-origin resource sharing} (CORS) library”?

Good idea.

>> +    (description "This middleware provides CORS support for Falcon.")
>
> Ditto here, and bonus points if you add a couple of sentences to explain
> what it does concretely.  :-)

I tried doing so like here:

--8<---------------cut here---------------start------------->8---
-    (synopsis "Falcon CORS middlware")
-    (description "This middleware provides CORS support for Falcon.")
+    (synopsis "Falcon @dfn{cross-origin resource sharing} (CORS) library")
+    (description "This middleware provides @dfn{cross-origin resource
+sharing} (CORS) support for Falcon.  It allows applying a specially crafted
+CORS object to the incoming requests, enabling the ability to serve resources
+over a different origin than that of the web application.")
--8<---------------cut here---------------end--------------->8---

To go further than this would require explaining what CORS is about, which is
not the right place in my opinion :).

> Last point: unless you need them, you can remove the “python2-” variants
> since Python 2.x is reaching end-of-life.

Sadly, yes, I need them.

> OK to push with changes along these lines.

Pushed as 66a9f08bb9c9ba2d7cd4ee3c2d48ea9a8e41c2c4.

Thank you for the review :)

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#32565] [PATCHv3] Add python-falcon, python-falcon-cors.

[Ludovic Courtès]

Hi Maxim,

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Pushed as 66a9f08bb9c9ba2d7cd4ee3c2d48ea9a8e41c2c4.

Awesome, thank you!

Ludo’.