From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:33568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggmyW-0005HQ-C3 for guix-patches@gnu.org; Tue, 08 Jan 2019 03:43:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggmyV-0002cv-CR for guix-patches@gnu.org; Tue, 08 Jan 2019 03:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggmyV-0002cf-8j for guix-patches@gnu.org; Tue, 08 Jan 2019 03:43:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggmyU-0001CO-4r for guix-patches@gnu.org; Tue, 08 Jan 2019 03:43:02 -0500 Subject: [bug#33893] [PATCH v5 2/4] gnu: Add docker-engine. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20181230121754.775-1-dannym@scratchpost.org> <20181230233903.23426-1-dannym@scratchpost.org> <20181230233903.23426-3-dannym@scratchpost.org> <87pnt9y1v0.fsf@gnu.org> <20190107194455.69823f82@scratchpost.org> Date: Tue, 08 Jan 2019 09:42:14 +0100 In-Reply-To: <20190107194455.69823f82@scratchpost.org> (Danny Milosavljevic's message of "Mon, 7 Jan 2019 19:44:55 +0100") Message-ID: <87va2z1qxl.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 33893@debbugs.gnu.org Hello, Danny Milosavljevic skribis: > On Sun, 06 Jan 2019 21:20:35 +0100 > Ludovic Court=C3=A8s wrote: > >> Danny Milosavljevic skribis: >>=20 >> > * gnu/packages/docker.scm (docker-engine): New variable. >> > (%docker-version): New variable.=20=20 >>=20 >> [...] >>=20 >> > + ;(("LookPath") "Guix_doesnt_want_LookPath")=20=20 >>=20 >> No longer needed? > > It was meant as a detector in order to make compilation fail when, in fut= ure > versions, docker wants to invok new stuff that we didn't patch yet. > Should we do that? I see, it sounds like a good idea. Also add a comment explaining the rationale. >> > + (replace 'build >> > + (lambda _ >> > + ;(invoke "hack/make.sh" "binary") >> > + ; FIXME: bash -c 'hack/validate/default && hack/make.sh'= =20=20 >>=20 >> It=E2=80=99s not clear to me what should be fixed; perhaps a leftover? > > Yeah, I meant to check what hack/validate/default does and it seems to do > developer-specific tests (commit message formatted the right way etc), so > I guess we can just not invoke it. OK. >> > + (replace 'check >> > + (lambda _ >> > + ; FIXME: Those don't find any of the go packages >> > + ; needed. Probably GOPATH/GOROOT related. >> > + ;(invoke "hack/test/unit") >> > + #t))=20=20 >>=20 >> That=E2=80=99s potentially problematic. :-) Any idea how difficult it = would be >> to run these tests? > > Go has peculiar ideas of how the directory layout is supposed to be set u= p. > I could probably figure it out - but if someone with more Go knowledge co= uld > step forward it would be much faster. I see Leo is Cc=E2=80=99d so we=E2=80=99ll see. :-) Thank you, Ludo=E2=80=99.