From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:33714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvjeQ-0006ut-UL
	for guix-patches@gnu.org; Mon, 18 Feb 2019 09:12:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvjeO-0000GI-Up
	for guix-patches@gnu.org; Mon, 18 Feb 2019 09:12:06 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:52884)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gvjeM-0000Ey-NK
	for guix-patches@gnu.org; Mon, 18 Feb 2019 09:12:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gvjeM-00038W-Gj
	for guix-patches@gnu.org; Mon, 18 Feb 2019 09:12:02 -0500
Subject: [bug#34523] Add tetrinet
Resent-Message-ID: <handler.34523.B34523.155049910812035@debbugs.gnu.org>
From: Tobias Geerinckx-Rice <me@tobias.gr>
References: <E1gvcri-0006jX-4B@rmmprod05.runbox> <87mumtwfgb.fsf@elephly.net>
In-reply-to: <87mumtwfgb.fsf@elephly.net>
Date: Mon, 18 Feb 2019 15:11:37 +0100
Message-ID: <87va1hyyna.fsf@nckx>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pkill9@runbox.com
Cc: 34523@debbugs.gnu.org

pkill -9, Ricardo,

Ricardo Wurmus wrote:
> pkill9@runbox.com writes:
>> +     `(#:tests? #f ; No tests.

Only nitpicks:

+     `(#:tests? #f                      ; no tests

If you're using emacs, running C-M-q on the whole definition will 
automatically indent your code.  There's a way to do the same 
without emacs, but I forget how.

>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)

+                  (delete 'configure)   ; no configure script

>> +                  (add-after 'unpack 'fix-install-dir
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let ((out (assoc-ref outputs "out")))
>> +                        (mkdir-p (string-append out "/bin"))
>> +                        (substitute* "Makefile"
>> +                          (("/usr/games") (string-append out 
>> "/bin")))))))))
>
> Can this patching be avoided by passing a make flag instead?

Nope, it's hard-coded in the Makefile target :-(

Considering the lack of a man(ual) page, how about adding 
something like:

  (add-after 'install 'install-documentation
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (doc (string-append out "/share/doc/"
                                 ,name "-" ,version)))
        (for-each (lambda (file)
                    (install-file file doc))
                  (list "README" "tetrinet.txt"))
        #t))))))

Thanks!

T G-R