[bug#34523] Add tetrinet

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Tetrinet is a multiplayer tetris game. There are two versions: a command line implementation and a GTK implementation - this package is the command line implementation. http://tetrinet.or.cz/

The license is written in the README as

```
Distribution/license information
--------------------------------
This program is public domain, and may be modified and distributed without
limitation.
```

So I don't know what license to put it as, so I set it as 'expat'.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2209 bytes --]

From 1e36c7b0cafac68dcac43bfe301ae979ced67800 Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Mon, 18 Feb 2019 06:52:14 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..5a83efcc2 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,36 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; No tests.
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure)
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin")))))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris")
+    (description "Tetrinet is a multiplayer tetris game with powerups and
+attacks you can use on opponents.")
+    (license license:expat)))
-- 
2.20.1

[bug#34523] Add tetrinet

[Ricardo Wurmus]

pkill9@runbox.com writes:

> The license is written in the README as
>
> ```
> Distribution/license information
> --------------------------------
> This program is public domain, and may be modified and distributed without
> limitation.
> ```
>
> So I don't know what license to put it as, so I set it as 'expat'.

“expat” is not correct.  Use “public-domain” instead.

> +       #:phases (modify-phases %standard-phases
> +                  (delete 'configure)
> +                  (add-after 'unpack 'fix-install-dir
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let ((out (assoc-ref outputs "out")))
> +                        (mkdir-p (string-append out "/bin"))
> +                        (substitute* "Makefile"
> +                          (("/usr/games") (string-append out "/bin")))))))))

Can this patching be avoided by passing a make flag instead?

--
Ricardo

[bug#34523] Add tetrinet

[Tobias Geerinckx-Rice]

pkill -9, Ricardo,

Ricardo Wurmus wrote:
> pkill9@runbox.com writes:
>> +     `(#:tests? #f ; No tests.

Only nitpicks:

+     `(#:tests? #f                      ; no tests

If you're using emacs, running C-M-q on the whole definition will 
automatically indent your code.  There's a way to do the same 
without emacs, but I forget how.

>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)

+                  (delete 'configure)   ; no configure script

>> +                  (add-after 'unpack 'fix-install-dir
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let ((out (assoc-ref outputs "out")))
>> +                        (mkdir-p (string-append out "/bin"))
>> +                        (substitute* "Makefile"
>> +                          (("/usr/games") (string-append out 
>> "/bin")))))))))
>
> Can this patching be avoided by passing a make flag instead?

Nope, it's hard-coded in the Makefile target :-(

Considering the lack of a man(ual) page, how about adding 
something like:

  (add-after 'install 'install-documentation
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (doc (string-append out "/share/doc/"
                                 ,name "-" ,version)))
        (for-each (lambda (file)
                    (install-file file doc))
                  (list "README" "tetrinet.txt"))
        #t))))))

Thanks!

T G-R

[bug#34523] Add tetrinet

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Mon, 18 Feb 2019 15:11:37 +0100
Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> pkill -9, Ricardo,
> 
> Ricardo Wurmus wrote:
> > pkill9@runbox.com writes:  
> >> +     `(#:tests? #f ; No tests.  
> 
> Only nitpicks:
> 
> +     `(#:tests? #f                      ; no tests
> 
> If you're using emacs, running C-M-q on the whole definition will 
> automatically indent your code.  There's a way to do the same 
> without emacs, but I forget how.

# In guix's git checkout:

guix environment --fallback --ad-hoc emacs emacs-guix -- emacs --script ./etc/indent-code.el "${modulename}" "${packagename}"

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 2203 bytes --]

I've attached an updated patch with the modifications suggested so far:

 - Changed license from expat to public-domain
 - Changed "No tests" to lowercase "no tests"
 - Added "no configure file" comment
 - Install Readme files

I indent the package definition in emacs by marking the package definition (CTRL+Space) and running `M-x indent-region`, I'm not sure what indentation was wrong with the original patch I submitted, but I ran indent-region on it again anyway.

On Mon, 18 Feb 2019 15:11:37 +0100, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> pkill -9, Ricardo,
> 
> Ricardo Wurmus wrote:
> > pkill9@runbox.com writes:
> >> +     `(#:tests? #f ; No tests.
> 
> Only nitpicks:
> 
> +     `(#:tests? #f                      ; no tests
> 
> If you're using emacs, running C-M-q on the whole definition will 
> automatically indent your code.  There's a way to do the same 
> without emacs, but I forget how.
> 
> >> +       #:phases (modify-phases %standard-phases
> >> +                  (delete 'configure)
> 
> +                  (delete 'configure)   ; no configure script
> 
> >> +                  (add-after 'unpack 'fix-install-dir
> >> +                    (lambda* (#:key outputs 
> >> #:allow-other-keys)
> >> +                      (let ((out (assoc-ref outputs "out")))
> >> +                        (mkdir-p (string-append out "/bin"))
> >> +                        (substitute* "Makefile"
> >> +                          (("/usr/games") (string-append out 
> >> "/bin")))))))))
> >
> > Can this patching be avoided by passing a make flag instead?
> 
> Nope, it's hard-coded in the Makefile target :-(
> 
> Considering the lack of a man(ual) page, how about adding 
> something like:
> 
>   (add-after 'install 'install-documentation
>     (lambda* (#:key outputs #:allow-other-keys)
>       (let* ((out (assoc-ref outputs "out"))
>              (doc (string-append out "/share/doc/"
>                                  ,name "-" ,version)))
>         (for-each (lambda (file)
>                     (install-file file doc))
>                   (list "README" "tetrinet.txt"))
>         #t))))))
> 
> Thanks!
> 
> T G-R



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2737 bytes --]

From b82be816ed92afd3988ffdee1206edfe9a19616a Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Tue, 19 Feb 2019 07:46:29 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..e6f7f7b79 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests.
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris")
+    (description "Tetrinet is a multiplayer tetris game with powerups and
+attacks you can use on opponents.")
+    (license license:public-domain)))
-- 
2.20.1

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1.1: Type: text/plain, Size: 742 bytes --]

On 2019-02-23 10:26, swedebugia wrote:
> For the sake of making it easy to find when searching synopsies I
> suggest you add "game" to the end of yours.
> -- 
> Sent from my k-9 mail for Android.

having looked it up online I prefer the WP synopsis:
"TetriNET is a console multiplayer online Tetris game for up to six people."

There is a gnome version also. We should state clearly that this is a
console/text-mode client.

As an aside I did not find a working server anywhere and the homepage of
the project is dead. There is a possibility to host your own server with
jetrix though.

There could be trademark issues with the name/game also see
https://en.wikipedia.org/wiki/The_Tetris_Company

-- 
Cheers Swedebugia


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> skrev: (18 februari 2019 15:41:33 CET)
>On Mon, 18 Feb 2019 15:11:37 +0100
>Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
>> pkill -9, Ricardo,
>> 
>> Ricardo Wurmus wrote:
>> > pkill9@runbox.com writes:  
>> >> +     `(#:tests? #f ; No tests.  
>> 
>> Only nitpicks:
>> 
>> +     `(#:tests? #f                      ; no tests
>> 
>> If you're using emacs, running C-M-q on the whole definition will 
>> automatically indent your code.  There's a way to do the same 
>> without emacs, but I forget how.
>
># In guix's git checkout:
>
>guix environment --fallback --ad-hoc emacs emacs-guix -- emacs --script
>./etc/indent-code.el "${modulename}" "${packagename}"

Thanks for the snippet.  I think we should add it to the manual. Thoughts? 
-- 
Sent from my k-9 mail for Android.

[-- Attachment #2: Type: text/html, Size: 1499 bytes --]

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

For the sake of making it easy to find when searching synopsies I suggest you add "game" to the end of yours.
-- 
Sent from my k-9 mail for Android.

[-- Attachment #2: Type: text/html, Size: 158 bytes --]

[bug#34523] Add tetrinet

[pkill9]

Hi Swedebugia,

> having looked it up online I prefer the WP synopsis:
> "TetriNET is a console multiplayer online Tetris game for up to six people."
> 
> There is a gnome version also. We should state clearly that this is a
> console/text-mode client.

What does 'WP' mean?

> As an aside I did not find a working server anywhere and the homepage of
> the project is dead. There is a possibility to host your own server with
> jetrix though.

I played Tetrinet with someone over a server, but I can't remember what the address was.

You can't access the homepage of the project? I can access http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in ages?

> There could be trademark issues with the name/game also see
> https://en.wikipedia.org/wiki/The_Tetris_Company

Regarding the potential trademark issues, both FSF-approved distros Parabola and PureOS have Tetrinet in their repositories[1][2], so I think it would be acceptable to add it to Guix. And if a copyright claim is made in the future it can always be removed.

[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
[2] Tetrinet in PureOS - https://software.pureos.net/search_pkg?term=tetrinet

Thanks

On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net> wrote:

> On 2019-02-23 10:26, swedebugia wrote:
> > For the sake of making it easy to find when searching synopsies I
> > suggest you add "game" to the end of yours.
> > -- 
> > Sent from my k-9 mail for Android.
> 
> having looked it up online I prefer the WP synopsis:
> "TetriNET is a console multiplayer online Tetris game for up to six people."
> 
> There is a gnome version also. We should state clearly that this is a
> console/text-mode client.
> 
> As an aside I did not find a working server anywhere and the homepage of
> the project is dead. There is a possibility to host your own server with
> jetrix though.
> 
> There could be trademark issues with the name/game also see
> https://en.wikipedia.org/wiki/The_Tetris_Company
> 
> -- 
> Cheers Swedebugia

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 2996 bytes --]

Here is a patch that:
 - Removes the full stop after 'no tests'
 - Changes the synopsis from "Multiplayer tetris" to "Multiplayer tetris game".
 - Replaces the description with what you (swedebugia) suggested.

> As an aside I did not find a working server anywhere ... There is a possibility to host your own server with jetrix though.

Oh I realised you meant a server program - the tetrinet package builds one called 'tetrinet-server', I tested it just now by running these commands in separate terminals:

`tetrinet-server`
`tetrinet player1 localhost`
`tetrinet player2 localhost`

Sending messages as the two different players shows up correctly in each tetrinet client, so I think the server works fine.

On Tue, 26 Feb 2019 15:20:28 +0000 (GMT), <pkill9@runbox.com> wrote:

> Hi Swedebugia,
> 
> > having looked it up online I prefer the WP synopsis:
> > "TetriNET is a console multiplayer online Tetris game for up to six people."
> > 
> > There is a gnome version also. We should state clearly that this is a
> > console/text-mode client.
> 
> What does 'WP' mean?
> 
> > As an aside I did not find a working server anywhere and the homepage of
> > the project is dead. There is a possibility to host your own server with
> > jetrix though.
> 
> I played Tetrinet with someone over a server, but I can't remember what the address was.
> 
> You can't access the homepage of the project? I can access http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in ages?
> 
> > There could be trademark issues with the name/game also see
> > https://en.wikipedia.org/wiki/The_Tetris_Company
> 
> Regarding the potential trademark issues, both FSF-approved distros Parabola and PureOS have Tetrinet in their repositories[1][2], so I think it would be acceptable to add it to Guix. And if a copyright claim is made in the future it can always be removed.
> 
> [1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
> [2] Tetrinet in PureOS - https://software.pureos.net/search_pkg?term=tetrinet
> 
> Thanks
> 
> On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net> wrote:
> 
> > On 2019-02-23 10:26, swedebugia wrote:
> > > For the sake of making it easy to find when searching synopsies I
> > > suggest you add "game" to the end of yours.
> > > -- 
> > > Sent from my k-9 mail for Android.
> > 
> > having looked it up online I prefer the WP synopsis:
> > "TetriNET is a console multiplayer online Tetris game for up to six people."
> > 
> > There is a gnome version also. We should state clearly that this is a
> > console/text-mode client.
> > 
> > As an aside I did not find a working server anywhere and the homepage of
> > the project is dead. There is a possibility to host your own server with
> > jetrix though.
> > 
> > There could be trademark issues with the name/game also see
> > https://en.wikipedia.org/wiki/The_Tetris_Company
> > 
> > -- 
> > Cheers Swedebugia



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2726 bytes --]

From 2957b371e121b7cc8ee9eb63382c331cab305ebc Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Tue, 26 Feb 2019 15:37:30 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..d716f91ba 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris game")
+    (description "TetriNET is a console multiplayer online Tetris game for
+up to six people.")
+    (license license:public-domain)))
-- 
2.20.1

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 3333 bytes --]

pkill9@runbox.com skrev: (26 februari 2019 16:44:44 CET)
>Here is a patch that:
> - Removes the full stop after 'no tests'
>- Changes the synopsis from "Multiplayer tetris" to "Multiplayer tetris
>game".
> - Replaces the description with what you (swedebugia) suggested.
>
>> As an aside I did not find a working server anywhere ... There is a
>possibility to host your own server with jetrix though.
>
>Oh I realised you meant a server program - the tetrinet package builds
>one called 'tetrinet-server', I tested it just now by running these
>commands in separate terminals:
>
>`tetrinet-server`
>`tetrinet player1 localhost`
>`tetrinet player2 localhost`
>
>Sending messages as the two different players shows up correctly in
>each tetrinet client, so I think the server works fine.
>
>On Tue, 26 Feb 2019 15:20:28 +0000 (GMT), <pkill9@runbox.com> wrote:
>
>> Hi Swedebugia,
>> 
>> > having looked it up online I prefer the WP synopsis:
>> > "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> > 
>> > There is a gnome version also. We should state clearly that this is
>a
>> > console/text-mode client.
>> 
>> What does 'WP' mean?
>> 
>> > As an aside I did not find a working server anywhere and the
>homepage of
>> > the project is dead. There is a possibility to host your own server
>with
>> > jetrix though.
>> 
>> I played Tetrinet with someone over a server, but I can't remember
>what the address was.
>> 
>> You can't access the homepage of the project? I can access
>http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
>ages?
>> 
>> > There could be trademark issues with the name/game also see
>> > https://en.wikipedia.org/wiki/The_Tetris_Company
>> 
>> Regarding the potential trademark issues, both FSF-approved distros
>Parabola and PureOS have Tetrinet in their repositories[1][2], so I
>think it would be acceptable to add it to Guix. And if a copyright
>claim is made in the future it can always be removed.
>> 
>> [1] Tetrinet in Parabola -
>https://www.parabola.nu/packages/?q=tetrinet
>> [2] Tetrinet in PureOS -
>https://software.pureos.net/search_pkg?term=tetrinet
>> 
>> Thanks
>> 
>> On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia
><swedebugia@riseup.net> wrote:
>> 
>> > On 2019-02-23 10:26, swedebugia wrote:
>> > > For the sake of making it easy to find when searching synopsies I
>> > > suggest you add "game" to the end of yours.
>> > > -- 
>> > > Sent from my k-9 mail for Android.
>> > 
>> > having looked it up online I prefer the WP synopsis:
>> > "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> > 
>> > There is a gnome version also. We should state clearly that this is
>a
>> > console/text-mode client.
>> > 
>> > As an aside I did not find a working server anywhere and the
>homepage of
>> > the project is dead. There is a possibility to host your own server
>with
>> > jetrix though.
>> > 
>> > There could be trademark issues with the name/game also see
>> > https://en.wikipedia.org/wiki/The_Tetris_Company
>> > 
>> > -- 
>> > Cheers Swedebugia

A ha, I completely missed the imbedded server. Maybe we should mention in the description that it includes a client and server.
-- 
Sent from my k-9 mail for Android.

[-- Attachment #2: Type: text/html, Size: 4667 bytes --]

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]

pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
>Hi Swedebugia,
>
>> having looked it up online I prefer the WP synopsis:
>> "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> 
>> There is a gnome version also. We should state clearly that this is a
>> console/text-mode client.
>
>What does 'WP' mean?
>
>> As an aside I did not find a working server anywhere and the homepage
>of
>> the project is dead. There is a possibility to host your own server
>with
>> jetrix though.
>
>I played Tetrinet with someone over a server, but I can't remember what
>the address was.
>
>You can't access the homepage of the project? I can access
>http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
>ages?
>
>> There could be trademark issues with the name/game also see
>> https://en.wikipedia.org/wiki/The_Tetris_Company
>
>Regarding the potential trademark issues, both FSF-approved distros
>Parabola and PureOS have Tetrinet in their repositories[1][2], so I
>think it would be acceptable to add it to Guix. And if a copyright
>claim is made in the future it can always be removed.
>
>[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
>[2] Tetrinet in PureOS -
>https://software.pureos.net/search_pkg?term=tetrinet
>
>Thanks
>
>On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net>
>wrote:
>
>> On 2019-02-23 10:26, swedebugia wrote:
>> > For the sake of making it easy to find when searching synopsies I
>> > suggest you add "game" to the end of yours.
>> > -- 
>> > Sent from my k-9 mail for Android.
>> 
>> having looked it up online I prefer the WP synopsis:
>> "TetriNET is a console multiplayer online Tetris game for up to six
>people."
>> 
>> There is a gnome version also. We should state clearly that this is a
>> console/text-mode client.
>> 
>> As an aside I did not find a working server anywhere and the homepage
>of
>> the project is dead. There is a possibility to host your own server
>with
>> jetrix though.
>> 
>> There could be trademark issues with the name/game also see
>> https://en.wikipedia.org/wiki/The_Tetris_Company
>> 
>> -- 
>> Cheers Swedebugia

Hi 
I agree with your remarks
WP = wikipedia 

Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 
-- 
Sent from my k-9 mail for Android.

[-- Attachment #2: Type: text/html, Size: 3663 bytes --]

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 3760 bytes --]

> A ha, I completely missed the imbedded server. Maybe we should mention in the description that it includes a client and server.

Ok I added that

On Tue, 26 Feb 2019 21:40:34 +0100, swedebugia <swedebugia@riseup.net> wrote:

> pkill9@runbox.com skrev: (26 februari 2019 16:44:44 CET)
> >Here is a patch that:
> > - Removes the full stop after 'no tests'
> >- Changes the synopsis from "Multiplayer tetris" to "Multiplayer tetris
> >game".
> > - Replaces the description with what you (swedebugia) suggested.
> >
> >> As an aside I did not find a working server anywhere ... There is a
> >possibility to host your own server with jetrix though.
> >
> >Oh I realised you meant a server program - the tetrinet package builds
> >one called 'tetrinet-server', I tested it just now by running these
> >commands in separate terminals:
> >
> >`tetrinet-server`
> >`tetrinet player1 localhost`
> >`tetrinet player2 localhost`
> >
> >Sending messages as the two different players shows up correctly in
> >each tetrinet client, so I think the server works fine.
> >
> >On Tue, 26 Feb 2019 15:20:28 +0000 (GMT), <pkill9@runbox.com> wrote:
> >
> >> Hi Swedebugia,
> >> 
> >> > having looked it up online I prefer the WP synopsis:
> >> > "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> > 
> >> > There is a gnome version also. We should state clearly that this is
> >a
> >> > console/text-mode client.
> >> 
> >> What does 'WP' mean?
> >> 
> >> > As an aside I did not find a working server anywhere and the
> >homepage of
> >> > the project is dead. There is a possibility to host your own server
> >with
> >> > jetrix though.
> >> 
> >> I played Tetrinet with someone over a server, but I can't remember
> >what the address was.
> >> 
> >> You can't access the homepage of the project? I can access
> >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
> >ages?
> >> 
> >> > There could be trademark issues with the name/game also see
> >> > https://en.wikipedia.org/wiki/The_Tetris_Company
> >> 
> >> Regarding the potential trademark issues, both FSF-approved distros
> >Parabola and PureOS have Tetrinet in their repositories[1][2], so I
> >think it would be acceptable to add it to Guix. And if a copyright
> >claim is made in the future it can always be removed.
> >> 
> >> [1] Tetrinet in Parabola -
> >https://www.parabola.nu/packages/?q=tetrinet
> >> [2] Tetrinet in PureOS -
> >https://software.pureos.net/search_pkg?term=tetrinet
> >> 
> >> Thanks
> >> 
> >> On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia
> ><swedebugia@riseup.net> wrote:
> >> 
> >> > On 2019-02-23 10:26, swedebugia wrote:
> >> > > For the sake of making it easy to find when searching synopsies I
> >> > > suggest you add "game" to the end of yours.
> >> > > -- 
> >> > > Sent from my k-9 mail for Android.
> >> > 
> >> > having looked it up online I prefer the WP synopsis:
> >> > "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> > 
> >> > There is a gnome version also. We should state clearly that this is
> >a
> >> > console/text-mode client.
> >> > 
> >> > As an aside I did not find a working server anywhere and the
> >homepage of
> >> > the project is dead. There is a possibility to host your own server
> >with
> >> > jetrix though.
> >> > 
> >> > There could be trademark issues with the name/game also see
> >> > https://en.wikipedia.org/wiki/The_Tetris_Company
> >> > 
> >> > -- 
> >> > Cheers Swedebugia
> 
> A ha, I completely missed the imbedded server. Maybe we should mention in the description that it includes a client and server.
> -- 
> Sent from my k-9 mail for Android.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2761 bytes --]

From a033d578d57b2d777f5e9b8277dcb4cd42a26ea3 Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Wed, 27 Feb 2019 06:54:46 +0000
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c..dedaa922d 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "http://tetrinet.or.cz/download/tetrinet-"
+             version
+             ".tar.bz2"))
+       (sha256
+        (base32
+         "0b4pddqz6is1771qmvcj8qqlr4in2djdbkk13agvp9yhfah2v8x7"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris game")
+    (description "TetriNET is a console multiplayer online Tetris game for
+up to six people.  This package includes the server.")
+    (license license:public-domain)))
-- 
2.20.1

[bug#34523] Add tetrinet

[pkill9]

> Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 

Ok I emailed the current maintainer according to that page asking to verify that I got the source code unaltered, and to maybe update the page with that info.

On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia <swedebugia@riseup.net> wrote:

> pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
> >Hi Swedebugia,
> >
> >> having looked it up online I prefer the WP synopsis:
> >> "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> 
> >> There is a gnome version also. We should state clearly that this is a
> >> console/text-mode client.
> >
> >What does 'WP' mean?
> >
> >> As an aside I did not find a working server anywhere and the homepage
> >of
> >> the project is dead. There is a possibility to host your own server
> >with
> >> jetrix though.
> >
> >I played Tetrinet with someone over a server, but I can't remember what
> >the address was.
> >
> >You can't access the homepage of the project? I can access
> >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
> >ages?
> >
> >> There could be trademark issues with the name/game also see
> >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >
> >Regarding the potential trademark issues, both FSF-approved distros
> >Parabola and PureOS have Tetrinet in their repositories[1][2], so I
> >think it would be acceptable to add it to Guix. And if a copyright
> >claim is made in the future it can always be removed.
> >
> >[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
> >[2] Tetrinet in PureOS -
> >https://software.pureos.net/search_pkg?term=tetrinet
> >
> >Thanks
> >
> >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net>
> >wrote:
> >
> >> On 2019-02-23 10:26, swedebugia wrote:
> >> > For the sake of making it easy to find when searching synopsies I
> >> > suggest you add "game" to the end of yours.
> >> > -- 
> >> > Sent from my k-9 mail for Android.
> >> 
> >> having looked it up online I prefer the WP synopsis:
> >> "TetriNET is a console multiplayer online Tetris game for up to six
> >people."
> >> 
> >> There is a gnome version also. We should state clearly that this is a
> >> console/text-mode client.
> >> 
> >> As an aside I did not find a working server anywhere and the homepage
> >of
> >> the project is dead. There is a possibility to host your own server
> >with
> >> jetrix though.
> >> 
> >> There could be trademark issues with the name/game also see
> >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> 
> >> -- 
> >> Cheers Swedebugia
> 
> Hi 
> I agree with your remarks
> WP = wikipedia 
> 
> Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 
> -- 
> Sent from my k-9 mail for Android.

[bug#34523] Add tetrinet

[pkill9]

The Tetrinet maintainer added an SHA1 file: http://tetrinet.or.cz/download/tetrinet-0.11.tar.bz2.sha1

On Wed, 27 Feb 2019 07:10:46 +0000 (GMT), <pkill9@runbox.com> wrote:

> > Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 
> 
> Ok I emailed the current maintainer according to that page asking to verify that I got the source code unaltered, and to maybe update the page with that info.
> 
> On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia <swedebugia@riseup.net> wrote:
> 
> > pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
> > >Hi Swedebugia,
> > >
> > >> having looked it up online I prefer the WP synopsis:
> > >> "TetriNET is a console multiplayer online Tetris game for up to six
> > >people."
> > >> 
> > >> There is a gnome version also. We should state clearly that this is a
> > >> console/text-mode client.
> > >
> > >What does 'WP' mean?
> > >
> > >> As an aside I did not find a working server anywhere and the homepage
> > >of
> > >> the project is dead. There is a possibility to host your own server
> > >with
> > >> jetrix though.
> > >
> > >I played Tetrinet with someone over a server, but I can't remember what
> > >the address was.
> > >
> > >You can't access the homepage of the project? I can access
> > >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated in
> > >ages?
> > >
> > >> There could be trademark issues with the name/game also see
> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> > >
> > >Regarding the potential trademark issues, both FSF-approved distros
> > >Parabola and PureOS have Tetrinet in their repositories[1][2], so I
> > >think it would be acceptable to add it to Guix. And if a copyright
> > >claim is made in the future it can always be removed.
> > >
> > >[1] Tetrinet in Parabola - https://www.parabola.nu/packages/?q=tetrinet
> > >[2] Tetrinet in PureOS -
> > >https://software.pureos.net/search_pkg?term=tetrinet
> > >
> > >Thanks
> > >
> > >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia <swedebugia@riseup.net>
> > >wrote:
> > >
> > >> On 2019-02-23 10:26, swedebugia wrote:
> > >> > For the sake of making it easy to find when searching synopsies I
> > >> > suggest you add "game" to the end of yours.
> > >> > -- 
> > >> > Sent from my k-9 mail for Android.
> > >> 
> > >> having looked it up online I prefer the WP synopsis:
> > >> "TetriNET is a console multiplayer online Tetris game for up to six
> > >people."
> > >> 
> > >> There is a gnome version also. We should state clearly that this is a
> > >> console/text-mode client.
> > >> 
> > >> As an aside I did not find a working server anywhere and the homepage
> > >of
> > >> the project is dead. There is a possibility to host your own server
> > >with
> > >> jetrix though.
> > >> 
> > >> There could be trademark issues with the name/game also see
> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> > >> 
> > >> -- 
> > >> Cheers Swedebugia
> > 
> > Hi 
> > I agree with your remarks
> > WP = wikipedia 
> > 
> > Given that there is no pgp signed tarball or even a checksum on that page,  have you asked the maintainer about this and verified that you got the code unaltered? 
> > -- 
> > Sent from my k-9 mail for Android.

[bug#34523] Add tetrinet

[swedebugia]

[-- Attachment #1: Type: text/plain, Size: 4200 bytes --]

pkill9@runbox.com skrev: (27 februari 2019 15:11:20 CET)
>The Tetrinet maintainer added an SHA1 file:
>http://tetrinet.or.cz/download/tetrinet-0.11.tar.bz2.sha1
>
>On Wed, 27 Feb 2019 07:10:46 +0000 (GMT), <pkill9@runbox.com> wrote:
>
>> > Given that there is no pgp signed tarball or even a checksum on
>that page,  have you asked the maintainer about this and verified that
>you got the code unaltered? 
>> 
>> Ok I emailed the current maintainer according to that page asking to
>verify that I got the source code unaltered, and to maybe update the
>page with that info.
>> 
>> On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia
><swedebugia@riseup.net> wrote:
>> 
>> > pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
>> > >Hi Swedebugia,
>> > >
>> > >> having looked it up online I prefer the WP synopsis:
>> > >> "TetriNET is a console multiplayer online Tetris game for up to
>six
>> > >people."
>> > >> 
>> > >> There is a gnome version also. We should state clearly that this
>is a
>> > >> console/text-mode client.
>> > >
>> > >What does 'WP' mean?
>> > >
>> > >> As an aside I did not find a working server anywhere and the
>homepage
>> > >of
>> > >> the project is dead. There is a possibility to host your own
>server
>> > >with
>> > >> jetrix though.
>> > >
>> > >I played Tetrinet with someone over a server, but I can't remember
>what
>> > >the address was.
>> > >
>> > >You can't access the homepage of the project? I can access
>> > >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated
>in
>> > >ages?
>> > >
>> > >> There could be trademark issues with the name/game also see
>> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
>> > >
>> > >Regarding the potential trademark issues, both FSF-approved
>distros
>> > >Parabola and PureOS have Tetrinet in their repositories[1][2], so
>I
>> > >think it would be acceptable to add it to Guix. And if a copyright
>> > >claim is made in the future it can always be removed.
>> > >
>> > >[1] Tetrinet in Parabola -
>https://www.parabola.nu/packages/?q=tetrinet
>> > >[2] Tetrinet in PureOS -
>> > >https://software.pureos.net/search_pkg?term=tetrinet
>> > >
>> > >Thanks
>> > >
>> > >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia
><swedebugia@riseup.net>
>> > >wrote:
>> > >
>> > >> On 2019-02-23 10:26, swedebugia wrote:
>> > >> > For the sake of making it easy to find when searching
>synopsies I
>> > >> > suggest you add "game" to the end of yours.
>> > >> > -- 
>> > >> > Sent from my k-9 mail for Android.
>> > >> 
>> > >> having looked it up online I prefer the WP synopsis:
>> > >> "TetriNET is a console multiplayer online Tetris game for up to
>six
>> > >people."
>> > >> 
>> > >> There is a gnome version also. We should state clearly that this
>is a
>> > >> console/text-mode client.
>> > >> 
>> > >> As an aside I did not find a working server anywhere and the
>homepage
>> > >of
>> > >> the project is dead. There is a possibility to host your own
>server
>> > >with
>> > >> jetrix though.
>> > >> 
>> > >> There could be trademark issues with the name/game also see
>> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
>> > >> 
>> > >> -- 
>> > >> Cheers Swedebugia
>> > 
>> > Hi 
>> > I agree with your remarks
>> > WP = wikipedia 
>> > 
>> > Given that there is no pgp signed tarball or even a checksum on
>that page,  have you asked the maintainer about this and verified that
>you got the code unaltered? 
>> > -- 
>> > Sent from my k-9 mail for Android.

Good, did you point out that http is easy to spoof?

If they are serious about application and distribution security they really should enable https.

I had the same issue with another maintainer serving a hash over http. I asked him over email if my hash was correct. This is not perfect out of band but given most email providers post snowden now use starttls and enforce https it is better than nothing.

Assuming it is tainted is my default stance with http. I would rather not use it at all and would like a browser that drops it or issue a dire warning when encountered. 
-- 
Sent from my k-9 mail for Android.

[-- Attachment #2: Type: text/html, Size: 6414 bytes --]

[bug#34523] Add tetrinet

[pkill9]

This was their reply:

```
Hi,

I'm not sure how it confirms its validity further :), but it's:
2fb2bfcfe1fc2af82b01b66e2b28a77ad1262c17

The last release of tetrinet was about 15 years ago, this is a purely
legacy archive - I haven't considered adding an https certificate, sorry.
```

On Thu, 28 Feb 2019 05:03:50 +0100, swedebugia <swedebugia@riseup.net> wrote:

> pkill9@runbox.com skrev: (27 februari 2019 15:11:20 CET)
> >The Tetrinet maintainer added an SHA1 file:
> >http://tetrinet.or.cz/download/tetrinet-0.11.tar.bz2.sha1
> >
> >On Wed, 27 Feb 2019 07:10:46 +0000 (GMT), <pkill9@runbox.com> wrote:
> >
> >> > Given that there is no pgp signed tarball or even a checksum on
> >that page,  have you asked the maintainer about this and verified that
> >you got the code unaltered? 
> >> 
> >> Ok I emailed the current maintainer according to that page asking to
> >verify that I got the source code unaltered, and to maybe update the
> >page with that info.
> >> 
> >> On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia
> ><swedebugia@riseup.net> wrote:
> >> 
> >> > pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
> >> > >Hi Swedebugia,
> >> > >
> >> > >> having looked it up online I prefer the WP synopsis:
> >> > >> "TetriNET is a console multiplayer online Tetris game for up to
> >six
> >> > >people."
> >> > >> 
> >> > >> There is a gnome version also. We should state clearly that this
> >is a
> >> > >> console/text-mode client.
> >> > >
> >> > >What does 'WP' mean?
> >> > >
> >> > >> As an aside I did not find a working server anywhere and the
> >homepage
> >> > >of
> >> > >> the project is dead. There is a possibility to host your own
> >server
> >> > >with
> >> > >> jetrix though.
> >> > >
> >> > >I played Tetrinet with someone over a server, but I can't remember
> >what
> >> > >the address was.
> >> > >
> >> > >You can't access the homepage of the project? I can access
> >> > >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated
> >in
> >> > >ages?
> >> > >
> >> > >> There could be trademark issues with the name/game also see
> >> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> > >
> >> > >Regarding the potential trademark issues, both FSF-approved
> >distros
> >> > >Parabola and PureOS have Tetrinet in their repositories[1][2], so
> >I
> >> > >think it would be acceptable to add it to Guix. And if a copyright
> >> > >claim is made in the future it can always be removed.
> >> > >
> >> > >[1] Tetrinet in Parabola -
> >https://www.parabola.nu/packages/?q=tetrinet
> >> > >[2] Tetrinet in PureOS -
> >> > >https://software.pureos.net/search_pkg?term=tetrinet
> >> > >
> >> > >Thanks
> >> > >
> >> > >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia
> ><swedebugia@riseup.net>
> >> > >wrote:
> >> > >
> >> > >> On 2019-02-23 10:26, swedebugia wrote:
> >> > >> > For the sake of making it easy to find when searching
> >synopsies I
> >> > >> > suggest you add "game" to the end of yours.
> >> > >> > -- 
> >> > >> > Sent from my k-9 mail for Android.
> >> > >> 
> >> > >> having looked it up online I prefer the WP synopsis:
> >> > >> "TetriNET is a console multiplayer online Tetris game for up to
> >six
> >> > >people."
> >> > >> 
> >> > >> There is a gnome version also. We should state clearly that this
> >is a
> >> > >> console/text-mode client.
> >> > >> 
> >> > >> As an aside I did not find a working server anywhere and the
> >homepage
> >> > >of
> >> > >> the project is dead. There is a possibility to host your own
> >server
> >> > >with
> >> > >> jetrix though.
> >> > >> 
> >> > >> There could be trademark issues with the name/game also see
> >> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> > >> 
> >> > >> -- 
> >> > >> Cheers Swedebugia
> >> > 
> >> > Hi 
> >> > I agree with your remarks
> >> > WP = wikipedia 
> >> > 
> >> > Given that there is no pgp signed tarball or even a checksum on
> >that page,  have you asked the maintainer about this and verified that
> >you got the code unaltered? 
> >> > -- 
> >> > Sent from my k-9 mail for Android.
> 
> Good, did you point out that http is easy to spoof?
> 
> If they are serious about application and distribution security they really should enable https.
> 
> I had the same issue with another maintainer serving a hash over http. I asked him over email if my hash was correct. This is not perfect out of band but given most email providers post snowden now use starttls and enforce https it is better than nothing.
> 
> Assuming it is tainted is my default stance with http. I would rather not use it at all and would like a browser that drops it or issue a dire warning when encountered. 
> -- 
> Sent from my k-9 mail for Android.

[bug#34523] Add tetrinet

[pkill9]

So I looked at the PureOS page for Tetrinet (https://software.pureos.net/package/source/landing/tetrinet) and the "VCS browser" links to a git repository for Tetrinet which is served via https: https://repo.or.cz/tetrinet.git, this is linked to on the frontpage of http://tetrinet.or.cz (a link to the README) file, so I'll change the source to use this instead.

On Thu, 28 Feb 2019 05:03:50 +0100, swedebugia <swedebugia@riseup.net> wrote:

> pkill9@runbox.com skrev: (27 februari 2019 15:11:20 CET)
> >The Tetrinet maintainer added an SHA1 file:
> >http://tetrinet.or.cz/download/tetrinet-0.11.tar.bz2.sha1
> >
> >On Wed, 27 Feb 2019 07:10:46 +0000 (GMT), <pkill9@runbox.com> wrote:
> >
> >> > Given that there is no pgp signed tarball or even a checksum on
> >that page,  have you asked the maintainer about this and verified that
> >you got the code unaltered? 
> >> 
> >> Ok I emailed the current maintainer according to that page asking to
> >verify that I got the source code unaltered, and to maybe update the
> >page with that info.
> >> 
> >> On Tue, 26 Feb 2019 21:45:23 +0100, swedebugia
> ><swedebugia@riseup.net> wrote:
> >> 
> >> > pkill9@runbox.com skrev: (26 februari 2019 16:20:28 CET)
> >> > >Hi Swedebugia,
> >> > >
> >> > >> having looked it up online I prefer the WP synopsis:
> >> > >> "TetriNET is a console multiplayer online Tetris game for up to
> >six
> >> > >people."
> >> > >> 
> >> > >> There is a gnome version also. We should state clearly that this
> >is a
> >> > >> console/text-mode client.
> >> > >
> >> > >What does 'WP' mean?
> >> > >
> >> > >> As an aside I did not find a working server anywhere and the
> >homepage
> >> > >of
> >> > >> the project is dead. There is a possibility to host your own
> >server
> >> > >with
> >> > >> jetrix though.
> >> > >
> >> > >I played Tetrinet with someone over a server, but I can't remember
> >what
> >> > >the address was.
> >> > >
> >> > >You can't access the homepage of the project? I can access
> >> > >http://tetrinet.or.cz fine. Or do you mean it hasn't been updated
> >in
> >> > >ages?
> >> > >
> >> > >> There could be trademark issues with the name/game also see
> >> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> > >
> >> > >Regarding the potential trademark issues, both FSF-approved
> >distros
> >> > >Parabola and PureOS have Tetrinet in their repositories[1][2], so
> >I
> >> > >think it would be acceptable to add it to Guix. And if a copyright
> >> > >claim is made in the future it can always be removed.
> >> > >
> >> > >[1] Tetrinet in Parabola -
> >https://www.parabola.nu/packages/?q=tetrinet
> >> > >[2] Tetrinet in PureOS -
> >> > >https://software.pureos.net/search_pkg?term=tetrinet
> >> > >
> >> > >Thanks
> >> > >
> >> > >On Sat, 23 Feb 2019 07:23:43 +0100, swedebugia
> ><swedebugia@riseup.net>
> >> > >wrote:
> >> > >
> >> > >> On 2019-02-23 10:26, swedebugia wrote:
> >> > >> > For the sake of making it easy to find when searching
> >synopsies I
> >> > >> > suggest you add "game" to the end of yours.
> >> > >> > -- 
> >> > >> > Sent from my k-9 mail for Android.
> >> > >> 
> >> > >> having looked it up online I prefer the WP synopsis:
> >> > >> "TetriNET is a console multiplayer online Tetris game for up to
> >six
> >> > >people."
> >> > >> 
> >> > >> There is a gnome version also. We should state clearly that this
> >is a
> >> > >> console/text-mode client.
> >> > >> 
> >> > >> As an aside I did not find a working server anywhere and the
> >homepage
> >> > >of
> >> > >> the project is dead. There is a possibility to host your own
> >server
> >> > >with
> >> > >> jetrix though.
> >> > >> 
> >> > >> There could be trademark issues with the name/game also see
> >> > >> https://en.wikipedia.org/wiki/The_Tetris_Company
> >> > >> 
> >> > >> -- 
> >> > >> Cheers Swedebugia
> >> > 
> >> > Hi 
> >> > I agree with your remarks
> >> > WP = wikipedia 
> >> > 
> >> > Given that there is no pgp signed tarball or even a checksum on
> >that page,  have you asked the maintainer about this and verified that
> >you got the code unaltered? 
> >> > -- 
> >> > Sent from my k-9 mail for Android.
> 
> Good, did you point out that http is easy to spoof?
> 
> If they are serious about application and distribution security they really should enable https.
> 
> I had the same issue with another maintainer serving a hash over http. I asked him over email if my hash was correct. This is not perfect out of band but given most email providers post snowden now use starttls and enforce https it is better than nothing.
> 
> Assuming it is tainted is my default stance with http. I would rather not use it at all and would like a browser that drops it or issue a dire warning when encountered. 
> -- 
> Sent from my k-9 mail for Android.

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

I've attached a patch with an updated source url pointing to the git repository which is served via https.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2796 bytes --]

From 24fb08762c1cb3108495c492ea5f1c7ee855a804 Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Wed, 10 Apr 2019 13:49:25 +0100
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f82af0e8c3..6d5b154927 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -36,6 +36,7 @@
 ;;; Copyright © 2018 Madalin Ionel-Patrascu <madalinionel.patrascu@mdc-berlin.de>
 ;;; Copyright © 2018 Benjamin Slade <slade@jnanam.net>
 ;;; Copyright © 2018 Alex Vong <alexvong1995@gmail.com>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6102,3 +6103,44 @@ to download and install them in @file{$HOME/.stepmania-X.Y/Songs} directory.")
     (home-page "https://www.stepmania.com")
     (license license:expat)))
 
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://repo.or.cz/tetrinet.git")
+             (commit "REL_0_11")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1zxd78kwc3p4f10r64z9cqjq77shgyinyrigcx1zn0l4d7qsxg6m"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris game")
+    (description "TetriNET is a console multiplayer online Tetris game for
+up to six people.  This package includes the server.")
+    (license license:public-domain)))
-- 
2.21.0

[bug#34523] Add tetrinet

[pkill9]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

On Wed, 10 Apr 2019 14:07:16 +0100 (BST), <pkill9@runbox.com> wrote:

> I've attached a patch with an updated source url pointing to the git repository which is served via https.

Since this patch no longer applies, I have attached an updated patch that applies to the guix repository.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-tetrinet.patch --]
[-- Type: text/x-patch; name="0001-gnu-Add-tetrinet.patch", Size: 2845 bytes --]

From 62f05ce32274d20cddbf6e28649bac1055080292 Mon Sep 17 00:00:00 2001
From: Pkill -9 <pkill9@runbox.com>
Date: Sun, 30 Jun 2019 10:29:33 +0100
Subject: [PATCH] gnu: Add tetrinet.

* gnu/packages/games.scm (tetrinet): New variable.
---
 gnu/packages/games.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a5aaf56fb2..0a516d50da 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -43,6 +43,7 @@
 ;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix@gmail.com>
 ;;; Copyright © 2019 Dan Frumin <dfrumin@cs.ru.nl>
 ;;; Copyright © 2019 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2019 Pkill -9 <pkill9@runbox.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -7631,3 +7632,45 @@ remake of that series or any other game.")
 the AlphaGo Zero paper.  The current best network weights file for the engine
 can be downloaded from @url{https://zero.sjeng.org/best-network}.")
    (license license:gpl3+)))
+
+(define-public tetrinet
+  (package
+    (name "tetrinet")
+    (version "0.11")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://repo.or.cz/tetrinet.git")
+             (commit "REL_0_11")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1zxd78kwc3p4f10r64z9cqjq77shgyinyrigcx1zn0l4d7qsxg6m"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("ncurses" ,ncurses)))
+    (arguments
+     `(#:tests? #f ; no tests
+       #:make-flags '("CC=gcc")
+       #:phases (modify-phases %standard-phases
+                  (delete 'configure) ; no configure script.
+                  (add-after 'unpack 'fix-install-dir
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let ((out (assoc-ref outputs "out")))
+                        (mkdir-p (string-append out "/bin"))
+                        (substitute* "Makefile"
+                          (("/usr/games") (string-append out "/bin"))))))
+                  (add-after 'install 'install-documentation
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out"))
+                             (doc (string-append out "/share/doc/" ,name "-" ,version)))
+                        (for-each (lambda (file)
+                                    (install-file file doc))
+                                  (list "README" "tetrinet.txt"))
+                        #t))))))
+    (home-page "http://tetrinet.or.cz")
+    (synopsis "Multiplayer tetris game")
+    (description "TetriNET is a console multiplayer online Tetris game for
+up to six people.  This package includes the server.")
+    (license license:public-domain)))
-- 
2.21.0

bug#34523: Add tetrinet

[Maxim Cournoyer]

Hello,

<pkill9@runbox.com> writes:

> I've attached an updated patch with the modifications suggested so far:
>
>  - Changed license from expat to public-domain
>  - Changed "No tests" to lowercase "no tests"
>  - Added "no configure file" comment
>  - Install Readme files
>
> I indent the package definition in emacs by marking the package
> definition (CTRL+Space) and running `M-x indent-region`, I'm not sure
> what indentation was wrong with the original patch I submitted, but I
> ran indent-region on it again anyway.

[...]

Applied as commit f8f096d1e8f930ebeecd98125b9c03d97b3c7f65, with some
small adjustments.

Thank you!

Maxim