unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: pkill9@runbox.com
Cc: 34523@debbugs.gnu.org
Subject: [bug#34523] Add tetrinet
Date: Mon, 18 Feb 2019 15:11:37 +0100	[thread overview]
Message-ID: <87va1hyyna.fsf@nckx> (raw)
In-Reply-To: <87mumtwfgb.fsf@elephly.net>

pkill -9, Ricardo,

Ricardo Wurmus wrote:
> pkill9@runbox.com writes:
>> +     `(#:tests? #f ; No tests.

Only nitpicks:

+     `(#:tests? #f                      ; no tests

If you're using emacs, running C-M-q on the whole definition will 
automatically indent your code.  There's a way to do the same 
without emacs, but I forget how.

>> +       #:phases (modify-phases %standard-phases
>> +                  (delete 'configure)

+                  (delete 'configure)   ; no configure script

>> +                  (add-after 'unpack 'fix-install-dir
>> +                    (lambda* (#:key outputs 
>> #:allow-other-keys)
>> +                      (let ((out (assoc-ref outputs "out")))
>> +                        (mkdir-p (string-append out "/bin"))
>> +                        (substitute* "Makefile"
>> +                          (("/usr/games") (string-append out 
>> "/bin")))))))))
>
> Can this patching be avoided by passing a make flag instead?

Nope, it's hard-coded in the Makefile target :-(

Considering the lack of a man(ual) page, how about adding 
something like:

  (add-after 'install 'install-documentation
    (lambda* (#:key outputs #:allow-other-keys)
      (let* ((out (assoc-ref outputs "out"))
             (doc (string-append out "/share/doc/"
                                 ,name "-" ,version)))
        (for-each (lambda (file)
                    (install-file file doc))
                  (list "README" "tetrinet.txt"))
        #t))))))

Thanks!

T G-R

  reply	other threads:[~2019-02-18 14:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  6:57 [bug#34523] Add tetrinet pkill9
2019-02-18 10:36 ` Ricardo Wurmus
2019-02-18 14:11   ` Tobias Geerinckx-Rice [this message]
2019-02-18 14:41     ` Danny Milosavljevic
2019-02-23  9:23       ` swedebugia
2019-02-19  7:51     ` pkill9
2019-02-23  9:26       ` swedebugia
2019-02-23  6:23         ` swedebugia
2019-02-26 15:20           ` pkill9
2019-02-26 20:45             ` swedebugia
2019-02-27  7:10               ` pkill9
2021-08-06  3:20       ` bug#34523: " Maxim Cournoyer
2019-02-26 15:44 ` [bug#34523] " pkill9
2019-02-26 20:40   ` swedebugia
2019-02-27  7:01     ` pkill9
2019-02-27 14:11 ` pkill9
2019-02-28  4:03   ` swedebugia
2019-03-02 20:10     ` pkill9
2019-03-31 11:44     ` pkill9
2019-04-10 13:07 ` pkill9
2019-06-30  9:33 ` pkill9

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87va1hyyna.fsf@nckx \
    --to=me@tobias.gr \
    --cc=34523@debbugs.gnu.org \
    --cc=pkill9@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).