From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBXSU-0000cA-7M for guix-patches@gnu.org; Wed, 03 Apr 2019 00:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBXSR-00089W-CD for guix-patches@gnu.org; Wed, 03 Apr 2019 00:25:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56704) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBXSQ-000892-F7 for guix-patches@gnu.org; Wed, 03 Apr 2019 00:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hBXSQ-0005n9-6S for guix-patches@gnu.org; Wed, 03 Apr 2019 00:25:02 -0400 Subject: [bug#35117] [PATCH] build-system/python: Move the check phase after the install phase. Resent-Message-ID: Received: from eggs.gnu.org ([209.51.188.92]:55583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBXRT-0000XV-8g for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBXRS-0007OZ-42 for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:03 -0400 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]:41825) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBXRR-0007O4-Oz for guix-patches@gnu.org; Wed, 03 Apr 2019 00:24:02 -0400 Received: by mail-io1-xd35.google.com with SMTP id v10so12912617iom.8 for ; Tue, 02 Apr 2019 21:24:01 -0700 (PDT) Received: from kwak ([2607:f2c0:94b4:fa00::235]) by smtp.gmail.com with ESMTPSA id a16sm7890409itj.15.2019.04.02.21.23.59 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Apr 2019 21:23:59 -0700 (PDT) From: Maxim Cournoyer Date: Wed, 03 Apr 2019 00:23:58 -0400 Message-ID: <87v9zv7m3l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35117@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello! This fixes a (rare?) Python reproducibility problem that was discovered when packaging PyGithub (see patch submission at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35116). You can try running a --check --no-grafts -K on the python-pygithub package, before and after the fix to see the result. Thanks, Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-build-system-python-Move-the-check-phase-after-the-i.patch Content-Transfer-Encoding: quoted-printable From=206fdd6b942b1cddc25bab89b9e256a5dc83d89d35 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 3 Apr 2019 00:09:20 -0400 Subject: [PATCH] build-system/python: Move the check phase after the install phase. A reproducibility problem was discovered while packaging python-pygithub wh= ere the bytecode produced by running the tests would interfere with the result = of the install phase byte compilation. Moving the check phase after the insta= ll phase solves the problem. * guix/build/python-build-system.scm (%standard-phases): Add comment, move the check phase after the install phase. =2D-- guix/build/python-build-system.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-s= ystem.scm index 5bb0ba49d5..9a1a95111a 100644 =2D-- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -251,16 +251,21 @@ installed with setuptools." #t) =20 (define %standard-phases =2D ;; 'configure' phase is not needed. + ;; The build phase only builds C extensions and copies the Python source= s, + ;; while the install phase byte-compiles and copies them to the prefix + ;; directory. The tests are run after the install phase because otherwi= se + ;; the cached .pyc generated during the tests execution seem to interfere + ;; with the byte compilation of the install phase. (modify-phases gnu:%standard-phases (add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-198= 0) (add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism enable-bytecode-determinism) (delete 'bootstrap) =2D (delete 'configure) =2D (replace 'install install) =2D (replace 'check check) + (delete 'configure) ;not needed (replace 'build build) + (delete 'check) ;moved after the install phase + (replace 'install install) + (add-after 'install 'check check) (add-after 'install 'wrap wrap) (add-before 'strip 'rename-pth-file rename-pth-file))) =20 =2D-=20 2.20.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJ9WGpPiQCFQyn/CfEmDkZILmNWIFAlykNV4ACgkQEmDkZILm NWKfrQ//Z6b54U9zWwbsI7oeCzxgae+MYZd9sGdGlNuRaKC1e2fBSjL7y4uLpY5z TTVLPZm9kPNr0dhnZBLS08ihVLs5+8ku/H1e9lbXR4nxSc50t3XfnS3Lm7lzturv FvFd4ACOatV6ueymuYjGtUuuLERPjOfeYGasnVV2Wz8+Rq4TdjpCcQUzZnJhR2+s oBd7c8p0s8jR3UeZFInBDvMeelyR/YcYQeBIeopMGtCKMMev/x2DVwoDHsiUn5EA PTH9DtK6Z2Dgoij2wsnqgb2CrAUFzC+FSvP9sAIk2POJ2XpjolB5nZGc9/B7vDAN 4IbHzQJ8IExFHtTD7ITW+U6ITLNE/378sJRrXuLiIBPQSdBFs3tcZJPW4GV1mcw/ z9lty4YzKDaMlZiI9zFTW0PxFIvoUnNda0009anAWewK88Yzbok1pX/Idouhbr4D 46KiKEQn1MMdXnZPDS+OAwkOcHxagEeu/6tZQyKmSKXxaCn8vMzoHU9bTLAh5xai hK6r4/bGkBeyk0oSxsJzsUOAW91c22wQAhg85vfpLFa15zkbMO6kU416ExS2gFl4 s5ifj1Z8pGed92KUbrb3ueL58wT10th6UpTf6PvmRki8tpHYTPIkzP9CdqxkNL1P 0EKQ3txFNc6GuLjIdvj+81CMwJ9Igfy2XNGZ4SOKnoS472chSAE= =iOOB -----END PGP SIGNATURE----- --==-=-=--