From: "Ludovic Courtès" <ludo@gnu.org>
To: Dan Frumin <dfrumin@cs.ru.nl>
Cc: 36021@debbugs.gnu.org
Subject: [bug#36021] [PATCH] search-paths: 'environment-variable-definition' output for fish
Date: Sat, 01 Jun 2019 15:10:30 +0200 [thread overview]
Message-ID: <87v9xpfo3d.fsf@gnu.org> (raw)
In-Reply-To: <4c3d1d91-18ae-954f-2f0f-a979a974fb2c@cs.ru.nl> (Dan Frumin's message of "Fri, 31 May 2019 12:41:10 +0200")
Hi,
Dan Frumin <dfrumin@cs.ru.nl> skribis:
> Some background on this patch:
> Right now whenever I do any Guix operation that requires me to modify
> environment variables (e.g. installing a Guile library requires me to
> update $GUILE_LOAD_PATH afterwards), Guix helpful tells me what
> commands I have to run to update the variables.
But see <https://issues.guix.gnu.org/issue/35942>. :-)
> However, those commands are currently in bash/POSIX(?) format `export
> VAR=VALUE`. I've modified the `environment-variable-definition`
> function to support the syntax for Fish shell as well. I don't know if
> this method of looking at the $SHELL variable is sound, but it works
> on my machine.
“export VAR=VALUE” is actually Bash-specific. The POSIX way to do it
is:
VAR=VALUE; export VAR
Would that work with Fish?
If it does, we might just as well take that route as it will also cater
to other POSIX-compatible shells.
If not, your patch sounds like the right way.
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-06-01 13:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 10:36 [bug#36021] [PATCH] search-paths: 'environment-variable-definition' output for fish Dan Frumin
2019-05-31 10:41 ` Dan Frumin
2019-06-01 13:10 ` Ludovic Courtès [this message]
2019-06-02 9:29 ` Dan Frumin
2019-06-03 5:51 ` Meiyo Peng
2019-06-03 15:50 ` Dan Frumin
2019-06-04 3:53 ` Meiyo Peng
2019-06-04 7:48 ` Dan Frumin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9xpfo3d.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=36021@debbugs.gnu.org \
--cc=dfrumin@cs.ru.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).