unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Guillaume LE VAILLANT <glv@posteo.net>
Cc: 36071@debbugs.gnu.org
Subject: [bug#36071] [PATCH] gnu: Add leela-zero.
Date: Wed, 05 Jun 2019 17:24:48 +0200	[thread overview]
Message-ID: <87v9xkyrzz.fsf@gnu.org> (raw)
In-Reply-To: <20190603130611.32142-1-glv@posteo.net> (Guillaume LE VAILLANT's message of "Mon, 3 Jun 2019 15:06:11 +0200")

Hi,

Guillaume LE VAILLANT <glv@posteo.net> skribis:

> * gnu/packages/games.scm (leela-zero): New variable.
> * gnu/packages/patches/leela-zero-gtest.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

[...]

> +                 (replace 'check
> +                   (lambda _
> +                     (zero? (system* "./tests")))))))

Please use ‘invoke’ instead of (zero? (system* …)).

> +    "Leela-zero is a Go engine with no human-provided knowledge, modeled
> +after the AlphaGo Zero paper.  The current best network weights file for
> +the engine can be downloaded from https://zero.sjeng.org/best-network.")
                                     ^~~~
Please use @url for URLs.

Does the game run at all if we don’t download additional network weight
data?

There’s a debate as to whether trained neural network parameters can be
considered “source”: <https://lwn.net/Articles/760142/>.

Thanks,
Ludo’.

  reply	other threads:[~2019-06-05 15:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03 13:06 [bug#36071] [PATCH] gnu: Add leela-zero Guillaume LE VAILLANT
2019-06-05 15:24 ` Ludovic Courtès [this message]
2019-06-05 17:26   ` Guillaume LE VAILLANT
2019-06-05 20:47     ` Ludovic Courtès
2019-06-06 10:38       ` zimoun
2019-06-11 20:55       ` Ricardo Wurmus
2019-06-11 22:54         ` Tobias Geerinckx-Rice
2019-06-25 15:12         ` bug#36071: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9xkyrzz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=36071@debbugs.gnu.org \
    --cc=glv@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).