From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50992)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i4mKN-0006DJ-G0
 for guix-patches@gnu.org; Mon, 02 Sep 2019 09:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i4mKM-0005s7-9q
 for guix-patches@gnu.org; Mon, 02 Sep 2019 09:25:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:48750)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i4mKM-0005ri-6a
 for guix-patches@gnu.org; Mon, 02 Sep 2019 09:25:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i4mKL-0002t8-VU
 for guix-patches@gnu.org; Mon, 02 Sep 2019 09:25:02 -0400
Subject: [bug#36352] [PATCH] gnu: Add solvespace.
Resent-Message-ID: <handler.36352.B36352.156743065111037@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190624122710.22874-1-myles@tdma.co> <87r2783w83.fsf@gnu.org>
Date: Mon, 02 Sep 2019 15:24:02 +0200
In-Reply-To: <87r2783w83.fsf@gnu.org> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Wed, 03 Jul 2019 00:30:52 +0200")
Message-ID: <87v9ua96h9.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Myles English <mylesenglish@gmail.com>
Cc: 36352@debbugs.gnu.org, Myles English <myles@tdma.co>

Hello Myles,

Did you have a chance to look into that?  (See below.)

Thanks in advance,
Ludo=E2=80=99.

Ludovic Court=C3=A8s <ludo@gnu.org> skribis:

> Hello Myles,
>
> Myles English <mylesenglish@gmail.com> skribis:
>
>> * gnu/packages/game-development.scm (solvespace): New variable and
>> dependencies on gnu package modules.
>
> The patch LGTM overall.  Here are some comments/questions:
>
>> +(define-public solvespace-3
>> +  (let ((commit "5df53fc59e7f31e265fabd4c15e6601bd3032833")
>> +	(revision "1"))
>> +    (package
>> +      (name "solvespace")
>> +      (version (git-version "3.0" revision commit))
>
>
> Why choose this commit specifically?  =E2=80=98git describe=E2=80=99 retu=
rns
> =E2=80=9Cv2.1.rc1-570-g5df53fc=E2=80=9D, and in fact there=E2=80=99s no =
=E2=80=9Cv3.0=E2=80=9D tag, so this
> version string is a bit misleading.
>
> The general policy is to use the latest release, but if there=E2=80=99s a
> compelling argument, we can use another commit; in that case, it=E2=80=99s
> better to have a comment explaining the choice.
>
>> +         (uri (git-reference
>> +               (url "https://github.com/solvespace/solvespace.git")
>> +               (commit commit)
>> +               (recursive? #t)))
>
> Is =E2=80=98recursive?=E2=80=99 needed?  If it=E2=80=99s just for the bun=
dled dependencies under
> extlib/ that are not used anyway, perhaps we can omit it?
>
>> +      (synopsis "Parametric 2D/3D CAD tool")
>> +      (description "Parametric 2D/3D computer aided design (CAD) tool a=
nd
>> +constraint-based parametric modeler with simple mechanical simulation
>> +capabilities.")
>
> Could you make it a full sentence and perhaps expound a little bit, as
> per <https://gnu.org/s/guix/manual/en/html_node/Synopses-and-Descriptions=
.html>?
>
> Thank you, and apologies for the delay!
>
> Ludo=E2=80=99.