From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:46141)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwCsR-0006sA-5t
 for guix-patches@gnu.org; Mon, 27 Jan 2020 17:29:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwCsQ-0007uL-6v
 for guix-patches@gnu.org; Mon, 27 Jan 2020 17:29:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53231)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iwCsQ-0007tv-09
 for guix-patches@gnu.org; Mon, 27 Jan 2020 17:29:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iwCsP-0007OC-Rm
 for guix-patches@gnu.org; Mon, 27 Jan 2020 17:29:01 -0500
Subject: [bug#39311] [PATCH] gnu: Add guix-vim.
Resent-Message-ID: <handler.39311.B39311.158016411328368@debbugs.gnu.org>
References: <20200127172032.25825-1-efraim@flashner.co.il>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20200127172032.25825-1-efraim@flashner.co.il>
Date: Mon, 27 Jan 2020 23:28:20 +0100
Message-ID: <87v9owttyz.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 39311@debbugs.gnu.org


Hi Efraim,

> * gnu/packages/vim.scm (guix-vim): New variable.
> ---
>  gnu/packages/vim.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/vim.scm b/gnu/packages/vim.scm
> index b5952e3e21..a2d715dc1c 100644
> --- a/gnu/packages/vim.scm
> +++ b/gnu/packages/vim.scm
> @@ -938,3 +938,45 @@ through its msgpack-rpc API.")
>=20=20
>  (define-public python2-pynvim
>    (package-with-python2 python-pynvim))
> +
> +(define-public guix-vim

Looks like we usually prefix vim extensions with =E2=80=9Cvim-=E2=80=9D, so=
 should this
be =E2=80=9Cvim-guix=E2=80=9D instead=E2=80=A6?

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (vimfiles (string-append out "/share/vim/vimfiles"))
> +                    (compiler (string-append vimfiles "/compiler"))
> +                    (doc      (string-append vimfiles "/doc"))
> +                    (indent   (string-append vimfiles "/indent"))
> +                    (ftdetect (string-append vimfiles "/ftdetect"))
> +                    (ftplugin (string-append vimfiles "/ftplugin"))
> +                    (syntax   (string-append vimfiles "/syntax")))
> +               (copy-recursively "compiler" compiler)
> +               (copy-recursively "doc" doc)
> +               (copy-recursively "indent" indent)
> +               (copy-recursively "ftdetect" ftdetect)
> +               (copy-recursively "ftplugin" ftplugin)
> +               (copy-recursively "syntax" syntax)
> +               #t))))))

The repetition here tickles me a little.  How about this instead=E2=80=A6?

(for-each (lambda (dir)
           (copy-recursively dir (string-append vimfiles "/" dir)))
          '("compiler" "doc" "indent" "ftdetect" "ftplugin" "syntax"))

--=20
Ricardo