From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 39547@debbugs.gnu.org
Subject: [bug#39547] [PATCH] website: Provide JSON sources list used by Software Heritage.
Date: Tue, 18 Feb 2020 09:24:49 +0100 [thread overview]
Message-ID: <87v9o4nvzi.fsf@inria.fr> (raw)
In-Reply-To: <CAJ3okZ3rZnDpGgaVUFmdwADSA3yKqeQ0Nc1UgGXf-FFKrEBDxA@mail.gmail.com> (zimoun's message of "Mon, 17 Feb 2020 18:59:24 +0100")
Hi!
zimoun <zimon.toutoune@gmail.com> skribis:
> On Fri, 14 Feb 2020 at 11:20, Ludovic Courtès <ludovic.courtes@inria.fr> wrote:
>> zimoun <zimon.toutoune@gmail.com> skribis:
>
>> >> Could you, in a first patch, move ‘origin->json’ out of
>> >> ‘packages-json-builder’, and in a second patch, add mirror-expansion
>> >> feature?
>> >
>> > Yes, I will try but I am a bit lost. There is:
>> > - packages-json-builder that I did not modified
>> > - sources-json-builder which the "adaptation" of the former to output
>> > to the sources.json format.
>> >
>> > Well, do you want a refactor of 'origin->json' shared by the 2
>> > "{sources,packages}-json-builder"?
>>
>> Yes, exactly. No reason to have two copies of that code.
>
> The minor "issue" is the 'match' piece of 'origin->json':
>
> `(("url" . ,(match uri
> ((? string? url) (vector url))
> ((urls ...) (list->vector urls))))))
>
>
> Because in the 'sources.json' it is always one unique string.
> However, in 'packages.json' it is always a vector of one or several
> elements. And in the previous patch, the job of 'resolve' was to
> uniquify these elements for 'sources.json'.
Ah, good point. What about adding a keyword parameter to ‘origin->json’
that would tell whether to return a single URL or a list thereof?
> For example, see the package 'adns' in 'packages.json'
>
> {
> "name": "adns",
> "version": "1.5.1",
> "source": {
> "type": "url",
> "url": [
> "mirror://gnu/adns/adns-1.5.1.tar.gz",
> "http://www.chiark.greenend.org.uk/~ian/adns/ftp/adns-1.5.1.tar.gz"
> ]
> },
> "synopsis": "Asynchronous DNS client library and utilities",
> "homepage": "https://www.gnu.org/software/adns/",
> "location": "gnu/packages/adns.scm:32"
> },
>
>
>
> Just to be on the same wavelength, does 'packages.json' stay as it is
> (vector for the source url field)?
I think ‘packages.json’ should still return a list of URLs.
I’ve also added a comment asking whether ‘sources.json’ could be changed
to contain a list of URLs:
https://forge.softwareheritage.org/D2025#64037
> Or is 'packages.json' modified to record only one url for the source
> url field with mirror:// expanded?
Yeah, I think we can expand mirror URLs.
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-02-18 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 17:04 [bug#39547] [PATCH] website: Provide JSON sources list used by Software Heritage zimoun
2020-02-14 8:40 ` Ludovic Courtès
2020-02-14 9:04 ` zimoun
2020-02-14 10:20 ` Ludovic Courtès
2020-02-17 17:59 ` zimoun
2020-02-18 8:24 ` Ludovic Courtès [this message]
2020-02-18 8:38 ` zimoun
2020-02-18 8:43 ` Ludovic Courtès
2020-02-18 12:32 ` [bug#39547] [PATCH v2 1/2] website: Refactor and resolve mirror:// of JSON package list zimoun
2020-02-18 12:32 ` [bug#39547] [PATCH v2 2/2] website: Provide JSON sources list used by Software Heritage zimoun
2020-03-02 17:24 ` [bug#39547] [PATCH v3] sources.json: array instead of list zimoun
2020-03-06 11:01 ` Ludovic Courtès
2020-03-07 22:17 ` zimoun
2020-03-09 9:53 ` bug#39547: " Ludovic Courtès
2020-03-03 18:00 ` [bug#39547] Addition of %content-addressed-mirrors to sources.json (SWH)? zimoun
2020-03-05 16:19 ` Ludovic Courtès
2020-03-06 9:26 ` zimoun
2020-03-06 10:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9o4nvzi.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=39547@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).