From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ADzLG9Iozl4NbgAA0tVLHw (envelope-from ) for ; Wed, 27 May 2020 08:46:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 2PvSF9Iozl4CKgAA1q6Kng (envelope-from ) for ; Wed, 27 May 2020 08:46:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0518940039 for ; Wed, 27 May 2020 08:46:09 +0000 (UTC) Received: from localhost ([::1]:54952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdrhP-0004tm-KI for larch@yhetil.org; Wed, 27 May 2020 04:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60868) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdrhK-0004tV-VQ for guix-patches@gnu.org; Wed, 27 May 2020 04:46:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36670) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jdrhK-0001Dg-Li for guix-patches@gnu.org; Wed, 27 May 2020 04:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jdrhK-0005ir-HB for guix-patches@gnu.org; Wed, 27 May 2020 04:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41350] [PATCH v3 2/3] system: vm: Do not register-closures when cross-building to the Hurd. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 27 May 2020 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41350 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Jan \(janneke\) Nieuwenhuizen" Cc: 41350@debbugs.gnu.org Received: via spool by 41350-submit@debbugs.gnu.org id=B41350.159056915121971 (code B ref 41350); Wed, 27 May 2020 08:46:02 +0000 Received: (at 41350) by debbugs.gnu.org; 27 May 2020 08:45:51 +0000 Received: from localhost ([127.0.0.1]:48216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdrh8-0005iJ-La for submit@debbugs.gnu.org; Wed, 27 May 2020 04:45:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdrh7-0005i6-3Z for 41350@debbugs.gnu.org; Wed, 27 May 2020 04:45:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33729) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdrh1-00011I-3V; Wed, 27 May 2020 04:45:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58146 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jdrh0-0006uP-Eu; Wed, 27 May 2020 04:45:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200523093017.12149-1-janneke@gnu.org> <20200523093017.12149-2-janneke@gnu.org> Date: Wed, 27 May 2020 10:45:40 +0200 In-Reply-To: <20200523093017.12149-2-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sat, 23 May 2020 11:30:16 +0200") Message-ID: <87v9khlqa3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: eHKqZGTPM7v+ "Jan (janneke) Nieuwenhuizen" skribis: > This supports cross-building building a vm-image for the Hurd, running a > native qemu. > > * gnu/system/vm.scm (qemu-image)[register-closures?]: Default to #f when > cross-compiling to the Hurd. Only create sql-schema when actually regist= ering > closures. [...] > - (register-closures? (has-guix-service-type? os)) > + (register-closures? (and (has-guix-service-type? os) > + (not (hurd-target?)))) What=E2=80=99s the problem here? (Sorry if I missed earlier discussions!) Intuitively, I think there shouldn=E2=80=99t be system-specific bits here: registering closures has nothing to do with the OS we=E2=80=99re targeting. Thanks, Ludo=E2=80=99.