From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8FquEPQz1F6NTwAA0tVLHw (envelope-from ) for ; Sun, 31 May 2020 22:47:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QKxcDPQz1F7lCwAAbx9fmQ (envelope-from ) for ; Sun, 31 May 2020 22:47:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D818E940B80 for ; Sun, 31 May 2020 22:47:11 +0000 (UTC) Received: from localhost ([::1]:55170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfWjV-0007tp-2f for larch@yhetil.org; Sun, 31 May 2020 18:47:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfWjO-0007tb-I5 for guix-patches@gnu.org; Sun, 31 May 2020 18:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfWjO-000169-7L for guix-patches@gnu.org; Sun, 31 May 2020 18:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfWjO-0001rp-66 for guix-patches@gnu.org; Sun, 31 May 2020 18:47:02 -0400 Subject: bug#41472: [PATCH] gnu: Add pypy3. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 31 May 2020 22:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41472 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 41472-done@debbugs.gnu.org Mail-Followup-To: 41472@debbugs.gnu.org, ludo@gnu.org, lars@6xq.net Received: via spool by 41472-done@debbugs.gnu.org id=D41472.15909652057148 (code D ref 41472); Sun, 31 May 2020 22:47:01 +0000 Received: (at 41472-done) by debbugs.gnu.org; 31 May 2020 22:46:45 +0000 Received: from localhost ([127.0.0.1]:34053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfWj6-0001rE-LX for submit@debbugs.gnu.org; Sun, 31 May 2020 18:46:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfWj4-0001r1-St for 41472-done@debbugs.gnu.org; Sun, 31 May 2020 18:46:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33562) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfWiy-00012F-C6; Sun, 31 May 2020 18:46:36 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50374 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jfWix-0002gY-R7; Sun, 31 May 2020 18:46:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200523065648.GA1418@noor.fritz.box> <87tuzy20ky.fsf@gnu.org> <20200530165239.GA186839@noor.fritz.box> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Prairial an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 01 Jun 2020 00:46:34 +0200 In-Reply-To: <20200530165239.GA186839@noor.fritz.box> (Lars-Dominik Braun's message of "Sat, 30 May 2020 18:52:39 +0200") Message-ID: <87v9kbpvsl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.4 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: RCxPKgiPL5GP --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Lars-Dominik Braun skribis: >> > One thing I don=E2=80=99t like right now is the dependency on gcc-tool= chain >> > (i.e. gcc and binutils) in distutils. I don=E2=80=99t know how to avoi= d that, >> > since building CFFI modules won=E2=80=99t work without patching. >> Is CFFI able to pick =E2=80=98gcc=E2=80=99 from $PATH? If it can do it,= we can avoid >> hardcoding the absolute file name of GCC and instead leave it up to the >> user to add GCC to their environment when they want to use CFFI. > yes, it is, but it looks for the executable "cc", which =E2=80=93 oddly = =E2=80=93 our > gcc-toolchain does not provide. Is this intentional? Yes: as discussed elsewhere, GCC does not provide =E2=80=98cc=E2=80=99, and= we don=E2=80=99t provide it either. > The updated patch replaces it with gcc, which seems to work. Perfect. >> The advice seems to be very general; did you mean that people should >> look for something specific in the build log, for example because test >> failures are silently ignored? > No, not really. Just to run the disabled test suite and see if it goes > from =E2=80=9Ca few failures=E2=80=9D to =E2=80=9Ceverything is broken no= w=E2=80=9D. I could selectively > patch the testsuite to disable currently failing tests, but I=E2=80=99m n= ot > competent enough to judge which one can be skipped safely (due to > sandboxing limitations for example) and which indicate an actual > failure. I=E2=80=99ll remove the comment. OK. Alright. I took the liberty to make the changes below and committed. Thanks! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index b399931a42..9469f89bcf 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -673,7 +673,7 @@ ease from the desktop to a microcontroller or embedded system.") ("bash-minimal" ,bash-minimal) ; Used as /bin/sh ("xz" ,xz))) ; liblzma (arguments - `(#:tests? #f ; Disabled for now, there are simply too many unfixable tests failing + `(#:tests? #f ;FIXME: Disabled for now, there are many tests failing. #:modules ((ice-9 ftw) (ice-9 match) (guix build utils) (guix build gnu-build-system)) #:phases (modify-phases %standard-phases @@ -782,19 +782,18 @@ ease from the desktop to a microcontroller or embedded system.") "pypy-dist/lib-python/3/encodings/rot_13.py") (("#!.+/bin/python") (string-append "#!" (assoc-ref outputs "out") "/bin/pypy3"))) - (with-fluids - ((%default-port-encoding "ISO-8859-1")) - (substitute* - '("pypy-dist/lib_pypy/_md5.py" "pypy-dist/lib_pypy/_sha1.py") - (("#!.+/bin/python") - (string-append "#!" (assoc-ref outputs "out") "/bin/pypy3")))) + (with-fluids ((%default-port-encoding "ISO-8859-1")) + (substitute* '("pypy-dist/lib_pypy/_md5.py" + "pypy-dist/lib_pypy/_sha1.py") + (("#!.+/bin/python") + (string-append "#!" (assoc-ref outputs "out") "/bin/pypy3")))) (copy-recursively "pypy-dist" (assoc-ref outputs "out"))) #t))))) (home-page "https://www.pypy.org/") (synopsis "Python implementation with just-in-time compilation") (description "PyPy is a faster, alternative implementation of the Python -programming language employing a just-in-time compiler. Supports most Python -code natively, including C extensions.") +programming language employing a just-in-time compiler. It supports most +Python code natively, including C extensions.") (license (list license:expat ; pypy itself; _pytest/ license:psfl ; python standard library in lib-python/ license:asl2.0 ; dotviewer/font/ and some of lib-python/ --=-=-=--