From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aHjkFzvG115WaAAA0tVLHw (envelope-from ) for ; Wed, 03 Jun 2020 15:48:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eA3BEzvG117BdgAA1q6Kng (envelope-from ) for ; Wed, 03 Jun 2020 15:48:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC66C94036C for ; Wed, 3 Jun 2020 15:48:10 +0000 (UTC) Received: from localhost ([::1]:40180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgVce-0005Ad-9F for larch@yhetil.org; Wed, 03 Jun 2020 11:48:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgVcY-0005A5-GN for guix-patches@gnu.org; Wed, 03 Jun 2020 11:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgVcY-0005Fe-7H for guix-patches@gnu.org; Wed, 03 Jun 2020 11:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jgVcY-00015s-51 for guix-patches@gnu.org; Wed, 03 Jun 2020 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Jun 2020 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.15911992454160 (code B ref 41360); Wed, 03 Jun 2020 15:48:02 +0000 Received: (at 41360) by debbugs.gnu.org; 3 Jun 2020 15:47:25 +0000 Received: from localhost ([127.0.0.1]:44407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgVbk-00014m-59 for submit@debbugs.gnu.org; Wed, 03 Jun 2020 11:47:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgVbj-00014a-1b for 41360@debbugs.gnu.org; Wed, 03 Jun 2020 11:47:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43710) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgVbd-00059z-Lc; Wed, 03 Jun 2020 11:47:05 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41696 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jgVbd-0002lC-64; Wed, 03 Jun 2020 11:47:05 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200517135138.1651512-1-levenson@mmer.org> <20200517135138.1651512-9-levenson@mmer.org> <87tv0668us.fsf@gnu.org> <87wo4t1ie8.fsf@mmer.org> Date: Wed, 03 Jun 2020 17:47:03 +0200 In-Reply-To: <87wo4t1ie8.fsf@mmer.org> (Alexey Abramov's message of "Sat, 30 May 2020 18:45:19 +0200") Message-ID: <87v9k8kv7s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: adWjFZoPn94q Hi Alexey, Alexey Abramov skribis: > Ludovic Court=C3=A8s writes: [...] >>> + (let* ((module (string-append (getcwd) "/modules/web")) >>> + (classes (string-append module "/build/classes/jav= a/main")) >>> + (web-generated-headers (string-append module "/bui= ld/generated-src/headers")) >>> + (web-generated-classes '("com.sun.webkit.ContextMe= nu" >>> + "com.sun.webkit.ContextMe= nuItem" >>> + "com.sun.webkit.CursorMan= ager" >> >> Perhaps add a comment explaining how you obtained this list of classes >> so that our future selves know how to update it. >> >> Since this is a Web thing, could you check whether it contains pre-built >> (=E2=80=9Cminified=E2=80=9D) JavaScript? If it does, that=E2=80=99s a p= roblem because we >> generally provide only software built from source. > > We build not only a web component here, but webkit as well. Webkit requir= es some extra 3rd party libraries icu, libxml, libxslt and sqlite which are= already in openjfx source bundle. We also build them now. Oh sorry, I had overlooked that and it=E2=80=99s problematic. The policy in Guix is to not use bundled software: it=E2=80=99s a waste of resources (especially for large pieces of software like WebKit), but more importantly it=E2=80=99s a security issue (nobody will notice if =E2=80=98java-openjfx-web=E2=80=99 includes an outdated, vulnerable version= of WebKit). So the solution is to: 1. Pass the relevant flags to tell the build system to use the =E2=80=9Csystem=E2=80=9D copies of these libraries. If there=E2=80=99= s no such flag, patch the build system to not try to build these things. 2. Add a snippet to remove bundled copies of these libraries, to make sure they=E2=80=99re not picked up by mistake. Sometimes it=E2=80=99s just a build flag, and sometimes it=E2=80=99s harder= . If it turns out to be difficult, let us know, and perhaps we can find an interim solution. Could you take a look? Let me know what you think! Thanks, Ludo=E2=80=99.