From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SGcpMZph616jUgAA0tVLHw (envelope-from ) for ; Thu, 18 Jun 2020 12:44:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oP9BLZph615tJgAAB5/wlQ (envelope-from ) for ; Thu, 18 Jun 2020 12:44:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3955D94030A for ; Thu, 18 Jun 2020 12:44:10 +0000 (UTC) Received: from localhost ([::1]:49752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlttp-0003CD-7o for larch@yhetil.org; Thu, 18 Jun 2020 08:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jltti-0003Bl-IX for guix-patches@gnu.org; Thu, 18 Jun 2020 08:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41477) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jltti-0006T5-8q for guix-patches@gnu.org; Thu, 18 Jun 2020 08:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jltti-0000GD-6L for guix-patches@gnu.org; Thu, 18 Jun 2020 08:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41919] [patch] Add curlpp C++ bindings to curl package Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 18 Jun 2020 12:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41919 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dale Mellor Cc: 41919@debbugs.gnu.org Received: via spool by 41919-submit@debbugs.gnu.org id=B41919.1592484206936 (code B ref 41919); Thu, 18 Jun 2020 12:44:02 +0000 Received: (at 41919) by debbugs.gnu.org; 18 Jun 2020 12:43:26 +0000 Received: from localhost ([127.0.0.1]:53020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jltt7-0000F2-LD for submit@debbugs.gnu.org; Thu, 18 Jun 2020 08:43:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jltt2-0000Ei-O3 for 41919@debbugs.gnu.org; Thu, 18 Jun 2020 08:43:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39377) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jltsw-0006N3-UZ; Thu, 18 Jun 2020 08:43:14 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60120 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jltsw-0003tX-GB; Thu, 18 Jun 2020 08:43:14 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Thu, 18 Jun 2020 14:43:12 +0200 In-Reply-To: (Dale Mellor's message of "Wed, 17 Jun 2020 13:02:09 +0100") Message-ID: <87v9jolf33.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: bE7V3x1cjm0K Hi Dale, Dale Mellor skribis: > From 36c628cd27c2c6f281ec800767ba0e514fae13b1 Mon Sep 17 00:00:00 2001 > From: Dale Mellor > Date: Wed, 17 Jun 2020 12:42:54 +0100 > Subject: [PATCH] gnu: Add curlpp library. > > * gnu/packages/curl.scm (curlpp): New variable. Nice! A couple of comments: [...] > +(define-public curlpp > + (package > + (name "curlpp") Please pass the package through ./etc/indent-code.el: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html > + (version "0.8.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jpbarrette/curlpp.git") > + (commit "v0.8.1"))) > + (sha256 > + (base32 "1b0ylnnrhdax4kwjq64r1fk0i24n5ss6zfzf4hxwgslny01xi= wrk")))) > + (build-system cmake-build-system) > + (arguments `(#:phases (modify-phases %standard-phases (delete 'check= )))) To disable tests, use #:tests? #f. However, we only disable tests when there=E2=80=99s a compelling reason to = do so, in which case there should be a comment indicating why they=E2=80=99re disabled. What=E2=80=99s the reason here? Perhaps name-lookup errors? (There=E2=80= =99s no networking in the isolated build environment.) > + (propagated-inputs `(("curl" ,curl))) Do we need to propagate due to cURL headers being included in public headers? > + (synopsis "C++ wrapper around libcURL") > + (description > + "A free and easy-to-use client-side C++ URL transfer library, > +supporting FTP, FTPS, HTTP, HTTPS, GOPHER, TELNET, DICT, FILE and LDAP. = The > +curlpp library supports HTTPS certificates, HTTP POST, HTTP PUT, FTP > +uploading, kerberos, HTTP form based upload, proxies, cookies, user+pass= word > +authentication, file transfer resume, http proxy tunneling and more! The > +curlpp library is highly portable, it builds and works identically on nu= merous > +platforms, including Solaris, NetBSD, FreeBSD, OpenBSD, Darwin, HPUX, IR= IX, > +AIX, Tru64, Linux, Windows, Amiga, OS/2, BeOs, Mac OS X, Ultrix, QNX, Op= enVMS, > +RISC OS, Novell NetWare, DOS and more... curlpp is free, thread-safe, IP= v6 > +compatible, feature rich, well supported and fast.") Please write full sentences and remove the list of supported operating systems, which is not useful info in the context of Guix: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html Thanks for the patch! Ludo=E2=80=99.