From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sPQmJS0ZF1/fdgAA0tVLHw (envelope-from ) for ; Tue, 21 Jul 2020 16:34:53 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gB37IC0ZF190RwAAbx9fmQ (envelope-from ) for ; Tue, 21 Jul 2020 16:34:53 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0CC4F9403A9 for ; Tue, 21 Jul 2020 16:34:52 +0000 (UTC) Received: from localhost ([::1]:46660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxvEA-0007JT-3h for larch@yhetil.org; Tue, 21 Jul 2020 12:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxvDO-0006fE-Rh for guix-patches@gnu.org; Tue, 21 Jul 2020 12:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56886) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxvDO-0008Hp-HX for guix-patches@gnu.org; Tue, 21 Jul 2020 12:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxvDO-0002lP-E7 for guix-patches@gnu.org; Tue, 21 Jul 2020 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42335] [PATCH guix-past] Add old versions of RGBDS Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jul 2020 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42335 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Cc: 42335@debbugs.gnu.org Received: via spool by 42335-submit@debbugs.gnu.org id=B42335.159534919510563 (code B ref 42335); Tue, 21 Jul 2020 16:34:02 +0000 Received: (at 42335) by debbugs.gnu.org; 21 Jul 2020 16:33:15 +0000 Received: from localhost ([127.0.0.1]:40199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxvCd-0002kJ-6N for submit@debbugs.gnu.org; Tue, 21 Jul 2020 12:33:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxvCb-0002k3-2q for 42335@debbugs.gnu.org; Tue, 21 Jul 2020 12:33:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59983) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxvCV-0008Cc-7Y; Tue, 21 Jul 2020 12:33:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55868 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jxvCU-0003T1-JZ; Tue, 21 Jul 2020 12:33:06 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200712160206.6768-1-kuba@kadziolka.net> Date: Tue, 21 Jul 2020 18:33:05 +0200 In-Reply-To: <20200712160206.6768-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Sun, 12 Jul 2020 18:02:06 +0200") Message-ID: <87v9ign7zy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: oLZZDcr7cSC+ Hi Jakub, Jakub K=C4=85dzio=C5=82ka skribis: > * modules/past/packages/assembly.scm: New file. > --- > > This patch adds quite a few old versions of RGBDS. The project has quite > a history of small, possibly accidental breaking changes. As a > measurement of the necessity of this many different versions, I looked > into the git history of the Game Boy homebrew project that inspired this > addition. > > The repository (which is unfortunately private) goes back to the days > of 0.2.5, and for almost all versions in that time range, there exists > a git commit that requires it. > > I am on the fence on including versions 0.3.4 and 0.3.6. Their changelog > on GitHub was updated to warn of silent bugs with miscompilation > potential, and are what the 'almost' above accounts for ;) > I decided to omit them in the patch, hoping that this will prevent a > lost soul or two from tripping over those dangerous (in terms of > potential time loss) bugs. > > I did not include versions 0.1.0 and 0.1.1, as they fail to compile and > I have no idea why. > > This is my first patch for guix-past, so any review remarks specific to > pastraising are very much appreciated :) Nothing to say, this LGTM, nice work! You should now have a gitlab.inria.fr account. We need to add you to =E2=80=98.guix-authorizations=E2=80=99; will you use the same OpenPGP key a= s in Guix? Thanks, Ludo=E2=80=99.