unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: "Ludovic Courtès" <ludo@gnu.org>, 43101@debbugs.gnu.org
Subject: [bug#43101] [PATCH] Add version number in release ISO
Date: Sun, 30 Aug 2020 17:05:27 +0200	[thread overview]
Message-ID: <87v9h0p420.fsf@gnu.org> (raw)
In-Reply-To: <904ADAD9-76B7-4C7F-A0DF-39CEB6E3477D@lepiller.eu> (Julien Lepiller's message of "Sun, 30 Aug 2020 10:35:24 -0400")


Hello Julien,

Thanks for this patch!

>>Please include (gnu image) and avoid ‘@’.
>
> (gnu image) is already imported, but conflicts with another module for partition, leading to a compilation error. What should I do?

You can maybe write something like:

--8<---------------cut here---------------start------------->8---
#:use-module ((srfi srfi-1) #:hide (partition))
--8<---------------cut here---------------end--------------->8---

> I'll add the architecture in there too, as per discussion in the osinfo-db MR.

Do you think it could be useful to add the same mechanism to ISO images
built by the CI? In that case, you could maybe use the same mechanism in
(gnu ci) and label the boot partition with %guix-version?

Thanks,

Mathieu




  reply	other threads:[~2020-08-30 15:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-29 13:44 [bug#43101] [PATCH] Add version number in release ISO Julien Lepiller
2020-08-30 13:47 ` Ludovic Courtès
2020-08-30 14:35   ` Julien Lepiller
2020-08-30 15:05     ` Mathieu Othacehe [this message]
2020-08-30 15:11       ` Julien Lepiller
2020-08-30 19:52         ` [bug#43101] [PATCH v2] " Julien Lepiller
2020-08-31  6:18           ` Mathieu Othacehe
2020-08-31 14:13             ` bug#43101: " Julien Lepiller
2020-09-03 11:10               ` [bug#43101] " Mathieu Othacehe
2020-09-03 12:10                 ` Julien Lepiller
2020-08-31 12:12           ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9h0p420.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=43101@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).