From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id NSuxMaw5mV/wBAAA0tVLHw (envelope-from ) for ; Wed, 28 Oct 2020 09:28:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eLQeLaw5mV/sTAAAB5/wlQ (envelope-from ) for ; Wed, 28 Oct 2020 09:28:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 532B094042F for ; Wed, 28 Oct 2020 09:28:12 +0000 (UTC) Received: from localhost ([::1]:58898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXhkY-0003q0-Oj for larch@yhetil.org; Wed, 28 Oct 2020 05:28:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXhkR-0003oz-2U for guix-patches@gnu.org; Wed, 28 Oct 2020 05:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35626) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXhkQ-00028e-1t for guix-patches@gnu.org; Wed, 28 Oct 2020 05:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kXhkP-0007b4-Uj for guix-patches@gnu.org; Wed, 28 Oct 2020 05:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44274] [PATCH] gnu: Add emacs-powershell.el Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Oct 2020 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44274 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44274@debbugs.gnu.org Cc: rndd@tuta.io X-Debbugs-Original-To: Adam Kandur via Guix-patches via X-Debbugs-Original-Cc: 44274@debbugs.gnu.org, Adam Kandur Received: via spool by 44274-submit@debbugs.gnu.org id=B44274.160387727729178 (code B ref 44274); Wed, 28 Oct 2020 09:28:01 +0000 Received: (at 44274) by debbugs.gnu.org; 28 Oct 2020 09:27:57 +0000 Received: from localhost ([127.0.0.1]:47168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhkL-0007aY-K0 for submit@debbugs.gnu.org; Wed, 28 Oct 2020 05:27:57 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:52567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhkJ-0007aK-Re for 44274@debbugs.gnu.org; Wed, 28 Oct 2020 05:27:56 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay11.mail.gandi.net (Postfix) with ESMTPSA id D9CFB100010; Wed, 28 Oct 2020 09:27:48 +0000 (UTC) From: Nicolas Goaziou References: Date: Wed, 28 Oct 2020 10:27:47 +0100 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Wed, 28 Oct 2020 09:39:13 +0100 (CET)") Message-ID: <87v9eu3dkc.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: ZaH1sjp1ALRz Hello, Adam Kandur via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-powershell.el): New variable. Thank you. Some comments follow. > +(define-public emacs-powershell.el I suggest to rename it emacs-powershell. > + (let ((revision "0") > + (commit "d1b3f95669343399f199f291ef76c09a0ede5e60")) > + (package > + (name "emacs-powershell.el") See above. > + (build-system emacs-build-system) > + (arguments > + `(#:include '("\\.el$"))) > + (version "master") ;; tagged branch is outdated (2015) Version is 0.3 per main Elisp file. Also, end of line comments start with a single semicolon. Two semicolons are used only for full line comments. In any case, I suggest to write the comment above `package' instead. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/jschaf/powershell.el") There seem to be an issue with indentation here. > + (commit version))) This should be (commit commit) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "1cxhzaaig88zhylyycvb3849r85j1ijqklnh9zbqsfl2zhpb0g5c"= )))) > + (home-page "https://github.com/jschaf/powershell.el") > + (synopsis "Mode for editing PowerShell scripts") I suggest: Emacs mode for editing PowerShell scripts > + (description "@code{powershell.el} Mode is an Emacs major mode for= editing and running Microsoft PowerShell files.") I suggest: Powershell is an Emacs major mode=E2=80=A6 The library is really named Powershell, and the capitalization makes it different from PowerShell. Could you send an updated patch? Regards, --=20 Nicolas Goaziou