unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 44208-done@debbugs.gnu.org
Subject: [bug#44208] [PATCH 1/3] gnu: netcdf: Update to 4.7.4.
Date: Sat, 31 Oct 2020 16:12:34 +0000	[thread overview]
Message-ID: <87v9eqxtl9.fsf@cbaines.net> (raw)
In-Reply-To: <87h7qe65sc.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2668 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> I'd always start at Patchwork, so https://patchwork.cbaines.net/ . You
>> might be able to spot it in the list, but you can also search by
>> clicking on "Show patches with" in the top left [1].
>>
>> 1: https://patchwork.cbaines.net/project/guix-patches/list/?series=&submitter=&state=&q=44208&archive=&delegate=
>
> OK, this one is now empty, but I guess that’s expected.
>
> Of the 5 “checks” that appear on each page, ‘cbaines/applying patch’ is
> really just about applying the patch to ‘master’, right?  And
> ‘cbaines/submitting builds’ is about actually building things?

Yeah, the applying patch check reflects something about Git's success at
applying the patch, which happens in the Laminar job which is linked
to. Sometimes the check will fail, but a branch is still created, and
sometimes it'll fail and no branch will be created. Applying patches is
a hard problem.

As for the submitting builds check, that's reported by the script that
submits the builds to the coordinator instance being used. So yes, it'll
appear when the builds are submitted, and hopefully it doesn't take too
long for the builds to happen.

> It’s surprising because when you go the comparison page, sometimes you
> can see that builds are scheduled, so we don’t yet whether it has
> succeeded.  But my understanding is that the Patchwork UI will only
> display whether a build has been submitted, not whether it has
> succeeded, correct?

Indeed. It's possible to feed information about the build results back
in to Patchwork, but that'll require polling/watching the build results
as they're fed back to the Guix Data Service, I'm also not sure how
flexible Patchwork checks are.

> We need a hands-on session.  :-)

Yeah, next on my list of things is to actually send an email out about
the recent changes, but I can hopefully do more with this patch review
stuff over the next month or two.

My innovation for today is including some indication of build statuses
on the package derivation comparision page, and excitingly builds are
starting to happen for patches that I'm looking at (like [1] and [2]).

1: https://data.guix-patches.cbaines.net/compare/package-derivations?base_commit=c15509682f931f8afbe2d71ccdef278454c53774&target_commit=d9a510a2b972b90f8efed9172608f8e0d22768d1&locale=en_US.UTF-8
2: https://data.guix-patches.cbaines.net/compare/package-derivations?base_commit=1c6d98533153bc8e0e36236e7fbcf1eb5e178d26&target_commit=8335d68660ce8813b6bbf515e40ed01cae4e7fb7&locale=en_US.UTF-8

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  reply	other threads:[~2020-10-31 16:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25 10:27 [bug#44208] [PATCH 0/3] Update netcdf Christopher Baines
2020-10-25 10:35 ` [bug#44208] [PATCH 1/3] gnu: netcdf: Update to 4.7.4 Christopher Baines
2020-10-25 10:35   ` [bug#44208] [PATCH 2/3] gnu: netcdf-fortran: Update to 4.5.3 Christopher Baines
2020-10-25 10:35   ` [bug#44208] [PATCH 3/3] gnu: python2-netcdf4: Remove package Christopher Baines
2020-10-25 20:26   ` [bug#44208] [PATCH 1/3] gnu: netcdf: Update to 4.7.4 Jonathan Brielmaier
2020-10-26 12:46     ` zimoun
2020-10-26 16:04     ` Christopher Baines
2020-10-26 10:52   ` Ludovic Courtès
2020-10-26 16:06     ` bug#44208: " Christopher Baines
2020-10-28  9:47       ` [bug#44208] " Ludovic Courtès
2020-10-31 16:12         ` Christopher Baines [this message]
2020-11-02 15:38           ` Ludovic Courtès
2020-11-02 23:43             ` Christopher Baines
2020-10-25 20:28 ` [bug#44208] [PATCH 0/3] Update netcdf Jonathan Brielmaier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9eqxtl9.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=44208-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).