unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 44039@debbugs.gnu.org, James Smith <jsubuntuxp@disroot.org>,
	James Smith <jsubuntuxp@gmail.com>
Subject: [bug#44039] [PATCH] gnu: Add slade.
Date: Sat, 31 Oct 2020 11:01:36 +0100	[thread overview]
Message-ID: <87v9eqww73.fsf@gnu.org> (raw)
In-Reply-To: <87r1pgnjdp.fsf@nckx> (Tobias Geerinckx-Rice's message of "Fri, 30 Oct 2020 10:38:42 +0100")

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> Ludovic Courtès 写道：
>> Like I wrote, it seems that v2 mostly fits the bill.  The only
>> potential
>> issue as I see it is the new ‘reset-slade.pk3-timestamps’ phase: I
>> don’t
>> see what effect it has, like I wrote, so I wonder if it’s necessary.
>
> I need more information to have any opinion :-)
>
> What are you looking at to gauge its effects?  You seem to be claiming
> it has none for you, is that correct?

I didn’t test it, I’m just noticing that (1) the checkout in the store
has timestamps set to 1, and (2) the ‘unpack’ phase preserves timestamps
when it copies it.

So this phase could only have an effect on files created between the
‘unpack’ phase and the ‘build’ phase I think, unless I’m overlooking
something.

Thanks,
Ludo’.




  reply	other threads:[~2020-10-31 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 18:43 [bug#44039] [PATCH] gnu: Add slade James Smith
2020-10-16 21:07 ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-16 21:14   ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-17  0:41   ` James Smith
2020-10-28 14:54   ` Ludovic Courtès
2020-10-29  2:49     ` James Smith
2020-10-29 23:39       ` Ludovic Courtès
2020-10-30  9:38         ` Tobias Geerinckx-Rice via Guix-patches via
2020-10-31 10:01           ` Ludovic Courtès [this message]
2021-05-15 20:52 ` James Smith
2021-09-18 17:47 ` [bug#44039] [PATCH v3] " James Smith via Guix-patches via
2021-09-22 14:21   ` bug#44039: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9eqww73.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=44039@debbugs.gnu.org \
    --cc=jsubuntuxp@disroot.org \
    --cc=jsubuntuxp@gmail.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).