From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2HF+FOhYAWAtXQAA0tVLHw (envelope-from ) for ; Fri, 15 Jan 2021 08:57:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id uPBfEOhYAWAkWgAAB5/wlQ (envelope-from ) for ; Fri, 15 Jan 2021 08:57:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EFF649403EB for ; Fri, 15 Jan 2021 08:57:10 +0000 (UTC) Received: from localhost ([::1]:35594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0Kur-0007hZ-Kt for larch@yhetil.org; Fri, 15 Jan 2021 03:57:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Kuk-0007fj-Sa for guix-patches@gnu.org; Fri, 15 Jan 2021 03:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:56557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Kuk-00018l-KG for guix-patches@gnu.org; Fri, 15 Jan 2021 03:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0Kuk-0007KA-I0 for guix-patches@gnu.org; Fri, 15 Jan 2021 03:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45860] Improve PostgreSQL service. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 15 Jan 2021 08:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Christopher Baines Received: via spool by 45860-submit@debbugs.gnu.org id=B45860.161070101128133 (code B ref 45860); Fri, 15 Jan 2021 08:57:02 +0000 Received: (at 45860) by debbugs.gnu.org; 15 Jan 2021 08:56:51 +0000 Received: from localhost ([127.0.0.1]:39870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0KuY-0007Jg-UG for submit@debbugs.gnu.org; Fri, 15 Jan 2021 03:56:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0KuY-0007JS-02 for 45860@debbugs.gnu.org; Fri, 15 Jan 2021 03:56:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41162) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0KuS-00010d-Fu; Fri, 15 Jan 2021 03:56:44 -0500 Received: from [2a01:e0a:19b:d9a0:1538:87ab:3a95:7600] (port=59874 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l0KuR-0005PV-T3; Fri, 15 Jan 2021 03:56:44 -0500 From: Mathieu Othacehe References: <87h7nj4p3g.fsf@gnu.org> <87a6tb9o84.fsf@cbaines.net> Date: Fri, 15 Jan 2021 09:56:41 +0100 In-Reply-To: <87a6tb9o84.fsf@cbaines.net> (Christopher Baines's message of "Thu, 14 Jan 2021 21:56:43 +0000") Message-ID: <87v9byo9x2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45860@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EFF649403EB X-Spam-Score: -2.86 X-Migadu-Scanner: scn0.migadu.com X-TUID: xid6GOsvOatG Hello Chris, > I haven't read through these changes in detail, but the mixing of the > record describing the config file, and the record for configuring the > service introduces the limitation that you can no longer specify any > lowerable object (like a file) or something like a string to use a > config file outside of the store. Did you have a reason for mixing the > records together? I must admit I overlooked that possibility. The reason for merging the records is that the "log-destination" is now needed both to enable "pg_ctl" logging in "postgresql-shepherd-service" and in "postgresql-config-file" to be written in PostgreSQL configuration. Plus having a record called that does not contain some of the configuration field feels weird. Is passing a lowerable config file a use case of yours? In that case I could still add a "raw-config" field to override the configuration file creation. Thanks, Mathieu