From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gYdQHDeQPmBHLAAA0tVLHw (envelope-from ) for ; Tue, 02 Mar 2021 19:21:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iKyVFzeQPmBTCQAAB5/wlQ (envelope-from ) for ; Tue, 02 Mar 2021 19:21:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E93D8125D3 for ; Tue, 2 Mar 2021 20:21:25 +0100 (CET) Received: from localhost ([::1]:46388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHAaD-0000HH-05 for larch@yhetil.org; Tue, 02 Mar 2021 14:21:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHAZq-00009X-PU for guix-patches@gnu.org; Tue, 02 Mar 2021 14:21:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42641) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHAZq-0003B5-GM for guix-patches@gnu.org; Tue, 02 Mar 2021 14:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHAZq-0002fV-CF for guix-patches@gnu.org; Tue, 02 Mar 2021 14:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46725] [PATCH] gnu: guile-lib: Fix cross compilation. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Mar 2021 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 46725@debbugs.gnu.org Received: via spool by 46725-submit@debbugs.gnu.org id=B46725.161471285810225 (code B ref 46725); Tue, 02 Mar 2021 19:21:02 +0000 Received: (at 46725) by debbugs.gnu.org; 2 Mar 2021 19:20:58 +0000 Received: from localhost ([127.0.0.1]:54187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHAZm-0002er-4n for submit@debbugs.gnu.org; Tue, 02 Mar 2021 14:20:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHAZh-0002ea-7P for 46725@debbugs.gnu.org; Tue, 02 Mar 2021 14:20:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46248) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHAZb-00038L-4H; Tue, 02 Mar 2021 14:20:47 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59424 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHAZa-0007LT-KR; Tue, 02 Mar 2021 14:20:46 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210223200755.29532-1-mail@cbaines.net> <20210224083709.9342-1-mail@cbaines.net> Date: Tue, 02 Mar 2021 20:20:44 +0100 In-Reply-To: <20210224083709.9342-1-mail@cbaines.net> (Christopher Baines's message of "Wed, 24 Feb 2021 08:37:09 +0000") Message-ID: <87v9a9uzub.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1614712887; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=G0AtzIszQ2GFdXm8COrpiMr4rdLEKHpPNT/2KY5yHzY=; b=Q/sBJ00yj7pudvQzxFspBfv7XL+3+OM7PcUYfsc5x8K/8YdSlLw0Ki9I0hN+5lNB3gRt3U fh5ZsdC2D5rUzWi6VPKAG3PYAHRVZL3JBGsLDuAtlqbwzmsCuMJiQoZdSThitMJkB63itL M9SWm34VUmOt1hgTeGRWhVvlwINcFsFR68DYo/nUDHCC0jBI0KPpe684UAwxhsNH+T68zw mZ95DQTFEdMWKrClEDM5pPv3P2OpHPZ2GQPcEs5/+MHcXhAU/avChlyQhYJHRdbL2feZqc hoZ5Qn9ObDZAvvYS//DzHa6WlWIrwhMEGYF7CDpXpYyyIk9ydPYZZN86CfguZg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1614712887; a=rsa-sha256; cv=none; b=KaYG2u5FqdrlGhUo8v+2logM8hTQ6QHvijB3Lh+heUgLXKxn5X0VpMleen3NJ3mjFg/CWT LGhDwomRyXZagmg+ussYmn96zYPZvCaC+yZqv3ZfYlDoBmR1qNlQCdI0LU/w9aOcpNPSY4 OTRaDhcCyUDZqKWqnTAaNcT86TatqiPC2O1lh3CKLSiuStlGiooW3IiqBPcZTMrBlhVVe8 /yWDkUvbGFinvhgY4JXv5mOGhVGSldz/QIJSra2yRsuQr9dYDfZAQRFCwpuxGIuUPrNeYw /7p6UM4jrcJM1wPa2XBQ+M5zch9bKqEXTvb7FlPg1CBRaKEG01NMwYlcLiEKSA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E93D8125D3 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: y9aU4IxYPVjU Hi! Christopher Baines skribis: > These changes were sent upstream as > https://lists.gnu.org/archive/html/guile-devel/2021-02/msg00004.html > > Without this change, the .go files are built for the host architecture, r= ather > than the target. I noticed this when cross building the > guix-build-coordinator (for which guile-lib is an input) to the Hurd. > > * gnu/packages/guile-xyz.scm (guile-lib)[arguments]: Add > 'patch-for-cross-compilation phase. > [native-inputs]: Add autoconf, automake and gettext. > (guile2.0-lib): Adjust to use alist-replace. > (guile2.2-lib): Adjust to use alist-replace. [...] > + (substitute* "configure.ac" > + (("GUILE_FLAGS") > + "GUILE_FLAGS > +if test \"$cross_compiling\" !=3D no; then > + GUILE_TARGET=3D\"--target=3D$host_alias\" > + AC_SUBST([GUILE_TARGET]) > +fi You could even set =E2=80=98GUILE_TARGET=E2=80=99 unconditionally. Otherwise LGTM. Thanks, Ludo=E2=80=99.