unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Brendan Tildesley <mail@brendan.scot>
Cc: 48220@debbugs.gnu.org
Subject: [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs.
Date: Wed, 05 May 2021 15:23:50 +0200	[thread overview]
Message-ID: <87v97xjoux.fsf@gnu.org> (raw)
In-Reply-To: <20210504092051.24383-1-mail@brendan.scot> (Brendan Tildesley's message of "Tue, 4 May 2021 19:20:51 +1000")

Hi Brendan,

Brendan Tildesley <mail@brendan.scot> skribis:

> * gnu/packages/xfce.scm (xfce4-session):[propagated-inputs]: Add xset so
> that xflock4 can turn off the monitor.

Can’t we instead patch ‘scripts/xflock4’ so that it refers to ‘xset’ by
its absolute file name?

However, my understanding is that the xset code is already a fallback:

--8<---------------cut here---------------start------------->8---
# else run another access locking utility, if installed
for lock_cmd in \
  "xlock -mode blank" \
  "slock"
  do
    set -- $lock_cmd
    if command -v -- $1 >/dev/null 2>&1; then
        $lock_cmd >/dev/null 2>&1 &
	# turn off display backlight:
	xset dpms force off
        exit
    fi
done
--8<---------------cut here---------------end--------------->8---

Probably we should ensure the first ‘for’ loop works as expected.
Perhaps we need to replace ‘xfce4-screensaver-command’ by its absolute
file name there.

WDYT?

Thanks,
Ludo’.




  reply	other threads:[~2021-05-05 13:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  9:20 [bug#48220] [PATCH] gnu: xfce4-session: Add xset to propagated-inputs Brendan Tildesley
2021-05-05 13:23 ` Ludovic Courtès [this message]
2021-05-06  2:38   ` Brendan Tildesley
2021-05-06 12:03     ` Efraim Flashner
2021-05-06 12:13       ` Brendan Tildesley
2021-05-08 10:23     ` bug#48220: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v97xjoux.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=48220@debbugs.gnu.org \
    --cc=mail@brendan.scot \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).