From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QUWjJu6hNmEPcQEAgWs5BA (envelope-from ) for ; Tue, 07 Sep 2021 01:19:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aGRYIe6hNmFVbAAA1q6Kng (envelope-from ) for ; Mon, 06 Sep 2021 23:19:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99A0519A69 for ; Tue, 7 Sep 2021 01:19:09 +0200 (CEST) Received: from localhost ([::1]:34758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNNtM-00080S-Kh for larch@yhetil.org; Mon, 06 Sep 2021 19:19:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNNtG-00080B-MT for guix-patches@gnu.org; Mon, 06 Sep 2021 19:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNNtG-0003Dq-Ec for guix-patches@gnu.org; Mon, 06 Sep 2021 19:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNNtG-0001y3-9B for guix-patches@gnu.org; Mon, 06 Sep 2021 19:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48237] [PATCH] gnu: emacs-consult: Add =?UTF-8?Q?=E2=80=98emacs-ve?= Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: Arun Isaac , 48237@debbugs.gnu.org, Xinglu Chen Received: via spool by 48237-submit@debbugs.gnu.org id=B48237.16309702897486 (code B ref 48237); Mon, 06 Sep 2021 23:19:02 +0000 Received: (at 48237) by debbugs.gnu.org; 6 Sep 2021 23:18:09 +0000 Received: from localhost ([127.0.0.1]:54725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNNsO-0001wg-NQ for submit@debbugs.gnu.org; Mon, 06 Sep 2021 19:18:08 -0400 Received: from mail-qv1-f43.google.com ([209.85.219.43]:38415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNNsM-0001wC-Ho for 48237@debbugs.gnu.org; Mon, 06 Sep 2021 19:18:07 -0400 Received: by mail-qv1-f43.google.com with SMTP id ew6so4761237qvb.5 for <48237@debbugs.gnu.org>; Mon, 06 Sep 2021 16:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iqnjfyS128j8f3Aa66pW/K2yZQPiFrCmkSj3GJuiDLM=; b=dug64ziXnWg8AuE4nv8wgbM7v3nzYTYT7ebtt8yqTlOY5uuIWUiU4hzSzXmWzL7kSh 10uUm1H32AU0rEXun98fnkHV2JsGJEPiEfDOPXSaWe5sJCxLpW/Fjcnt5JiWraWU+heD u33wIXKO5Xb4P4C+AyaMGxT800DpFxCSg7EJjDzKukKOAlKE6d6ngakbO4oH9x9t1Y/X JkwZK5LjMvijwgykI68zMLcvlvkgjQsj4APj6oBwlrZfrdLOOBNH56A+Ow+P9mnOPeBs HkME60nXPWrr0btwanTjIQypUOMr2eDSXUDfFdtZr8Kp/TnhKenAvmENVqDb0u+ZET+J GJCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iqnjfyS128j8f3Aa66pW/K2yZQPiFrCmkSj3GJuiDLM=; b=MSsezRsPFNG/mSV04qPPL5BJ7CVp8JZzmuHrY2PHGtRFsOeSzn9FB1q314+gCOsE9M eW9HEXApOXN3fYm7Dp+uCGDrH1/6A5tqlQuXnNsx9wKaMrMjgS877AlB0n0HdId/uO7Z LSLS7ynPtV02U4eGrf+4yPnmnuDdJU4dT78j8L8C0qb+TjGuip0/F8txRtr44AcRQFLB gXs3NCKAM47qg9/hZGsDXmHNv6f4kHtP702CNu8o7WY7hRfw52qVmRgGPIJrUjE+zO3f FII+ZKIi5KP31U8fWoIsdyKzPy9he34WQArKIvQ0fh/V2Ko5Ph2iIJ+GE4NXIslFqz7D L6pg== X-Gm-Message-State: AOAM530OYRBAQkFA1l2WPnXH3Wd7TIItvQZLBbrpPTcm6hFFS/do/5or XsgZ1o25ZK98kgHCfoQGFf/lohaFwJ8= X-Google-Smtp-Source: ABdhPJw4br10r4XQsT6Ooy66A8BDeeAp6azRpDI8HA2gbyYbwvTMjGwQ0WQF2v+iBycuHJn0pbl6ww== X-Received: by 2002:a0c:e4c1:: with SMTP id g1mr14093776qvm.64.1630970280832; Mon, 06 Sep 2021 16:18:00 -0700 (PDT) Received: from hurd (dsl-10-132-185.b2b2c.ca. [72.10.132.185]) by smtp.gmail.com with ESMTPSA id 21sm7563325qkk.51.2021.09.06.16.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 16:18:00 -0700 (PDT) From: Maxim Cournoyer References: <87k0oa4o7h.fsf@yoctocell.xyz> <871r9kl1tr.fsf@yoctocell.xyz> <87pmukuhsf.fsf@systemreboot.net> <87v93d24tx.fsf@yoctocell.xyz> <8735qhbnj7.fsf@gmail.com> Date: Mon, 06 Sep 2021 19:17:59 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Mon, 06 Sep 2021 20:05:54 +0200") Message-ID: <87v93d8fa0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630970350; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=iqnjfyS128j8f3Aa66pW/K2yZQPiFrCmkSj3GJuiDLM=; b=I0nn9DYFfUuaOyTCkKokvMTtvKaU4F3kqnd53MfUpVn/QYJ3a0jmsMxw9/YDYGb+QTkJei UCw0SqIFDbPKKsTBhgc3VGMseVPB+8D8jXgF5b2YisC5XBouDWWeWBesSq5E5mbNyQwRbo M42Jm/BXjVk1JX000WD/cdtnqx5qDSTg79dkBB0Fi37t24/5egIgdqs+8wgdmmUXf90Ulm kR4MVwh3zhzaWa2s4Qz00gqBcKqkBYj1m26VKN7kWW33wwLLtSsgIBl/+v59Ch1d9PnHTO FjTf9GiLvboKSJaPs3E4JtZr4GOmsect/UenuWZibi9zRJWncQQCJ936wvgFLw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630970350; a=rsa-sha256; cv=none; b=tEDGfIrrzcmVt6lMQISs3H+nl9k3iFuXfoWAOH86Dz4AMuHMKszdMOj+zt/1ASuMVsbI73 HJQCN5/sRK8DLACLsX1Bq2hHgd86iu2HE6USkWA6hMLt6ZtrhvOXnHDfj51+1kYkuAgVGt oIsZ1F1O3PHLlEoCSM4XvNZYzZjgwP0CXGxXMhwp6tayARVJdZbBJ5x3BiD+Zoo4BI46ij SDdFkqZDpWEFcb7ghbMSmrcz87CrEDzVVKuespw49aTjMqsw7Iu4WASMWrsSkcJJhv8eqZ DxDJk9JMScHmHZPg6aDKVcj4YCxu758qbKNYCV4h8pJgT/q3P2E5KV0sc2s1uQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dug64ziX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.18 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dug64ziX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 99A0519A69 X-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com X-TUID: lg1AMq965GBL Hello, Liliana Marie Prikler writes: > Am Montag, den 06.09.2021, 13:51 -0400 schrieb Maxim Cournoyer: >> Hello Arun, >> >> Xinglu Chen writes: >> >> > On Wed, Aug 11 2021, Arun Isaac wrote: >> > >> > > Hi all, >> > > >> > > I actually think we should not add emacs-vertico to the >> > > propagated-inputs, and remove emacs-flycheck and emacs-selectrum >> > > as well. All these are optional dependencies, and we should leave >> > > it to the user to install the ones they want. At least in this >> > > specific case, the three packages (flycheck, selectrum and >> > > vertico) are the kind the user would want to explicitly install. >> > > They aren't backend libraries that ought to remain invisible to >> > > the user. >> > > >> > > In fact, this is the version of emacs-consult I have installed in >> > > my profile. >> >> Guix packages typically come as featureful as possible unless there >> are good reasons not too (to minimize the closure size, for >> example). In this case, the added optional dependencies seem to have >> negligible effect on the closure size, according to `guix size`; I'd >> be in favor to keep the optional dependencies specified for that >> reason, unless there are other considerations that I'm missing. > While closure size is normally a good metric, with interpreted > languages like Emacs Lisp you have the added baggage of *propagating* > inputs, thereby installing stuff at user (or system) level, that the > user did not actually ask for. My personal take on those is to provide > them as inputs where necessary to compile, but not actually propagate > them where not necessary to run. Thanks for explaining. It makes sense, although there would probably be exceptions. I'm thinking for example about emacs-elpy, for which not propagating optional dependencies would render the package nearly useless out of the box. > For example, an Emacs package might require emacs-dash to function at > all and might install some autocompletion stuff with > emacs-autocomplete or emacs-company (perhaps even both). emacs-dash > absolutely must be propagated, but unless you're already using > autocomplete or company and thus have them in your manifest, you > probably don't want them to be installed by emacs-foo. Does this make > sense? >From a purity sense, yes, but propagating autocomplete or company wouldn't cause any problems in practice, no? As another possible option to explore to avoid propagation could be to develop a runpath equivalent for the Emacs compiled format (.elc). More work, but more definitive! Thank you, Maxim