From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8OY8LQKqZmGIvgAAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 11:42:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KDUBKQKqZmGtZgAAB5/wlQ (envelope-from ) for ; Wed, 13 Oct 2021 09:42:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7E6781C7E1 for ; Wed, 13 Oct 2021 11:42:26 +0200 (CEST) Received: from localhost ([::1]:55356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maamH-0004Kx-3u for larch@yhetil.org; Wed, 13 Oct 2021 05:42:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maaVS-0005Dn-3V for guix-patches@gnu.org; Wed, 13 Oct 2021 05:25:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maaVR-0004Kx-PX for guix-patches@gnu.org; Wed, 13 Oct 2021 05:25:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maaVR-0006wP-LE for guix-patches@gnu.org; Wed, 13 Oct 2021 05:25:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50873] [PATCH 0/5] Fixes to =?UTF-8?Q?=E2=80=98guix?= home =?UTF-8?Q?import=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Oct 2021 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: Oleg Pykhalov , 50873@debbugs.gnu.org, Andrew Tropin Received: via spool by 50873-submit@debbugs.gnu.org id=B50873.163411705326618 (code B ref 50873); Wed, 13 Oct 2021 09:25:01 +0000 Received: (at 50873) by debbugs.gnu.org; 13 Oct 2021 09:24:13 +0000 Received: from localhost ([127.0.0.1]:58295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaUf-0006vG-I1 for submit@debbugs.gnu.org; Wed, 13 Oct 2021 05:24:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaUd-0006v3-0n for 50873@debbugs.gnu.org; Wed, 13 Oct 2021 05:24:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51054) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maaUW-0003J1-WA; Wed, 13 Oct 2021 05:24:05 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57449 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maaUW-00040P-3M; Wed, 13 Oct 2021 05:24:04 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <9db0424f9494d3d15e534eb75773ae9bd3f33cb3.1633861021.git.public@yoctocell.xyz> Date: Wed, 13 Oct 2021 11:24:00 +0200 In-Reply-To: <9db0424f9494d3d15e534eb75773ae9bd3f33cb3.1633861021.git.public@yoctocell.xyz> (Xinglu Chen's message of "Sun, 10 Oct 2021 12:20:11 +0200") Message-ID: <87v921qnv3.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634118146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=p6jXRP1C4/3LMxCmBX5d9m9SoAvmCBDWdlt7hwNBtO8=; b=aJ0U6TRIbDjAyrZGDZ2+YF4XsxIA+oeziV25DSzbnTjXBfNWwPVt6vFMDHOM7bWxtuOaZs Qm5WrTm1CKx7FBCjUByAGo3cnjelWzdEZRNWkjEsMWUHEZxs3XArITUojXyXqAHZQDL2Cn +XwVMfrJply80u6EE6EXYhnFypXvsw9ntBtBWQQKpdtIzjPzx7OqHiYQ1Ue6Hk9pffDzB6 voYCT/mSzbyn4mVTZ4A+blGhhJ8leCqka26OBwBKo0TaFKYL+wV4X9FRj8HNyOZUsYfPz+ d5BXSUS6p9o48nrwHhP90sKrRXrSYqm1gN6YoVKsbk+ztYgpwRr3tfrVqA+gmg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634118146; a=rsa-sha256; cv=none; b=jWr0DmraNmPBsfhnxpOiukQjyqxGr2weBilb81Ixwk22PQG6BwlW+uVssrxtFF5nvZOcXN lUBsEkxDaqsKHXgEJ2/6ntp7bdGLS0hUWp+rJslnisbmTm2s/Y4hxLmFmrAkXNcsiwdERo dC72MwneTl7VinCWF/DBBHkC6zYzQdvm35Nrak0gPjQsM8mlQalnnRdO9H7j5+LzLHwpcn SxD2Sd9wZxae0RvP1PFQGpmFWreli5PQvTqnx6HChzFOdYLb3bwg2WezFM9XSjQvSfEiZ1 qspT/e0j1t9Z5fuY6HC7qamrchtLII9+iyld/xtiOC59JrX5pXK7TnS8Et+A7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7E6781C7E1 X-Spam-Score: -1.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8U/TWvJjnO+1 Hello, Xinglu Chen skribis: > Copy the appropriate the relevant configuration files to the destination > directory, and call =E2=80=98local-file=E2=80=99 on them. > > Without this, =E2=80=98guix home import=E2=80=99 will generate a service = declaration like this > > (service > home-bash-service-type > (home-bash-configuration > (bashrc > (list (slurp-file-gexp > (local-file "/home/yoctocell/.bashrc")))))) > > but when running =E2=80=98guix home reconfigure=E2=80=99, the ~/.bashrc f= ile would be moved, so > when running =E2=80=98guix home reconfigure=E2=80=99 for the second time,= it would read the > ~/.bashrc which is itself a symlink to a file the store. Ooh, good catch! > * guix/scripts/home/import.scm (%destination-directory): New parameter. > (generate-bash-module+configuration): Adjust accordingly. > (modules+configurations): Copy the user=E2=80=99s configuration file to > =E2=80=98%destination-directory=E2=80=99. > * guix/scripts/home.scm (process-command): Adjust accordingly; create > =E2=80=98%destination-directory=E2=80=99 if it doesn=E2=80=99t exist. [...] > +(define %destination-directory > + (make-parameter (string-append (getenv "HOME") "/src/guix-config"))) Instead of making it a parameter, with a default value that looks fishy but is never actually used :-), can we make it an explicit parameter of =E2=80=98generate-bash-module+configuration=E2=80=99? Otherwise LGTM! Thanks, Ludo=E2=80=99.