From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wG4uJVT5e2HZSAEAgWs5BA (envelope-from ) for ; Fri, 29 Oct 2021 15:38:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ABbdIFT5e2EpKAAAB5/wlQ (envelope-from ) for ; Fri, 29 Oct 2021 13:38:28 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5691C22368 for ; Fri, 29 Oct 2021 15:38:28 +0200 (CEST) Received: from localhost ([::1]:54852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgS5S-0006pp-PH for larch@yhetil.org; Fri, 29 Oct 2021 09:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgS54-0006p6-EO for guix-patches@gnu.org; Fri, 29 Oct 2021 09:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mgS54-0003E2-68 for guix-patches@gnu.org; Fri, 29 Oct 2021 09:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mgS54-0001NG-3a for guix-patches@gnu.org; Fri, 29 Oct 2021 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50873] [PATCH 0/5] Fixes to =?UTF-8?Q?=E2=80=98guix?= home =?UTF-8?Q?import=E2=80=99?= Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Oct 2021 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Oleg Pykhalov , 50873@debbugs.gnu.org, Andrew Tropin Received: via spool by 50873-submit@debbugs.gnu.org id=B50873.16355146685261 (code B ref 50873); Fri, 29 Oct 2021 13:38:02 +0000 Received: (at 50873) by debbugs.gnu.org; 29 Oct 2021 13:37:48 +0000 Received: from localhost ([127.0.0.1]:54250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgS4p-0001Mm-W4 for submit@debbugs.gnu.org; Fri, 29 Oct 2021 09:37:48 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:53320 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mgS4k-0001MS-TK for 50873@debbugs.gnu.org; Fri, 29 Oct 2021 09:37:47 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1635514656; bh=WzqxqUEAa/ppcXLrhxYM7ZS9G4BNnYpsCyVhdJr4/pE=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=CkE0wBVQeyKpK9K8sCSsIOhpekfR9TCRNHupe4y5xbNZMahzcnVrdeJFrIRPWZYaD EuTql7hT9ZUPyVdMD1vcMx2lbHmmRTCCCJvg/DeysmRBmmlTU8zKVaGgOv/vMhLvEe A5a5SL8HcD4+TvU90Sg4WvUqUnsRRRTT5MnIwEyo= In-Reply-To: <87v921qnv3.fsf_-_@gnu.org> References: <9db0424f9494d3d15e534eb75773ae9bd3f33cb3.1633861021.git.public@yoctocell.xyz> <87v921qnv3.fsf_-_@gnu.org> Date: Fri, 29 Oct 2021 15:37:03 +0200 Message-ID: <87v91g7y0w.fsf@disroot.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635514708; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ddM9UMEcX9IXl52I4l3BDus3f6BgPw+xK8Uzyr/njGk=; b=jk5/R1QfQBAvkTbIL/qjnaPVjdaVeFvYQ7u6sySGnXcwPTNk/8/HVTDk3qN4Iv9RsmI/tC 3dGVY+jcvN7TRopco+Lmrwd46PBbUQm1ilvEhZsWDEN/D6kLXFsSf8bMIaua2w5SocXDux 0ocH7SU2oExs1enyd2DvzZdGZLJE1bZUXyKn+LjEt+U75US2xOfrqpPh1BFUrc4UfFkVeu CxjuUWAfCvL96iIvn4+2smyU5YhXAtYwndJJoPAqgJ63fQmAwNPiF8fzTaRgq6CWX277kB nvF6VsPmmGxGfrl4DP1dd8g/ISwp7h146Uaw4eHCcwxct2TDwmGML9d6cTQfCQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635514708; a=rsa-sha256; cv=none; b=s7gBFKNzIUExij3HzSvKBZNvNwZeOGJTrWgdIotHKLlpFCyupZnPEMq6gRz9b7NDELw9bp xUrUpwiLuHuxLuPx0HMlYuTxzaHJFR0ZuiQO934XrZOol/ZEMcwcVaEHWS45nIN4OHJF/1 tBiMYHtXsZ4kmMxevig9fSdUd6WpfuGxEg0jNWT0EHROrAucrIVThbmYuG6gdV8KxbxYD1 fL8rKCtEIl/7+ejKMNYdZ44cM5yK1hROLG8k/OB7jLx1P+gft1LWzCFV0XUDi4FKebT0zw Ik08ZtQhXomggsUUgG5SsVvKoqIOWyyYl6J+mRpgDpZFvYrQf3Vluvy8jW+ILA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=CkE0wBVQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=yoctocell.xyz header.s=mail header.b=CkE0wBVQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=yoctocell.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5691C22368 X-Spam-Score: -1.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: i8ooUZJB22HC --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, (sorry for taking so long to get to this!) On Wed, Oct 13 2021, Ludovic Court=C3=A8s wrote: > Hello, > > Xinglu Chen skribis: > >> Copy the appropriate the relevant configuration files to the destination >> directory, and call =E2=80=98local-file=E2=80=99 on them. >> >> Without this, =E2=80=98guix home import=E2=80=99 will generate a service= declaration like this >> >> (service >> home-bash-service-type >> (home-bash-configuration >> (bashrc >> (list (slurp-file-gexp >> (local-file "/home/yoctocell/.bashrc")))))) >> >> but when running =E2=80=98guix home reconfigure=E2=80=99, the ~/.bashrc = file would be moved, so >> when running =E2=80=98guix home reconfigure=E2=80=99 for the second time= , it would read the >> ~/.bashrc which is itself a symlink to a file the store. > > Ooh, good catch! > >> * guix/scripts/home/import.scm (%destination-directory): New parameter. >> (generate-bash-module+configuration): Adjust accordingly. >> (modules+configurations): Copy the user=E2=80=99s configuration file to >> =E2=80=98%destination-directory=E2=80=99. >> * guix/scripts/home.scm (process-command): Adjust accordingly; create >> =E2=80=98%destination-directory=E2=80=99 if it doesn=E2=80=99t exist. > > [...] > >> +(define %destination-directory >> + (make-parameter (string-append (getenv "HOME") "/src/guix-config"))) > > Instead of making it a parameter, with a default value that looks fishy > but is never actually used :-), can we make it an explicit parameter of > =E2=80=98generate-bash-module+configuration=E2=80=99? Ah, that would be a good idea. :-) =20=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmF7+P8VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5bxUP/273Md93z9+YNm4vRYPjbaC/EBQB 0IdCRVkmcUrqOkmv25RDOVSoHDMMFfYS2wf0lAIh23rCOdXUIH+QJV/vtYgv0tNH ljVUySJxZ/74M0YB+FCikJA+/BVG79eNoLma47aYoK0ZBLKXuUnIladGFpC6SUQr GqmJ4EteGWBdpSrimATvwY2YiCQjSbsCG+moMhV2V6H8u/pXxZtPIQcDEoGN75tJ fMBsYDDvCvZCZFY3xw75JZ61K807RwGn7t696LBIstfLHdlkP+28ILDyQyz5t9+B yKQv9bi8KcN2C8NXW5ProdwWs2Kxk/M6aXCj2XFLVXbftaP8ZUTD3JzOnGBJvNn7 ZQ+CNqjE78dwcgUwXHVHLXlluZ6FAwiZrqjYeLfUG+kSuUNXXQG00MFNiL5qSGQP JoHX1hwgYsueosgAYn0nXAynf2FbNqoOyHSv9xzlYZU+bN1t8hPQ8a9hikwE4Z6D WZpD0lyGlU6xGYpGtckPNhhWCIjljGxw6DV7Gm7hw9A8/ft4oJrsIwztZA+1pskP QiatFUlpljZuuMHDlWkV8URxmNE8yY19fOe5dPN2t5/AiNxz+lKUAgxaUyQPxLVr Q0eOVNd3d+47mHggkKh9v9Grs0L2/h+y+bgPlSojb85dztzQL03r/rYSRwWkrJEh puUtbXZFHPMqQP66 =TzQO -----END PGP SIGNATURE----- --=-=-=--