unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: david larsson <david.larsson@selfhosted.xyz>
Cc: 51432@debbugs.gnu.org
Subject: [bug#51432] [PATCH 4/4] gnu: Add flask-combo-jsonapi
Date: Wed, 03 Nov 2021 14:46:59 +0100	[thread overview]
Message-ID: <87v9195dxk.fsf@nckx> (raw)
In-Reply-To: <a5afd7ee3981d2b8c4af3cfc909a4083@selfhosted.xyz>

[-- Attachment #1: Type: text/plain, Size: 1714 bytes --]

David,

> Version 2 of this patch, fixing the synopsis according to coding
> standards max 80 chars.

Thanks!  Be sure to run ‘guix lint’ on each package as well.

> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/AdCombo/flask-combo-jsonapi/archive/"
> +             version ".tar.gz"))

GitHub /archive/ have proven unstable in the past: they can be 
regenerated at GitHub's discretion and no longer match our hash.

I replaced url-fetch with git-fetch.

> +    (native-inputs `(("python-coverage" ,python-coverage)

This alignment is at least inconsistent with propagated-inputs 
above.  Furthermore I simply dislike it, so I changed it :-)

> +    (native-inputs
> +     `(("python-coverage" ,python-coverage)

I shortened the description a smidge and rewrote the following 
sentence fragment:

> +    (description
> +     "Flask extension to create REST web api according to 
> JSON:API 1.0
> +specification with Flask, Marshmallow and data provider of your
> +choice (SQLAlchemy, MongoDB, ...)")

as:

+    (description
+     "Flask-COMBO-JSONAPI is a Python Flask extension for 
building REST Web APIs
+compliant with the @uref{https://jsonapi.org, JSON:API 1.0} 
specification.
+
+It tries to combine the power of Flask-Restless with the 
flexibility of
+Flask-RESTful to quickly build APIs that fit the complexity of 
existing
+real-life projects with legacy data and diverse storage 
providers.")

I deliberately removed the reference to MongoDB because it's not 
of any particular significance and non-free.  I also removed 
several more gratuitous references in Guix proper.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2021-11-03 17:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 10:52 [bug#51432] [PATCH 0/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 10:56 ` [bug#51432] [PATCH 1/4] gnu: Add sqlalchemy-1.3 david larsson
2021-11-03 13:27   ` bug#51432: " Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 10:59 ` [bug#51432] [PATCH 2/4] gnu: Add marshmallow 3.2 david larsson
2021-11-03 14:30   ` Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 11:01 ` [bug#51432] [PATCH 3/4] gnu: Add marshmallow-jsonapi david larsson
2021-11-03 13:34   ` Tobias Geerinckx-Rice via Guix-patches via
2021-10-27 11:02 ` [bug#51432] [PATCH 4/4] gnu: Add flask-combo-jsonapi david larsson
2021-10-27 18:44   ` david larsson
2021-11-03 13:46     ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9195dxk.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=51432@debbugs.gnu.org \
    --cc=david.larsson@selfhosted.xyz \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).