* [bug#52113] [PATCH] gnu: Add pnmixer
[not found] <529632162.5471310.1637869688182.ref@mail.yahoo.com>
@ 2021-11-25 19:48 ` Jaft
2021-12-05 20:43 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Jaft @ 2021-11-25 19:48 UTC (permalink / raw)
To: 52113
* gnu/packages/gtk.scm (pnmixer):Add PNMixer
---
gnu/packages/gtk.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 4e427deaef..782dfebdb2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -27,6 +27,7 @@
;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
;;; Copyright © 2021 Leo Famulari <leo@famulari.name>
;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
+;;; Copyright © 2021 Wamm K. D. <jaft.r@outlook.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -50,6 +51,7 @@ (define-module (gnu packages gtk)
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module ((guix build utils) #:select (alist-replace))
+ #:use-module (guix build-system cmake)
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system meson)
@@ -2474,3 +2476,40 @@ (define-public volctl
;; XXX: 'setup.py' says "GPLv2" but nothing says "version 2 only". Is
;; GPLv2+ intended?
(license license:gpl2)))
+
+(define-public pnmixer
+ (let ([version "0.7.2"])
+ (package
+ (name "pnmixer")
+ (version version)
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nicklan/pnmixer/")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256 (base32
+ "0416pa933ddf4b7ph9zxhk5jppkk7ppcq1aqph6xsrfnka4yb148"))
+ (modules '((guix build utils)))))
+ (build-system cmake-build-system)
+ (arguments `(#:phases (modify-phases %standard-phases (delete 'check))))
+ (native-inputs `(("pkg-config" ,pkg-config)
+ ("gettext" ,gettext-minimal)))
+ (inputs `(("alsa-lib" ,alsa-lib)
+ ("glib" ,glib)
+ ("libx11" ,libx11)
+ ("gtk+" ,gtk+)
+ ("libnotify" ,libnotify)))
+ (home-page "https://github.com/nicklan/pnmixer/")
+ (synopsis "Simple mixer application designed to run in your system tray")
+ (description "PNMixer is a simple mixer application designed to run in your
+system tray. It integrates nicely into desktop environments that don't have a
+panel that supports applets and therefore can't run a mixer applet. In
+particular, it's been used quite a lot with fbpanel and tint2 but should run
+fine in any system tray.
+
+PNMixer is designed to work on systems that use ALSA for sound management. Any
+other sound driver like OSS or FFADO are, currently, not supported. There is no
+official PulseAudio support, at the moment, but it seems that PNMixer behaves
+quite well anyway when PA is running.")
+ (license license:gpl3))))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#52113] [PATCH] gnu: Add pnmixer
2021-11-25 19:48 ` [bug#52113] [PATCH] gnu: Add pnmixer Jaft
@ 2021-12-05 20:43 ` Nicolas Goaziou
2021-12-16 21:40 ` Jaft
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2021-12-05 20:43 UTC (permalink / raw)
To: Jaft; +Cc: 52113
Hello,
Jaft <jaft.r@outlook.com> writes:
> * gnu/packages/gtk.scm (pnmixer):Add PNMixer
Thank you. Some comments follow.
> +(define-public pnmixer
> + (let ([version "0.7.2"])
Nitpick: we don't use square brackets for let. Besides, you do not need
a binding here, you just need to hard-code it in the version field.
> + (package
> + (name "pnmixer")
> + (version version)
> + (source (origin
Could you move origin below source?
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/nicklan/pnmixer/")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256 (base32
> + "0416pa933ddf4b7ph9zxhk5jppkk7ppcq1aqph6xsrfnka4yb148"))
Could you move base32 below sha256 and put the hash string in front of base32?
> + (modules '((guix build utils)))))
The modules part is not required. You can remove it.
> + (build-system cmake-build-system)
> + (arguments `(#:phases (modify-phases %standard-phases (delete 'check))))
The correct way to do this is to add a "#:tests? #f" argument, with
a comment explaining why you are disabling tests.
> + (native-inputs `(("pkg-config" ,pkg-config)
> + ("gettext" ,gettext-minimal)))
Native inputs should be ordered alphabetically. Besides, the list should
be moved on the line below native-inputs.
> + (inputs `(("alsa-lib" ,alsa-lib)
> + ("glib" ,glib)
> + ("libx11" ,libx11)
> + ("gtk+" ,gtk+)
> + ("libnotify" ,libnotify)))
Ditto: please order inputs alphabetically and move them below the inputs
field name.
> + (home-page "https://github.com/nicklan/pnmixer/")
> + (synopsis "Simple mixer application designed to run in your system tray")
Nitpick: you can remove "your" in the synopsis
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#52113] [PATCH] gnu: Add pnmixer
2021-12-05 20:43 ` Nicolas Goaziou
@ 2021-12-16 21:40 ` Jaft
2021-12-17 8:06 ` bug#52113: " Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Jaft @ 2021-12-16 21:40 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 52113@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
> On Sunday, December 5, 2021, 02:43:27 PM CST, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
>
>
>
>
> Hello,
>
> Jaft <jaft.r@outlook.com> writes:
>
> > * gnu/packages/gtk.scm (pnmixer):Add PNMixer
>
> Thank you. Some comments follow.
>
> > +(define-public pnmixer
> > + (let ([version "0.7.2"])
>
> Nitpick: we don't use square brackets for let. Besides, you do not need
> a binding here, you just need to hard-code it in the version field.
Bah; sorry about that. It was mentioned to me, before, and I must've forgotten to change it before I sent this out. I probably should check my other patch submissions around this time as I probably forgot for those, as well…
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
Thanks a ton for looking at my patch; all updates should've been applied and I've attached the new patch to this E-mail.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pnmixer2.patch --]
[-- Type: text/x-patch, Size: 2625 bytes --]
* gnu/packages/gtk.scm (pnmixer): Add PNMixer
---
gnu/packages/gtk.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index a7e5d10e10..8b3184389a 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -28,6 +28,7 @@
;;; Copyright © 2021 Leo Famulari <leo@famulari.name>
;;; Copyright © 2021 Simon Streit <simon@netpanic.org>
;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
+;;; Copyright © 2021 Wamm K. D. <jaft.r@outlook.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -52,6 +53,7 @@ (define-module (gnu packages gtk)
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module ((guix build utils) #:select (alist-replace))
+ #:use-module (guix build-system cmake)
#:use-module (guix build-system glib-or-gtk)
#:use-module (guix build-system gnu)
#:use-module (guix build-system meson)
@@ -2833,3 +2835,41 @@ (define-public volctl
;; XXX: 'setup.py' says "GPLv2" but nothing says "version 2 only". Is
;; GPLv2+ intended?
(license license:gpl2)))
+
+(define-public pnmixer
+ (package
+ (name "pnmixer")
+ (version "0.7.2")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nicklan/pnmixer/")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0416pa933ddf4b7ph9zxhk5jppkk7ppcq1aqph6xsrfnka4yb148"))))
+ (build-system cmake-build-system)
+ (arguments `(#:tests? #f)) ; no check target
+ (native-inputs
+ `(("gettext" ,gettext-minimal)
+ ("pkg-config" ,pkg-config)))
+ (inputs
+ `(("alsa-lib" ,alsa-lib)
+ ("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("libnotify" ,libnotify)
+ ("libx11" ,libx11)))
+ (home-page "https://github.com/nicklan/pnmixer/")
+ (synopsis "Simple mixer application designed to run in system tray")
+ (description "PNMixer is a simple mixer application designed to run in your
+system tray. It integrates nicely into desktop environments that don't have a
+panel that supports applets and therefore can't run a mixer applet. In
+particular, it's been used quite a lot with fbpanel and tint2 but should run
+fine in any system tray.
+
+PNMixer is designed to work on systems that use ALSA for sound management. Any
+other sound driver like OSS or FFADO are, currently, not supported. There is no
+official PulseAudio support, at the moment, but it seems that PNMixer behaves
+quite well anyway when PA is running.")
+ (license license:gpl3)))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#52113: [PATCH] gnu: Add pnmixer
2021-12-16 21:40 ` Jaft
@ 2021-12-17 8:06 ` Nicolas Goaziou
2021-12-17 10:34 ` [bug#52113] " Jaft
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2021-12-17 8:06 UTC (permalink / raw)
To: Jaft; +Cc: 52113-done@debbugs.gnu.org
Hello,
Jaft <jaft.r@outlook.com> writes:
> Thanks a ton for looking at my patch; all updates should've been
> applied and I've attached the new patch to this E-mail.
Thanks.
I completed the commit message, used new inputs style, and applied your
patch.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#52113] [PATCH] gnu: Add pnmixer
2021-12-17 8:06 ` bug#52113: " Nicolas Goaziou
@ 2021-12-17 10:34 ` Jaft
0 siblings, 0 replies; 5+ messages in thread
From: Jaft @ 2021-12-17 10:34 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 52113-done@debbugs.gnu.org
Awesome; thanks so much, Nicolas!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-17 10:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <529632162.5471310.1637869688182.ref@mail.yahoo.com>
2021-11-25 19:48 ` [bug#52113] [PATCH] gnu: Add pnmixer Jaft
2021-12-05 20:43 ` Nicolas Goaziou
2021-12-16 21:40 ` Jaft
2021-12-17 8:06 ` bug#52113: " Nicolas Goaziou
2021-12-17 10:34 ` [bug#52113] " Jaft
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).