From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4ASEAC9xJmLOnwAAgWs5BA (envelope-from ) for ; Mon, 07 Mar 2022 21:55:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yE15NC5xJmLALQEAG6o9tA (envelope-from ) for ; Mon, 07 Mar 2022 21:55:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A0258E54 for ; Mon, 7 Mar 2022 21:55:10 +0100 (CET) Received: from localhost ([::1]:54324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRKNp-0007AZ-31 for larch@yhetil.org; Mon, 07 Mar 2022 15:55:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKNi-0007AQ-HU for guix-patches@gnu.org; Mon, 07 Mar 2022 15:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRKNi-00056c-8z for guix-patches@gnu.org; Mon, 07 Mar 2022 15:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nRKNi-00040w-5o for guix-patches@gnu.org; Mon, 07 Mar 2022 15:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53327] [PATCH] gnu: Add mold. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Mar 2022 20:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Rottmann Cc: Maxime Devos , 53327@debbugs.gnu.org Received: via spool by 53327-submit@debbugs.gnu.org id=B53327.164668644215351 (code B ref 53327); Mon, 07 Mar 2022 20:55:02 +0000 Received: (at 53327) by debbugs.gnu.org; 7 Mar 2022 20:54:02 +0000 Received: from localhost ([127.0.0.1]:54702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRKMk-0003zX-Ji for submit@debbugs.gnu.org; Mon, 07 Mar 2022 15:54:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRKMi-0003z2-Ju for 53327@debbugs.gnu.org; Mon, 07 Mar 2022 15:54:01 -0500 Received: from [2001:470:142:3::e] (port=51718 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKMc-0004yC-Ga; Mon, 07 Mar 2022 15:53:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rEmn+Stan4SFW6bss/j31SnP3kQgfEvzMS/aC0ynbo0=; b=JoyUhW/uJxF23HXFob/y y1dGAQXaah7CaXws01AGznyORaqUyFy4xfJqgPUEmwrAEt5rnQwFJtfEvIxgiBgjLUrR4cytZMpEW PItJYrCWE48kSLxDNeoTM+oMjzn6ZUWx3Q/OTr547E7Xovz05BOKWRxSDvjSG5Fo7EMIAuHPZrAK8 8fRIOwKIW328Y2uVi0H5yDwLoyfc7hAzjot+PJOfQMFCUHo7+cn94iIdxJXv7wGbu8mReWfIL8/Xe 7OI8lfqD4V/Cna74m53blsoYt6pAs6IKdOykixIsbTKvdvJ1oYoAns/FSfhluXSMiStQrTVEoC/PZ XeNZj82ypnplIg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61289 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRKMc-0000hN-0b; Mon, 07 Mar 2022 15:53:54 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87fspmyuji.fsf@r0tty.org> <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@telenet.be> Date: Mon, 07 Mar 2022 21:53:52 +0100 In-Reply-To: <93ded3273884b0afcd5ae9b654351b3568e334c2.camel@telenet.be> (Maxime Devos's message of "Thu, 20 Jan 2022 21:16:09 +0100") Message-ID: <87v8wpa3hb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646686510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rEmn+Stan4SFW6bss/j31SnP3kQgfEvzMS/aC0ynbo0=; b=GZPmr3gGe5EsaW5LHyfsdhyEzz/NWI1eTkpG29Ay7p7q/cEjEKZsWoiLald0drzSsxAMSA wC/5ri+N54JRhmJAByJrzcvXOVjc1syIxkoABDVE1C9vv3hO8q188xMU3eYXD40Ejngoa2 NGgAJiuBc+ikt2y4507dXFgxZKOGUM/AmTBixghaSCGsUbVlVwitPggADc5hLxI++ORFeF bQldA1AEo3/XV1CzTOFsNnl1w9N46UqPlaZCb+0K3J2hNQv9EHeGKh2Zul2OHEwt+/g1LW wH9oSjV2xnr7YZVYqpQqQgY1u7FAy3WjWY4k6jgI21fOvpya5vCJ5nV9s0fj9Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646686510; a=rsa-sha256; cv=none; b=RUAIKqz84VqQSCnl85dH+skhofmKJeYgxvVCsdM8d/zrhLA5NX8mk8v1uXRT18OPUw5nDY RAWnVATNNCWtiuVB48fE5oUnIDvqO3Ys+9r4ux7sbbvAWEKb5afi7mbY45BT/mGtkr7N4b 0FLz7pICJswGG1sXDiHQAWB5g3lCBPsZOHDhw+315gejpVCp5U6pJFIPFkTgVEH43i+KPO za1A29OUqQpL9hjUOtzaZO8zPNkt610C2WJCKB4jE7dPbKOwSO0vZR9OaVtBcT8YTk8wBg hoRWHa7PCYCgBd94Bh4AzwnMZBeCPxFLiSeROXCRbsQcNLJ3ORH8RzB4JA4afw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="JoyUhW/u"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.72 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="JoyUhW/u"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7A0258E54 X-Spam-Score: -4.72 X-Migadu-Scanner: scn0.migadu.com X-TUID: JBXUD4OWOPPw Hi Andreas, Long time no see! ;-) Did you have a chance to look into Maxime=E2=80=99s suggestions? https://issues.guix.gnu.org/53327 (I have nothing to add to what Maxime wrote.) TIA, Ludo=E2=80=99. Maxime Devos skribis: > Hi, > > (*partial* review) > > There's a directory 'third_party' with bundled code, can it be removed > (in an origin snippet)? > > Andreas Rottmann schreef op ma 17-01-2022 om 20:56 [+0100]: >> +=C2=A0=C2=A0=C2=A0=C2=A0 `(#:tests? #f ; TODO: Tests require clang and = hardcode `cc` > > 'clang' =C2=A0can be added to native-inputs and hardcoded =E2=80=98cc=E2= =80=99 can be > replaced with 'clang' or 'gcc' with 'substitute*'. > >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:make-flags (list (string-append = "CC=3D" ,(cc-for-target)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (string-append "CXX=3D" ,(cxx-for-target)) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (string-append "PREFIX=3D" %output)) > > %output is being phased out, instead use #$output (make sure to add ,#~ > before (list ...)). > >> + (inputs (list openssl zlib xxhash)) > > Why does mold need openssl here? I don't see the relation between > linking and TLS. > >> +=C2=A0=C2=A0=C2=A0 (synopsis "Modern Linker") > > Why is =E2=80=98Linker=E2=80=99 capitalised? Also, as I understand it, t= he point > of=C2=A0mold is not chasing whatever is considered =E2=80=98modern=E2=80= =99, but rather > being fast and requiring little memory, albeit at the cost of > supporting less (less targets, no linker scripts, ...). > >> + (description "mold is a faster drop-in replacement for existing > Unix linkers.") > > It's a bit short, maybe you could write a bit about memory usage, > limitations > > Since 'mold' is said to be very efficient, it might be interesting to > determine if Guix could use 'mold' instead of the linker from > 'binutils' by default (with some exceptions like GRUB and Linux which > might actually need GNU ld linker scripts) ... that's more something > for guix-devel and future patches though. > > Greetings, > Maxime.