From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ONozMrh/uGLjSAAAbAwnHQ (envelope-from ) for ; Sun, 26 Jun 2022 17:48:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CA0YMrh/uGK1owAA9RJhRA (envelope-from ) for ; Sun, 26 Jun 2022 17:48:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4FBF41FF53 for ; Sun, 26 Jun 2022 17:48:08 +0200 (CEST) Received: from localhost ([::1]:38706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5UUZ-00074o-7K for larch@yhetil.org; Sun, 26 Jun 2022 11:48:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5UUU-00074P-PL for guix-patches@gnu.org; Sun, 26 Jun 2022 11:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5UUU-0005jF-Gi for guix-patches@gnu.org; Sun, 26 Jun 2022 11:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5UUU-0007u1-Ee for guix-patches@gnu.org; Sun, 26 Jun 2022 11:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56218] [PATCH] guix: inferior: Fix the behaviour of open-inferior #:error-port. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Jun 2022 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56218 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 56218@debbugs.gnu.org Received: via spool by 56218-submit@debbugs.gnu.org id=B56218.165625842729005 (code B ref 56218); Sun, 26 Jun 2022 15:48:02 +0000 Received: (at 56218) by debbugs.gnu.org; 26 Jun 2022 15:47:07 +0000 Received: from localhost ([127.0.0.1]:48765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5UTb-0007XY-9U for submit@debbugs.gnu.org; Sun, 26 Jun 2022 11:47:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5UTZ-0007Re-Fp for 56218@debbugs.gnu.org; Sun, 26 Jun 2022 11:47:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5UTU-0005cW-2b; Sun, 26 Jun 2022 11:47:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=BefgDQVHasrsLSEisg8hTNhLRRl50171Z11i0HCclTE=; b=iuoHj+d2Gn2BjVOHisNU 1qBSyuzhqiCBArYlwrjxvsf6uqCCU1PzfSBhNlmL9oPIWVg5em+RE3MtZwisASzH1VcnsE3qoM0To mfvF9R0ogtETaMT1aVMOKN/5z5q9Best1vJGT207EdSpem+BkrQuS+GNXiy4KAnA4ufVgH0aDeAhf HRTTXWWYmBHtWmj7hb/teYPw5nsO45aX72/2hde1HYXvTjfALNScoNP1mPIzOJ+fgWxGKxqYAFngg DG4bFnkzLyT7+C5z1RK/auCy7Ww/hpY6tR5tCSi43XlTdOZS4t5Cv0GyHyEjWdtFqwsPM/7fxJ5bb 6nRKu8KjXdnJ2g==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:62793 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5UTT-0003LM-Je; Sun, 26 Jun 2022 11:46:59 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220625171847.29104-1-mail@cbaines.net> Date: Sun, 26 Jun 2022 17:46:57 +0200 In-Reply-To: <20220625171847.29104-1-mail@cbaines.net> (Christopher Baines's message of "Sat, 25 Jun 2022 18:18:47 +0100") Message-ID: <87v8snqvf2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656258488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=BefgDQVHasrsLSEisg8hTNhLRRl50171Z11i0HCclTE=; b=OsbIIKI0CkHtzQwfJfWJFVeCRcV+Z6ItsM7LjsJnNWmJmBnEGKaO/r12ju6TR3nW0Ofn1w nUFFuQYvfWNkdErgKtPUvzrLoByE4Swf6PzDIqci+AyogQTs8BI7UH12E5enDzelCB9FwJ XIISod1f87qK8rICd4eosw5sqeQWKGaVO9yCGWKEfATqrGyz5uXXE7D7HSrY+gXk30kluV SXZQI8VAlgbL0vdZD+8XrHT5sCM8efNytoFL968MuiejCWHDsX2ty1B9BwkPlFkS+vXHBj q+13RMlsOKuZAE6CNta+Q7wVoUF0SEOyP/NIUSGtu70HxjvbKca9XVqAtBxEMw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656258488; a=rsa-sha256; cv=none; b=totcKQU1g/5AxAbMRy2M1CDl6OKKt6Y1HA3OXam4QvaMAXjrJuysVvrQhLWdW3LNdAQvdz bLCbRnTLsYf3VW7M8sbzWJQJcERNEzPEOWj1S0SNw+nDZBOrF0Ob2lX3tFZZD1/9LkcXLl trDM6sKSja/E9oYmuqpeDP93Lotwsc+u064HV2XR7ul4Najvxvqv4B31ugsy2wQVJTZy9s g9Gwx8tXC77jrk5ycbgJJzaITbe2F3KF5ZnGoinFRR1o7awjWOkf1ubvTEbL0ZMl3f0Tnt 0wXADdqhFdgxMLjNgvDQ8ukixV/MgN+/GE287zkhxNNhgTqk4ZnMrkgfqx0OZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iuoHj+d2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iuoHj+d2; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4FBF41FF53 X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: osiT8L+Aq93e Hi Christopher, Christopher Baines skribis: > This should be the error port used by the inferior process, but currently= it's > either stderr if #:error-port is a file port, or /dev/null otherwise. That=E2=80=99s still the case with this patch, no? The patch does make a difference when (current-error-port) wraps a file descriptor other than 2 though. > +++ b/guix/inferior.scm > @@ -156,12 +156,14 @@ (define (open-bidirectional-pipe command . args) > (close-port parent) > (close-fdes 0) > (close-fdes 1) > + (close-fdes 2) > (dup2 (fileno child) 0) > (dup2 (fileno child) 1) > ;; Mimic 'open-pipe*'. > - (unless (file-port? (current-error-port)) > - (close-fdes 2) > - (dup2 (open-fdes "/dev/null" O_WRONLY) 2)) > + (dup2 (if (file-port? (current-error-port)) > + (fileno (current-error-port)) > + (open-fdes "/dev/null" O_WRONLY)) > + 2) If (current-error-port) wraps FD 2 when the function is called, then, by the time we reach (dup2 =E2=80=A6 2), the FD behind (current-error-port) ha= s be closed; we end up doing (dup2 2 2), but FD 2 is closed, so we get EBADF. Or am I misunderstanding? Perhaps we should add one test for each case (error port is a file port vs. error port is another kind of port) in =E2=80=98tests/inferior.scm=E2= =80=99. Thanks, Ludo=E2=80=99.