unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: muradm <mail@muradm.net>
To: "(" <paren@disroot.org>
Cc: 56699@debbugs.gnu.org
Subject: [bug#56699] [PATCH] gnu: greetd-service-type: Add greeter-extra-groups config field.
Date: Fri, 05 Aug 2022 09:44:48 +0300	[thread overview]
Message-ID: <87v8r71909.fsf@muradm.net> (raw)
In-Reply-To: <CLO13EG52QG0.F152G8L34MRH@guix-aspire>

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]


supplimentary-groups receiving a list, so I find it more 
informative
when adding apples with apples. And yes with high enough chance
more groups could be added to the list of defaults.

Is there any preference on using cons* in favour of more readable
append?

thanks in advance,
muradm

"(" <paren@disroot.org> writes:

> On Fri Jul 22, 2022 at 12:45 PM BST, muradm wrote:
>> +         ;; video group is required for graphical greeters.
>> +         (supplementary-groups
>> +          (append
>> +           '("video")
>> +           (greetd-greeter-extra-groups config)))
> Change to (cons "video" (greetd-greeter-extra-groups config)) or 
> maybe
> use cons* if you think there's a possibility that more groups 
> will later
> need to be added.
>
> Otherwise SGTM :)
>
>     -- (


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2022-08-05  6:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22 11:45 [bug#56699] [PATCH] gnu: greetd-service-type: Add greeter-extra-groups config field muradm
2022-07-24 16:31 ` ( via Guix-patches via
2022-08-05  6:44   ` muradm [this message]
2022-08-05  7:54     ` Liliana Marie Prikler
2022-08-07 21:42       ` [bug#56699] [PATCH v2] " muradm
2022-08-07 21:48         ` [bug#57047] " muradm
2022-08-07 21:56           ` muradm
2022-08-08  5:41           ` [bug#56699] " Liliana Marie Prikler
2022-08-08 19:27             ` muradm
2022-08-09  6:25               ` Liliana Marie Prikler
2022-08-09 19:40                 ` [bug#56699] [PATCH v4] " muradm
2022-08-10  7:49                   ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8r71909.fsf@muradm.net \
    --to=mail@muradm.net \
    --cc=56699@debbugs.gnu.org \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).