From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SPx/IphwNWNxWgEAbAwnHQ (envelope-from ) for ; Thu, 29 Sep 2022 12:16:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id wMtvIphwNWMg3QAA9RJhRA (envelope-from ) for ; Thu, 29 Sep 2022 12:16:56 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5580510E4D for ; Thu, 29 Sep 2022 12:16:56 +0200 (CEST) Received: from localhost ([::1]:40070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odqb9-00034l-FV for larch@yhetil.org; Thu, 29 Sep 2022 06:16:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odqAB-0001k5-AO for guix-patches@gnu.org; Thu, 29 Sep 2022 05:49:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36971) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odqAA-0004LC-Rs for guix-patches@gnu.org; Thu, 29 Sep 2022 05:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odqAA-0006cK-O0 for guix-patches@gnu.org; Thu, 29 Sep 2022 05:49:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58156] [PATCH] gnu: Add emacs-circadian. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 29 Sep 2022 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58156 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58156@debbugs.gnu.org Cc: kiasoc5@disroot.org X-Debbugs-Original-To: kiasoc5 via Guix-patches via X-Debbugs-Original-Cc: kiasoc5 , 58156@debbugs.gnu.org Received: via spool by 58156-submit@debbugs.gnu.org id=B58156.166444494025406 (code B ref 58156); Thu, 29 Sep 2022 09:49:02 +0000 Received: (at 58156) by debbugs.gnu.org; 29 Sep 2022 09:49:00 +0000 Received: from localhost ([127.0.0.1]:36045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odqA7-0006bi-NH for submit@debbugs.gnu.org; Thu, 29 Sep 2022 05:48:59 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:50503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odqA5-0006bP-S0 for 58156@debbugs.gnu.org; Thu, 29 Sep 2022 05:48:58 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id DAD58100011; Thu, 29 Sep 2022 09:48:50 +0000 (UTC) From: Nicolas Goaziou References: <95dbafb1ebd166bb70758e94285a966e66d43caa.1664425321.git.kiasoc5@disroot.org> Date: Thu, 29 Sep 2022 11:48:49 +0200 In-Reply-To: <95dbafb1ebd166bb70758e94285a966e66d43caa.1664425321.git.kiasoc5@disroot.org> (kiasoc's message of "Thu, 29 Sep 2022 00:22:02 -0400") Message-ID: <87v8p6bjem.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664446616; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=dsOGGMlDIKAmWjJQ65mb5C7XLq2bibkb0cXrGbTGEsQ=; b=N7iDS7cn4E/cb4WxsZG7x6CgAIUF/JbEusLWj5Q/EFt+GnduxU0dI1RLbDJS9yZy+ch9co i2d7bzK1Vdt0kMKuuZmbfrz1mLxnxn5xDj07u0/MiDeB9Y5U1Df9PKGb9Ht3Mgg7DbzOQh C6RMtOvehu9N6XsLN47bJs1hn58U1wI+NNI3m4v8tbt6SeenVcHs7+Q/rQS30xY7+Ckuks k6mowq+3WySnsob1a9TAXyrvpQ9cd1lcOHSIwqQRnahlybsBVnfROElHA65SXDHlvJUNdX 3UEHita2NHVgY6BpeZj7bjXEI0/hjKWqFcHVK2rKJFt66wtSYFkG/XkF98tj9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664446616; a=rsa-sha256; cv=none; b=nFRT8Y7sQqlktkK33d3sSjWcfbJtJLqG1ZK0PRlX2fZuamalMPMlgZW2uvt9Cp6R/oxXLa IfO0JoPIHMZ8R/f+HWUBFrQy2DsYOih8xWvpcqQuoA6t84WMa/t815wH2VjMvVM4cmgCsF cEyrdE+aOBm2QSJgmSwmuNuiAj2CE+W6rv2g7OIua8kT43UP2kg3hiYyiNzOe+Q5tZOuEI FmHxYbaZF8bcxUdwWqfpCTyLdajHkH2vHf01Xx30TcM9SHkih2B+ScjPbZc1sL2N8+dAv3 nL1JWsxLWWbV0h9yI7dYAm7v660y05XTFTvsL+98N1nLPrlfjActf8GhX/IDgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.44 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5580510E4D X-Spam-Score: -1.44 X-Migadu-Scanner: scn1.migadu.com X-TUID: 72g5AqSBDanO Hello, kiasoc5 via Guix-patches via writes: > * gnu/packages/emacs-xyz.scm (emacs-circadian): New variable. Thank you. > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://stable.melpa.org/packages/circadian-" > + version ".el")) Tarballs from Stable MELPA are not considered stable (!). Could you use GitHub as upstream? > + (sha256 > + (base32 > + "1pypy9bhg4lmmjjj0yqvlqs478i84x3awgzzjzdmrj1jlqbbvdj7")))) > + (build-system emacs-build-system) > + (home-page "https://github.com/guidoschmidt/circadian.el") > + (synopsis "Theme-switching for Emacs based on daytime") > + (description "emacs-circadian tries to help reduce eye strain that Circadian reduces eye strain=E2=80=A6 or Circadian may reduce=E2=80=A6 In any case the project is named Circadian, "emacs-circadian" being the name of the Guix variable bound to the package. > +may arise from the difference of the display brightness and surrounding > +light by automatically switching between light and dark themes. It is > +inspired by color temperature shifting tools and brightness adaption > +software.") > + (license license:expat))) Licensing is ambiguous. The LICENSE file is expat, but the sole ".el" file is explicitly GPL3+. So I guess this would be (list gpl3+ expat). Could you also activate tests for this package? See for example "emacs-go-mode" for an example. You will need to add emacs-el-mock and emacs-ert-runner to the list of native inputs. Could you send an updated patch? Regards, --=20 Nicolas Goaziou