From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6NptFXymVmPCOgEAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 16:51:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cMeyFXymVmOHBAEA9RJhRA (envelope-from ) for ; Mon, 24 Oct 2022 16:51:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 29EBC1BB02 for ; Mon, 24 Oct 2022 16:51:40 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omyK8-0005BA-Ub; Mon, 24 Oct 2022 10:21:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omyK6-0005Ah-RW for guix-patches@gnu.org; Mon, 24 Oct 2022 10:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omyK6-0005B8-IX for guix-patches@gnu.org; Mon, 24 Oct 2022 10:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omyK6-0008JC-1M for guix-patches@gnu.org; Mon, 24 Oct 2022 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58549] [PATCH draft] installer: welcome: Warn when uvesafb gets used. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Oct 2022 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58549 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: 58549@debbugs.gnu.org Received: via spool by 58549-submit@debbugs.gnu.org id=B58549.166662123331876 (code B ref 58549); Mon, 24 Oct 2022 14:21:02 +0000 Received: (at 58549) by debbugs.gnu.org; 24 Oct 2022 14:20:33 +0000 Received: from localhost ([127.0.0.1]:49218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omyJc-0008I3-SD for submit@debbugs.gnu.org; Mon, 24 Oct 2022 10:20:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omyJY-0008Hn-EN for 58549@debbugs.gnu.org; Mon, 24 Oct 2022 10:20:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omyJS-00050u-HX; Mon, 24 Oct 2022 10:20:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cteEJqYxlFGPA1jKfFbZRwR3H0zIbIxPD+yKXtd0Y0k=; b=KwdgNjXCiFxCbl0GwutS dqWjls44YjdZLD87UbSpxEEfxx471n04SjOaQ8q+0NjiJlI6jGM7+Jyjq88BZpZViSVm8W5WM+xYL rPhMFjMVWW9mHqnDeVJaOVGaMd6zR9Hwo5RIJwZYQIa22TcfethkopKuieNUYo9M2mtKYH31fvQx6 zZYvz3kZrdWlMRBmNJoYLXz2G1b+OZm4rlV4rtJLLQ3jw+TGifVUOGxuJK2RFS8Y8x27QrSmqA2DX XIdouXdMTrBhCaoSLODihQpwbm8r/Zl/ZGm6pbJIkU2azWJt9f05thq/TRa0WXc1Sr9ppBqqSxKF8 HFPju0sJZRfFvA==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775] helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omyJS-00023T-3j; Mon, 24 Oct 2022 10:20:22 -0400 From: Mathieu Othacehe References: <87h7055c6g.fsf@pelzflorian.de> <87lepen5yn.fsf@gnu.org> <877d0ptk5u.fsf@pelzflorian.de> Date: Mon, 24 Oct 2022 16:20:19 +0200 In-Reply-To: <877d0ptk5u.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Mon, 24 Oct 2022 15:39:57 +0200") Message-ID: <87v8o9nw0s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Guix-patches" Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666623100; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cteEJqYxlFGPA1jKfFbZRwR3H0zIbIxPD+yKXtd0Y0k=; b=A43sa+TJ7i1VqvN/PUiuFk8Jg5l64Yc7wE5z1/wF3N7V3RM0rDOMi9/AIgbmUg0fbX5OA0 DzA+Ar7HDgH/K4xaQq9GqfPNsO0E2TUcEmUSBybDc1hMmCOgXJRVWWNsji193QnWoqOsJx QnE/Sxj+po+21JkJWdrqVcQDR8zyhC0FpAvxfXzDfH0D+md5agi/HIGz+ie3ZTH9hAH7LJ 0HbI7BDYNbb0yqq3HWcXRtB6o1ES0wLEXZ+PGCXdqyYObVR+h5cMy4wDoX8m1M/gq38Joe nShJq+qTwwlNuLhEgh0y4niosaWVZhHF55n3wxPdIi+1bYmcoJpLbTK6L0rz/Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666623100; a=rsa-sha256; cv=none; b=vACpnuSWPXYX0da+wsBrlh0YwvW3OOiab19Y+UYOuiGK+3C+RN3bxj/Ttvbl2Iim8JU95N kMCwh0BFJhVFmaaTWXRsVjyrIQIL3vlaRG/XIkQeIgoNg3k+PynZ7LeT9Hhy8ynS9kxpoT GjRaya+BbutTRjyoJn8oQttArJibXJu95r2OpF15xC8OGuympL2xXh0hMGecOYzjHVUL+1 gPfsutUIk5LABrDsVuO3WCydLfXpphAuCUhDt7zp4OZTE0AfDtpAaqlrW9OIknFVwOzM65 Zb2U71b5iHZmlDOWzC5kOQHdFJDEGdyp13QKCa8Z3dMQoTDtRg3FpmJ8SHbTJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KwdgNjXC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=KwdgNjXC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 29EBC1BB02 X-Spam-Score: -3.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: H5WT3IoG12aJ Hello Florian, > Thinking about it, the false alarms are not nice, but I don=E2=80=99t kno= w if > Ludo=E2=80=99s proposed device check would > be reasonably doable and he actually wasn=E2=80=99t mentioning it in rela= tion to > graphics. I think this patch is right (after fixing the indentation). > Shall I push or make more changes? Ludo firmware load detection seems like a good idea to me but we would need to study the feasibility. Your patch seems OK to me, you can go ahead. Mathieu