From: Andrew Tropin <andrew@trop.in>
To: "Ludovic Courtès" <ludo@gnu.org>, 60365@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell
Date: Wed, 28 Dec 2022 11:23:03 +0400 [thread overview]
Message-ID: <87v8lwf0vc.fsf@trop.in> (raw)
In-Reply-To: <20221227212342.17939-1-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]
On 2022-12-27 22:23, Ludovic Courtès wrote:
> Hello!
>
Hi Ludovic!
> I found some things could be improved in how we deal with ‘PS1’ in
> Guix Home, Guix System, and ‘guix shell’ (my initial motivation was
> making it easy to change ‘PS1’ from a Home configuration).
>
> These patches fiddle with ‘PS1’. The most visible effect is that
> Guix Home’s ~/.bashrc will no longer provide a default ‘PS1’.
>
> Thoughts?
Factorization of bashrc is great!
Not sure about moving PS1 to /etc/bashrc as it won't work on foreign
distros and guix environment won't be noticable in the prompt. Warning
is useful, but I would expect prompt work OOB, when guix-defualts? is
#t.
The possible alternative solution is to factorize bash_profile and put
PS1 here, so both skeleton and home provided bashrc have it, after that
setting PS1 with environment-variables field will start working.
>
> Ludo’.
>
> Ludovic Courtès (4):
> system, home: Factorize default '.bashrc'.
> system: Define default 'PS1' in /etc/bashrc rather than ~/.bashrc.
> environment: Simplify 'PS1' suggestion on '--check'.
> environment: Avoid false positive on 'PS1' check.
>
> gnu/home/services/shells.scm | 41 +++---------------------------------
> gnu/system.scm | 3 +++
> gnu/system/shadow.scm | 33 +++++++++++++----------------
> guix/scripts/environment.scm | 12 ++++++-----
> 4 files changed, 28 insertions(+), 61 deletions(-)
>
>
> base-commit: 9369c1ccf47d9bf6f2e28a9454c1c329a2044f19
> prerequisite-patch-id: aae3af39aa7753dd7ed6d0584587a06d51402386
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-12-28 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-27 21:23 [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell Ludovic Courtès
2022-12-27 21:26 ` [bug#60365] [PATCH 1/4] system, home: Factorize default '.bashrc' Ludovic Courtès
2022-12-27 21:26 ` [bug#60365] [PATCH 2/4] system: Define default 'PS1' in /etc/bashrc rather than ~/.bashrc Ludovic Courtès
2022-12-27 21:26 ` [bug#60365] [PATCH 3/4] environment: Simplify 'PS1' suggestion on '--check' Ludovic Courtès
2022-12-27 21:26 ` [bug#60365] [PATCH 4/4] environment: Avoid false positive on 'PS1' check Ludovic Courtès
2022-12-28 7:23 ` Andrew Tropin [this message]
2023-01-03 22:46 ` [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell Ludovic Courtès
2023-01-04 6:00 ` Andrew Tropin
2023-01-05 14:20 ` bug#60365: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8lwf0vc.fsf@trop.in \
--to=andrew@trop.in \
--cc=60365@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).