From: Feng Shu <tumashu@163.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 60549-done@debbugs.gnu.org
Subject: [bug#60549] [PATCH 2/5] gnu: Add emacs-citre.
Date: Sat, 07 Jan 2023 15:16:06 +0800 [thread overview]
Message-ID: <87v8lix1ah.fsf@163.com> (raw)
In-Reply-To: <87v8ljrz64.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Sat, 07 Jan 2023 01:00:51 +0100")
[-- Attachment #1: Type: text/plain, Size: 131 bytes --]
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
Hello:
emacs-citre now get the wrong ctags path, for emacs has ctags too. :-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-emacs-cire-Search-proper-ctags-program.patch --]
[-- Type: text/x-patch, Size: 1394 bytes --]
From 9b69ed1524cbe3aa3cb75b44fcb7453b43ee06c2 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Sat, 7 Jan 2023 15:07:14 +0800
Subject: [PATCH] gnu: emacs-cire: Search proper ctags program
* gnu/packages/emacs-xyz.scm (emacs-citre) [arguments]<#:phases>: Do not use
search-input-file to search ctags, for it will get ctags of emacs-minimal
instead of universal-ctags.
---
gnu/packages/emacs-xyz.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b6024925ec..4e7aa568ea 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34170,7 +34170,11 @@ (define-public emacs-citre
(lambda* (#:key inputs #:allow-other-keys)
(emacs-substitute-variables "citre-ctags.el"
("citre-ctags-program"
- (search-input-file inputs "/bin/ctags")))
+ ;; NOTE: Do not use search-input-file in this place, for it
+ ;; will get ctags of emacs-minimal instead of
+ ;; universal-ctags.
+ (string-append (assoc-ref inputs "universal-ctags")
+ "/bin/ctags")))
(emacs-substitute-variables "citre-readtags.el"
("citre-readtags-program"
(search-input-file inputs "/bin/readtags")))
--
2.38.1
[-- Attachment #3: Type: text/plain, Size: 2394 bytes --]
> Hello,
>
> tumashu@163.com writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-citre): New variable.
>
> Applied, with the changes detailed below. Thank you.
>
>> + #~(modify-phases %standard-phases
>> + (add-after 'unpack 'patch-citre-ctags-program
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (emacs-substitute-sexps "citre-ctags.el"
>> + ("defcustom citre-ctags-program"
>> + (string-append (assoc-ref inputs "universal-ctags")
>> + "/bin/ctags")))))
>> + (add-after 'unpack 'patch-citre-readtags-program
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (emacs-substitute-sexps "citre-readtags.el"
>> + ("defcustom citre-readtags-program"
>> + (string-append (assoc-ref inputs "universal-ctags")
>> + "/bin/readtags")))))
>> + (add-after 'unpack 'patch-citre-gtags-program
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (emacs-substitute-sexps "citre-global.el"
>> + ("defcustom citre-gtags-program"
>> + (string-append (assoc-ref inputs "global")
>> + "/bin/gtags")))))
>> + (add-after 'unpack 'patch-citre-global-program
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (emacs-substitute-sexps "citre-global.el"
>> + ("defcustom citre-global-program"
>> + (string-append (assoc-ref inputs "global")
>> + "/bin/global"))))))))
>
> I merged everything into a single phase and used more specific
> `emacs-substitute-variables' instead of `emacs-substitute-sexps'.
>
>> + (inputs (list global universal-ctags))
>> + (home-page "https://github.com/universal-ctags/citre")> + (synopsis "Ctags IDE on the True Editor")
>> + (description
>> + "Citre is an advanced Ctags (or actually, readtags) frontend for
>> +Emacs. It offers:
>> +
>> +@itemize
>> +@item completion-at-point, xref and imenu integration.
>> +@item citre-jump: A completing-read UI for jumping to definition.
>> +@item citre-peek: A powerful code reading tool that lets you go down the
>> +rabbit hole without leaving current buffer.
>> +@end itemize\n")
>
> I reworded the description.
>
> Regards,
--
next prev parent reply other threads:[~2023-01-07 7:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 12:46 [bug#60549] [PATCH 2/5] gnu: Add emacs-citre tumashu
2023-01-07 0:00 ` bug#60549: " Nicolas Goaziou
2023-01-07 7:16 ` Feng Shu [this message]
2023-01-07 11:11 ` [bug#60549] " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8lix1ah.fsf@163.com \
--to=tumashu@163.com \
--cc=60549-done@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).