From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id U2azHFkUv2MlXwEAbAwnHQ (envelope-from ) for ; Wed, 11 Jan 2023 20:56:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GElsGVkUv2MPBwAAG6o9tA (envelope-from ) for ; Wed, 11 Jan 2023 20:56:09 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0ECD03642 for ; Wed, 11 Jan 2023 20:56:08 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFhCd-0008FM-Qq; Wed, 11 Jan 2023 14:56:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFhCc-0008FD-Av for guix-patches@gnu.org; Wed, 11 Jan 2023 14:56:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFhCc-0007m3-0C for guix-patches@gnu.org; Wed, 11 Jan 2023 14:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFhCb-00062v-Ig for guix-patches@gnu.org; Wed, 11 Jan 2023 14:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60224] [PATCH v3 07/11] gnu: make-u-boot-sunxi64-package: Use gexps and adjust file name. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 11 Jan 2023 19:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60224 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vagrant Cascadian Cc: rekado@elephly.net, 60224@debbugs.gnu.org Received: via spool by 60224-submit@debbugs.gnu.org id=B60224.167346695923234 (code B ref 60224); Wed, 11 Jan 2023 19:56:01 +0000 Received: (at 60224) by debbugs.gnu.org; 11 Jan 2023 19:55:59 +0000 Received: from localhost ([127.0.0.1]:43938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhCZ-00062f-Cr for submit@debbugs.gnu.org; Wed, 11 Jan 2023 14:55:59 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:36426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhCV-00062M-MR for 60224@debbugs.gnu.org; Wed, 11 Jan 2023 14:55:58 -0500 Received: by mail-qv1-f42.google.com with SMTP id t7so11321248qvv.3 for <60224@debbugs.gnu.org>; Wed, 11 Jan 2023 11:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=96Czy8f8aEuwmkFxwAgyxW+9040QTmrsR3jvmzJHbyo=; b=RMoAYoJWm3nbYtxNW8xB3GW1NnErmZ4iJvPgTQ5o73ytaIpIPNGogNwm3zntaAM/Qs ZRDBwdIYzMUHdh+rLt7q7dEcl495hGSqb98BHFYlPMxz8a2JOFbkxVT/Em+45K7soqEg /X/2tKmDCBP6iqsXg+w09fQ45B0FgUtZE/uj2kiY2fyPjqAT13wOv5lBEKxMIiiWFn2R URT3ZmqOcE9lwqbPBLMY6ZDiHIhjhDuVvGFWPSqsY0aRzugi9gr8I2DtBbYJvOy5xB9c VXrGWNxr1v/w9RmfI/6yijIl0GtqbJcxErmdwtAjKrM9LByYAGwIprHm0IPTc7Tov25E WUhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=96Czy8f8aEuwmkFxwAgyxW+9040QTmrsR3jvmzJHbyo=; b=P5w/WW+gZyxpzV9RzgPxxXmpwPZ9y7j4+sOXus9uSamMGo8ZFLUIBpDwQdq8828euP x9fTqwJsY0zTUGyUzsZZHUdhQnM1dlEHaOnk1m3K1mTOgEkCmDvvLWEBdHVy079+Afhj kP+bm4GqYsaJ1uE2OSZGe7+cF6NYA2Kvq7ToSe9VE51Lb3PcAlOBW+Z0nv3X3P1SxZ3X ggdxtvZFWkHtGc5+WoH5xnG0jGsJWPvWRt4Qdq0iVdwxXvNU3cwk+1HsW6WQW4NhiBKp SkqRMgh4fzPO3uXLFryFf8NzmUWxKw0u4FoHAZHm6l4aOOEAtDsKRrJaT0BNxqCRr6In 5naw== X-Gm-Message-State: AFqh2koJwz5vrzZ/TGjgtcq+b+DjbgBhxiH+iPY6j4U058Ap2zlsZSvu x7lBUym23jK/c7mnsJs7xN0= X-Google-Smtp-Source: AMrXdXvDvqdEiFAK7BaGY19cwOVjyWYsw/IScthRNNwZfQUbr1OKxFC55ABOCJpfmn5qzhr9HTrqLw== X-Received: by 2002:a05:6214:5908:b0:531:94d7:a433 with SMTP id lp8-20020a056214590800b0053194d7a433mr88215752qvb.26.1673466950147; Wed, 11 Jan 2023 11:55:50 -0800 (PST) Received: from hurd (dsl-159-79.b2b2c.ca. [66.158.159.79]) by smtp.gmail.com with ESMTPSA id h9-20020a05620a244900b006fc2cee4486sm9617252qkn.62.2023.01.11.11.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:55:49 -0800 (PST) From: Maxim Cournoyer References: <20230102004637.3920-1-maxim.cournoyer@gmail.com> <20230102004637.3920-7-maxim.cournoyer@gmail.com> <87k01zk2g7.fsf@yucca> Date: Wed, 11 Jan 2023 14:55:48 -0500 In-Reply-To: <87k01zk2g7.fsf@yucca> (Vagrant Cascadian's message of "Fri, 06 Jan 2023 09:17:12 -0800") Message-ID: <87v8lchmm3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673466969; a=rsa-sha256; cv=none; b=EHJiGpdPsvtKSVICUuEvnsjJLey38MiQArarXCT7j2iLxgDwX4Xf3w1mULPNU1q4We9H83 /9YFuQKY3+aQSuX+ZKChU4Y0an861zj/ofNlkDM9e6Fq49OQ+duGhPTpSYIbeX+ATGfvkb ogb4k3WljM2sbNxxw8GSI2w9lR8a0+SmVdvuHvJ9IjfFep95dV/Wik63aAVpOBA2vVV6ov kF3cFfjDi8RK+Jm+hfBGmpws6VXZN7LWz+0SCr790kSVPAupglW+CmfMoF8rTnXFzWVqT3 +g7ogcAHIotF9YjQK1BhHWjb84TmeN71nU2FeAiCJiXMF5YF8uG8cEwL+DXuzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RMoAYoJW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673466969; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=96Czy8f8aEuwmkFxwAgyxW+9040QTmrsR3jvmzJHbyo=; b=rORsExQMKyGF3UH5LAwHvKKzIUe7Vxjn5WflRfC7KpG19s3vGcAf4xzXiWNrXSZX4pJGx3 iQmEGJIrfDjIRf4rtDMYqhNLUO5ZuS8LmVrbws4CM+86x1IU5H1STKQp7aGRuGeCMDaW/R v3Fuho2d61fPPCTlKn5D3WleE/jnAmIAqQRpwlUzKomcFkT83ET/xzu/aKhcfYlJdGTiz9 fe2TunTdhFvgzRNY3M/u36XtKlcp4B5jDlai5vJg+r+lIk8UkKLyP8YFDmMYzMPzpznnOK HFfsKX7mmpncpL6oEN3nud/hfkRD5OY7bUJmle3FFkO/N/QyQn1RHEkpSCINWQ== X-Migadu-Spam-Score: -1.99 X-Spam-Score: -1.99 X-Migadu-Queue-Id: 0ECD03642 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=RMoAYoJW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) X-TUID: iKLAnzc3m6Tp Hi Vagrant! Vagrant Cascadian writes: > On 2023-01-01, Maxim Cournoyer wrote: >> * gnu/packages/bootloaders.scm (make-u-boot-sunxi64-package) >> [phases] {set-environment}: Replace bl31.bin with bl31.elf; bl31.elf doesn't >> exist anymore for some reason. > > Seems like the description is the inverse of what it is actually > doing. But what it is doing is ... not right either. :/ [...] >> + #~(modify-phases #$phases >> + (add-after 'unpack 'set-environment >> + (lambda* (#:key native-inputs inputs #:allow-other-keys) >> + (setenv "BL31" (search-input-file (or native-inputs inputs) >> + "bl31.elf")))))))) > > bl31.elf is built on rockchip platforms, but not sunxi/allwinner > platforms. The sunxi/allwinner platforms need bl31.bin. This ^ ... > >> (native-inputs >> - `(("firmware" ,arm-trusted-firmware-sun50i-a64) >> - ,@(package-native-inputs base)))))) >> + (modify-inputs (package-native-inputs base) >> + (append arm-trusted-firmware-rk3399)))))) > ... was the product of the above typo; thanks for catching it! > This is absolutely incorrect, as this forces it to be rk3399, which is > not even a sunxi platform, and will break all the sun50i-a64 platforms > (e.g. pine64, pinebook). That said, there are technically sunxi64 > platforms that would use a different arm-trusted-firmware build, so this > could use improving. I've now removed that commit; and undid the previous change to, which was based on that mistake. I'll sent a v4 shortly. I've noted something annoying though; is that cross-compiling doesn't work yet because U-Boot uses python packages, which barfs like: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build u-boot-puma-rk3399 guix build: error: gnu/packages/check.scm:1997:2: python-coverage@5.2.1: build system `python' does not support cross builds --8<---------------cut here---------------end--------------->8--- So currently the only way to build it is via --system, e.g. 'guix build -s aarch64-linux u-boot-puma-rk3399'. The complications I simplified were probably papering over that issue. That said, I see no reason we couldn't convince our Python build system to "cross-compile" Python packages, so I intend to look at this. Not sure if this should be a blocker or not. -- Thanks, Maxim