From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +PvOBaRcIWSKVwAASxT56A (envelope-from ) for ; Mon, 27 Mar 2023 11:06:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id ytG2BaRcIWT2ogAA9RJhRA (envelope-from ) for ; Mon, 27 Mar 2023 11:06:44 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAF5015922 for ; Mon, 27 Mar 2023 11:06:43 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=EumQsUUI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679908003; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iCA1NBcs6NguAOzae8qtcqcH7sw4pTMVvXUSMb1dctU=; b=Stn8A/OxyrSHIsxgLkh51R+aWTU/WAr9CMpalqzTthdVXeS0TZHrd1CCfy6rJasl7XneEn RJPVn26/aqLaZIulyYAm6rMshtjiXDyUMTXLlwmmoZr8hBPij4OybtaBkXaiR3C7ynRfRE Scp11hUQ9DsaPV9RYCVup2QY1xbkyjRpUozmAkAUIotXpIaR9Vx0r19FBh34bCXRbeBru3 cFoPVXFQ87aGSnMbujbxBhhlLzXD58WsgAfyXLB2SPyNITE+bMN6W6B6kRjQS8lCVJPfTi I0WAUdmsaplJZWLW7qyEF6zwcTHftfBMQ+8M/S8kfUrOx4MpPnU1+pSjShm4CA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679908003; a=rsa-sha256; cv=none; b=FgPPyVJKXam7gjejrKSB06Hs3/zEzZI9Zvn54fc1974ygrjsafJjj4jXImx2iK/w47s8dZ uE448uNt/7cm6tJRQ1H2Hjq8PaBcyzzTB6ACCBQ44acZ9hv67w2w4G47CysNCawNW/+auC VNWxfQDvCMRFsDHUp1jTsqawUIpEG6LIYn1sOCKa9X9tDGBv3MOWK60b+zBuiHo3Idgk8J 16d5iZ4o1RrwRZP779Mp+1NdTnYOXpk42FTCP2O13PszqC93zUcz1ouN/IypEnhRR7g8SO /E0oZDx/UzHAabxi6GYKjwleLfqr0cixO/sB+THrOdWqkTr2LauVqNhY9D9Yqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=inria.fr header.s=dc header.b=EumQsUUI; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=inria.fr (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pginn-0008Vn-4d; Mon, 27 Mar 2023 05:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pginj-0008Up-3A for guix-patches@gnu.org; Mon, 27 Mar 2023 05:06:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgini-000634-H6 for guix-patches@gnu.org; Mon, 27 Mar 2023 05:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pginh-0004Ev-Vz for guix-patches@gnu.org; Mon, 27 Mar 2023 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43442] Subversion keyword substitution Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Mar 2023 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43442 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 43442@debbugs.gnu.org, zimoun Received: via spool by 43442-submit@debbugs.gnu.org id=B43442.167990790516196 (code B ref 43442); Mon, 27 Mar 2023 09:06:01 +0000 Received: (at 43442) by debbugs.gnu.org; 27 Mar 2023 09:05:05 +0000 Received: from localhost ([127.0.0.1]:46509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgimn-0004DA-E7 for submit@debbugs.gnu.org; Mon, 27 Mar 2023 05:05:05 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:33564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgimk-0004CW-8N for 43442@debbugs.gnu.org; Mon, 27 Mar 2023 05:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version:content-transfer-encoding; bh=iCA1NBcs6NguAOzae8qtcqcH7sw4pTMVvXUSMb1dctU=; b=EumQsUUI81QHua3D1sZO5bzrB9Aqg8HYlUBjza/ZGUrhIsu1ztprr/2l jQw8JTaKGg2m8jHlm4xwMg3i+OEUPqfgsnnCHeHJts3ceqhXg6o8mV0pi WBjaLcg2jjVVytc8X9Ry4i4z/pB3WngdFQDoM2o+KJaAfEpOAPE+RZ4p7 M=; X-IronPort-AV: E=Sophos;i="5.98,294,1673910000"; d="scan'208";a="99238308" Received: from unknown (HELO ribbon) ([193.50.110.81]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2023 11:04:56 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200916081411.5801-1-zimon.toutoune@gmail.com> <20200916081642.6716-1-zimon.toutoune@gmail.com> <87o8lyj090.fsf@gnu.org> <86zh5iol1n.fsf@gmail.com> <87h7rocvkt.fsf@gnu.org> <877dsi44lu.fsf@gnu.org> <87y2knhei3.fsf@gnu.org> <87jzzbms54.fsf_-_@gnu.org> <87jzz8xva8.fsf@ngyro.com> <871qle6p4x.fsf_-_@inria.fr> <87v8ipwwt4.fsf@ngyro.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 7 Germinal an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour du Bouleau X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 27 Mar 2023 11:04:55 +0200 In-Reply-To: <87v8ipwwt4.fsf@ngyro.com> (Timothy Sample's message of "Fri, 24 Mar 2023 17:31:51 -0600") Message-ID: <87v8imimyw.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: X-Migadu-Queue-Id: DAF5015922 X-Spam-Score: -2.93 X-Migadu-Spam-Score: -2.93 X-Migadu-Scanner: scn0.migadu.com List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: kHoIljXwYYyz Hi, Timothy Sample skribis: > Thinking entirely abstractly, the keywords should be expanded. I=E2=80= =99m not > really long enough in the tooth (old enough) to know how people use > keywords, but one might be tempted to do something like: > > printf ("This is foo version %s\n", "$Revision$"); > > If that ever happens, processing the keywords would be very important. =E2=80=9CVery=E2=80=9D might be an overstatement. :-) In practice, these were typically used in source file headers, so that if you exported or copied files around (outside version control), they=E2= =80=99d have a timestamp of sorts at the top. [...] > It=E2=80=99s not clear to me why SWH passes =E2=80=98--ignore-keywords=E2= =80=99 to Subversion in > the first place. I guess it saves storage, because having identical > files allows deduplication. I asked on #swh-devel and the fine folks there hinted at non-reproducibility. Looking at , one thing that=E2=80=99s definitely not reproducible is the =E2=80=9Clocal = time zone=E2=80=9D bit. From that perspective it makes a lot of sense to disable keyword substitution. >> How frequent is the use of keywords though? > > Well, you found 11 in the current Guix, and I see 30 when I process > everything I have (from version 1.0 to a few weeks ago). Furthermore, > the only usage pattern I see is =E2=80=9C$Id=E2=80=9D in a comment. Interesting. >> So, how about applying the =E2=80=98--ignore-keywords=E2=80=99 change an= d updating >> hashes accordingly? > > It=E2=80=99s probably the right default given the circumstances. OK. I=E2=80=99ll submit a patch to that effect, unless you beat me at it. = :-) > It seems like there=E2=80=99s a direct conflict between ease of packaging= and > ease of time travel. In the hypothetical case that a keyword mattered, > it would be a nasty surprise to the package author. They would have to > (a) discover the problem and (b) manually do the keyword substitution in > Scheme (or work around it). My intuition is that the worst =E2=80=9Cproblem=E2=80=9D we might have is = =E2=80=98--version=E2=80=99 showing unexpanded keywords. [...] >> We should remove that recursive flag when it has no effect. Perhaps we >> could proceed similarly? > > Huh. My scripts tell me that we haven=E2=80=99t needed it at all in the = last > three years. That=E2=80=99s a suspicious enough result that I wonder if = there=E2=80=99s > a bug in my scripts. The results are looking good so far, but there are > a few things I still need to look over. Looks like it might be easily addressed! Thanks, Ludo=E2=80=99.