From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id SFwXHKXYLmQHXwEASxT56A (envelope-from ) for ; Thu, 06 Apr 2023 16:35:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0DzhG6XYLmR+TAEAauVa8A (envelope-from ) for ; Thu, 06 Apr 2023 16:35:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1267516191 for ; Thu, 6 Apr 2023 16:35:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkQhe-0007Pr-J4; Thu, 06 Apr 2023 10:35:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQhc-0007Nb-P6 for guix-patches@gnu.org; Thu, 06 Apr 2023 10:35:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkQha-0007SK-8J for guix-patches@gnu.org; Thu, 06 Apr 2023 10:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkQha-0003v5-4o for guix-patches@gnu.org; Thu, 06 Apr 2023 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62473] [PATCH 0/4] OpenFoam update to version 10 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Apr 2023 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62473 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: reza Cc: 62473@debbugs.gnu.org Received: via spool by 62473-submit@debbugs.gnu.org id=B62473.168079167715023 (code B ref 62473); Thu, 06 Apr 2023 14:35:02 +0000 Received: (at 62473) by debbugs.gnu.org; 6 Apr 2023 14:34:37 +0000 Received: from localhost ([127.0.0.1]:54644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQhA-0003uF-KS for submit@debbugs.gnu.org; Thu, 06 Apr 2023 10:34:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQh9-0003u1-Hy for 62473@debbugs.gnu.org; Thu, 06 Apr 2023 10:34:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQh4-0005xH-8e; Thu, 06 Apr 2023 10:34:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rUmwhMK4LR/sLljeU1SYfufSc9yXv5qySOlMm09MK6A=; b=OEB0hT7ZK51ptZM4Joe+ TqIwz5QCmoSqrNeSXlNgbzcGcHM2evmouopPGnemEAIx31xUW91G5M9G+twYf+e7B6eKshn7GdJ/m CKClBc4EsDlNB2Ul5Q2sj4gLVrSwPQElYs8pSWiyrKP6+mWyCVj6gKh4LrdU4/A/HLNtv/DUpAyOK iGDhNvjWiZi9BbVShcpP8QuZsiNQcsbe7I+mmyObhO+tnTQy9ush3ZKi2mFU92IGyQwLkwOTi8TzV SooixnilwCqFYzE0HF0jRg9UdbGF8wrW/TYmfkJCGHxge4b0kzPxC1v0WR1O/IVFmF0vsMhREEBrG IfC3Y2qUWabbFA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkQgX-0005Jx-Dc; Thu, 06 Apr 2023 10:34:13 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <0102018752a6ef56-33d70f34-9044-4a18-83de-3248bb3b25cd-000000@eu-west-1.amazonses.com> Date: Thu, 06 Apr 2023 16:33:56 +0200 In-Reply-To: <0102018752a6ef56-33d70f34-9044-4a18-83de-3248bb3b25cd-000000@eu-west-1.amazonses.com> (reza@housseini.me's message of "Wed, 5 Apr 2023 18:21:24 +0000") Message-ID: <87v8i9jd0r.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680791717; a=rsa-sha256; cv=none; b=nacC6PL5br09Rez6bnczZp8OTet9tP36AgjAFRAqCgnyuLXb5hUwGIVkCwCyz7pOtrx9ac UyjesG2cTgwsg00ATP16O/cHlbYYVgRvUUWVcAiBtL6Y09Ae6whvDi8PmrOLFuRIkuidCm 3Ntg4GEaIcTVj+5CyPzZQ95L3EFFoh26qkQHXijRi+mbRPAoEPMEm+le9FV2WN9CjXUOmH xWB7g5t9jiw0vnAkFQDNjlIxzslA9g9ieLI5HxCi5aRaiuwYk3ZBevPkV4l5j0i027OS7B QwXYB4WEPlKMmi9XbUKoElgVjHLGebKNyob3Cb0Y9vtgkOl1lAaY4YMjN8rgvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OEB0hT7Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680791717; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=rUmwhMK4LR/sLljeU1SYfufSc9yXv5qySOlMm09MK6A=; b=ktrVTABoESzyICcL0nS5jPxmVkb5mHEPyc7DSBmxvarSSmytzqG9E2vWBaUATjDVRzUVvE 1JLqunsmuWqUuMhaHg5G09n5yYfQuoB1AoAggtWvj/9nYvQdxgapdj4hyW/zA6wrAF5akS UyD7HgUvcg8cDjaWCdF+/a/+6UzM79ip5TInsgt3ljgi1oYSKHyxYdGr6UKqrBE1HEZJx7 DDYxC5RGn5Bfxp9ScxyYh9mbbLPHZi5U5jm6qYOSGxTWHFChIFLaEVpIAY9S6iyw5Wr72x S4s2mQ06O8JqZnrR4L2w2RfBkJO/LVp1HOMtcAHKAJQyUTGuwcx78gXNWQ270g== X-Migadu-Spam-Score: -4.12 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=OEB0hT7Z; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -4.12 X-Migadu-Queue-Id: 1267516191 X-TUID: 20CdqKxWBVZ9 reza skribis: > --- > gnu/local.mk | 1 - > .../patches/openfoam-4.1-cleanup.patch | 243 ----------- > gnu/packages/simulation.scm | 405 ++++++++++++------ > 3 files changed, 263 insertions(+), 386 deletions(-) > delete mode 100644 gnu/packages/patches/openfoam-4.1-cleanup.patch BTW, please consider adding ChangeLog-style commit log, as per the project=E2=80=99s conventions: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html (We can help you if needed.) > -(define-public openfoam > +(define-public openfoam-org Maybe add: (define-public openfoam (deprecated-package "openfoam" openfoam-org)) Otherwise LGTM.