unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Andrew Tropin <andrew@trop.in>
Cc: 63071-done@debbugs.gnu.org, Gabriel Wicki <liliana.prikler@gmail.com>
Subject: bug#63071: [PATCH] gnu: Add emacs-riscv-mode.
Date: Wed, 03 May 2023 14:28:56 +0200	[thread overview]
Message-ID: <87v8h9vbsn.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87o7nbe06r.fsf@trop.in> (Andrew Tropin's message of "Wed, 26 Apr 2023 08:29:00 +0400")

Hello,

Andrew Tropin <andrew@trop.in> writes:

>> +(define-public emacs-riscv-mode
>> +  (let ((commit "8e335b9c93de93ed8dd063d702b0f5ad48eef6d7")
>> +        (revision "1"))
>
> Revision should be 0 here, everything else LGTM.

FWIW, I noticed that revision 1 for version V tells Repology that it was
released after V. This is not the case for revision 0. So I think
starting at 1 is not bad either.

I applied the latest version of patch.

Thanks to everyone.

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2023-05-03 12:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 17:23 [bug#63071] [PATCH] gnu: Add emacs-riscv-mode Gabriel Wicki
2023-04-25 15:48 ` Gabriel Wicki
2023-04-26  4:29   ` Andrew Tropin
2023-05-03 12:28     ` Nicolas Goaziou [this message]
2023-04-25 18:21 ` Liliana Marie Prikler
2023-04-25 18:27   ` Gabriel Wicki
2023-04-25 19:07     ` Liliana Marie Prikler
2023-04-25 19:14       ` Gabriel Wicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8h9vbsn.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=63071-done@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).