From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OBtpFrDTtmRDhQEASxT56A (envelope-from ) for ; Tue, 18 Jul 2023 20:02:24 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QGaFFbDTtmR+ygAAG6o9tA (envelope-from ) for ; Tue, 18 Jul 2023 20:02:24 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A023328DF for ; Tue, 18 Jul 2023 20:02:24 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=GUNcdrcw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689703344; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ctSv/ZyTOVJl15NrZLiTvMJNl0oeONqLGBOHY0HTzAk=; b=b/qHr+fIAetnyRcXjQqtkkvajH34Rwgw3LVOYq/bRO4VPHlRh6bCp1QKtMEWGGtttM/5uP y8HDtd3dX8de0Q1FD2itWU67rSdoF1PpjoGHKGl6BasG3CKs/m5a0m9fnoYUQ3KjS6thev nsg+VN4It1Utu/Gxi5nyH5Folq0uS6VwbVl5sCi8rIOpbnTP2XdRksksWXRK2sX3wvZ/Z2 RcAUfChgNo/02L7wWwqCAga6mM4KZv+veMVWWuV8Q2SRc1rf66ZC7TVrlO+MCgsz7dzssW Ica7yAl1WVVHT+g/PopwrIge5RX2uiZ1b2x/oSXiZJWap0PQ5mGPqzXnCUU5UQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689703344; a=rsa-sha256; cv=none; b=YZ5ePGxkrjNr63uR7blYmejRSXSdA8NiSaKjxjBd/nEBePZw9Uo2JCeu7M/OiMCpg6B3ew n5EnO4LuLKW8IdS5Ynkf8VMRxuaqc85kOlOdSdWUpZvMHF9+4sGXvQ50/G1I0VpEizhB+S 4unRRebWPhDcKz50unuQp56O5WZUgCL1MQ47kdK+TVnrRc3wqcNt0SRNIcgQQf0r+DFFds vhWV2FR8sDurCQc2P61eDWLVe4LK53K4B83LSNGSLTJDPEO9C3h3vmDOVZ7cLZmFPnAgsw eKEwzxzAYYLRtGmP21v5rCbGqQV5ZzXAW/IFcU60t7wKj7xAuluQYnKL67Rw+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debian.org header.s=1.vagrant.user header.b=GUNcdrcw; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLp1S-00026E-2H; Tue, 18 Jul 2023 14:02:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLp1O-000265-Qp for guix-patches@gnu.org; Tue, 18 Jul 2023 14:02:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLp1O-0002z3-Ij for guix-patches@gnu.org; Tue, 18 Jul 2023 14:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLp1O-0006Kl-EO for guix-patches@gnu.org; Tue, 18 Jul 2023 14:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64667] [PATCH 1/1] gnu: Add grub-coreboot Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jul 2023 18:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64667 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Denis 'GNUtoo' Carikli , 64667@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Efraim Flashner Received: via spool by 64667-submit@debbugs.gnu.org id=B64667.168970327624276 (code B ref 64667); Tue, 18 Jul 2023 18:02:02 +0000 Received: (at 64667) by debbugs.gnu.org; 18 Jul 2023 18:01:16 +0000 Received: from localhost ([127.0.0.1]:54259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLp0d-0006JU-PO for submit@debbugs.gnu.org; Tue, 18 Jul 2023 14:01:16 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:36950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLp0b-0006JF-W6 for 64667@debbugs.gnu.org; Tue, 18 Jul 2023 14:01:15 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:50]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 64D141ABAC; Tue, 18 Jul 2023 11:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1689703264; bh=fjOCNeoHJdbb6Ll96MI8evwS9qr8YvYl8bsBXZMJJTk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GUNcdrcwaXfpXLxyZ/Sar0Whe5L8713okwZLBVYlbUwIvqi7VIoGEQj2V0LDft7XP 6Kef5R3OqK4p4EQXv+fGADnBfxHBcKXENoXzcTt3O1xCsq0qaAXNSm8xEBjtc+6JxN kqBvUN0dVV/c3jktjLUm40y1IbLwTyaPBj9/WSDzRqp83N5ahxXGZt9oQzw4+clvRw WvMsdvMZTC8jdYVexzOIY2dE26RzfilkpvJfielMrJW1uYHyD2wrvznH3hyKGTgzQX H3Li5uX8MV7sMtIGn7YlOWTzaiIO1HDBQCxmi6tSj1bpNUeX2ota8H+xjcFaqWIBxk lkJyzje1vVaoQ== From: Vagrant Cascadian In-Reply-To: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> References: <8828e02880eda902dd7be2195abc013094936567.1689524124.git.GNUtoo@cyberdimension.org> Date: Tue, 18 Jul 2023 11:00:45 -0700 Message-ID: <87v8eh14mq.fsf@wireframe> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -2.24 X-Spam-Score: -2.24 X-Migadu-Queue-Id: 2A023328DF X-TUID: eEXFkl7nfUoc --=-=-= Content-Type: text/plain On 2023-07-16, Denis 'GNUtoo' Carikli wrote: > * gnu/packages/bootloaders.scm (grub-coreboot): New variable. ... > diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm > index 01fd1093ff..c5090d1ead 100644 > --- a/gnu/packages/bootloaders.scm > +++ b/gnu/packages/bootloaders.scm ... > +(define-public grub-coreboot > + (package > + (inherit grub) > + (name "grub-coreboot") > + (synopsis "GRand Unified Boot loader (Coreboot payload version)") > + (arguments > + `(,@(substitute-keyword-arguments (package-arguments grub) > + ;; Several tests fail > + ((#:tests? _ #f) > + #f) Could you explain in more detail about the failing tests in the comment? Which tests? Are they testing things that are not valid in a grub-coreboot context? Is it not reasonable or not plausible to selectively disable only the failing tests? QA seems to build it fine, and nothing else obviously leaps out at me. live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZLbTTQAKCRDcUY/If5cW qicGAPsETo9jC4k6Lsk+ZBZFsRsrvmeT+nO9f0QRkCYvlYKm0wEAgum+XvcVnG7P yctPYXbZP8c8NBEywz5kC+47rDCcQAU= =J8/d -----END PGP SIGNATURE----- --=-=-=--