unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "\( via Guix-patches" via <guix-patches@gnu.org>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: arunisaac@systemreboot.net, 65351@debbugs.gnu.org, jgart@dismail.de
Subject: [bug#65351] [PATCH] gnu: Add cgit-pink.
Date: Thu, 17 Aug 2023 21:53:47 +0100	[thread overview]
Message-ID: <87v8dd8k08.fsf@disroot.org> (raw)
In-Reply-To: <27964fd692479a6350687a2249db8ab6726da246.camel@gmail.com>

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> You sure about that?  cgit has its git source as a regular input...

I mean, I suppose it doesn't really matter, especially not here, but I
think it saves the user re-downloading the source file if they first
compile normally and then cross-compile...?  Because the derivation will
specify the host system, not the target system.

As I said, it's probably not a huge deal with cgit-pink, but I think
it's good to use best practices everywhere, even when it's not strictly
necessary, so that anyone reading the source who spots such a usage will
know to put their secondary <ORIGIN> object in NATIVE-INPUTS in both
cases where the package is rarely cross-compiled and cases where it's
fairly common.

  -- (




  reply	other threads:[~2023-08-17 20:58 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 13:51 [bug#65351] [PATCH] gnu: Add cgit-pink Arun Isaac
2023-08-17 19:00 ` Liliana Marie Prikler
2023-08-17 19:16   ` ( via Guix-patches via
2023-08-17 20:20     ` Liliana Marie Prikler
2023-08-17 20:53       ` ( via Guix-patches via [this message]
2023-08-18  9:03         ` [bug#65351] [PATCH 1/7] gnu: cgit: Make git-source a native input Arun Isaac
2023-08-18 17:03           ` Liliana Marie Prikler
2023-08-21 14:22             ` Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 2/7] gnu: cgit: Make bzip2, gzip and xz inputs Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 3/7] gnu: cgit: Do not return #t from custom phases Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 4/7] gnu: cgit: Use G-expressions Arun Isaac
2023-08-18 17:04           ` Liliana Marie Prikler
2023-08-21 14:27             ` Arun Isaac
2023-08-18 17:06           ` Liliana Marie Prikler
2023-08-21 14:26             ` Arun Isaac
2023-08-21 17:07               ` Liliana Marie Prikler
2023-08-21 17:13               ` ( via Guix-patches via
2023-08-24 10:59                 ` Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 5/7] gnu: cgit: Use cc-for-target Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 6/7] gnu: cgit: Add bash-minimal to inputs Arun Isaac
2023-08-18  9:03         ` [bug#65351] [PATCH 7/7] gnu: Add cgit-pink Arun Isaac
2023-08-18  9:00   ` [bug#65351] [PATCH] " Arun Isaac
2023-09-04  9:02 ` [bug#65351] [PATCH v2 0/7] " Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 1/7] gnu: cgit: Make git-source a native input Arun Isaac
2023-09-04 17:09     ` Liliana Marie Prikler
2023-09-28  7:12       ` Arun Isaac
2023-09-28 16:16         ` Liliana Marie Prikler
2023-10-03 23:27           ` Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 2/7] gnu: cgit: Make bzip2, gzip and xz inputs Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 3/7] gnu: cgit: Do not return #t from custom phases Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 4/7] gnu: cgit: Use G-expressions Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 5/7] gnu: cgit: Add bash-minimal to inputs Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 6/7] gnu: cgit: Use cc-for-target Arun Isaac
2023-09-04  9:02   ` [bug#65351] [PATCH v2 7/7] gnu: Add cgit-pink Arun Isaac
2023-10-03 23:59 ` [bug#65351] [PATCH v3 1/3] gnu: cgit: Update package style Arun Isaac
2023-10-03 23:59   ` [bug#65351] [PATCH v3 2/3] gnu: cgit: Fix cross compilation Arun Isaac
2023-10-05 12:48     ` [bug#65351] [PATCH] gnu: Add cgit-pink Ludovic Courtès
2023-10-05 16:39       ` bug#65351: " Arun Isaac
2023-10-03 23:59   ` [bug#65351] [PATCH v3 3/3] " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8dd8k08.fsf@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=65351@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=jgart@dismail.de \
    --cc=liliana.prikler@gmail.com \
    --cc=paren@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).