From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OMwZFFxTpGU92wAAqHPOHw:P1 (envelope-from ) for ; Sun, 14 Jan 2024 22:34:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id OMwZFFxTpGU92wAAqHPOHw (envelope-from ) for ; Sun, 14 Jan 2024 22:34:20 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nf7ABi5I; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705268060; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Rff2MoltPQFV0G4dTI0vFPAfs51ntIEe1dz+B7ZDHKo=; b=gP3ybEjnZDe0HQSmsT1BZokO1BtFJpCYQsn8N7dOI0LaRns0rURbjBT2KO6FleGJUj0owv uLpiwj5RAykxjA7KLB3zKYt7/JeYw8eLsnFYm4T81ZiUtQpOO0QaHrn1iMkY3I2dL/BaM+ utqLo9+A37aX+SlnevkcHqZb9ZR4UPnbVSSWQDD81cU7N73O+xLUcW5icYixNHaZ6ThVu6 PGMoXz3p8qfvKPozbG7hR0MnK7QuMSBzW15Zu5icPnXG/Qc5O0l3K3STJ+Nz66iBg2+H3h e0ZGqQwTRjNF3vOp+3ULyns65IqT9gw13SILDv1mT5pTiGJ0u2yUxWRCEPD3tA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=nf7ABi5I; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705268060; a=rsa-sha256; cv=none; b=ZO4BRioMl6xomBbe1Oxbhzwpz1y3eE6KTwcuPCXi3yxiK00kWnnC9iD76YlYHzE3cPwvqw U4az5LqiS7sndGIP4oY1ZiXI5h4wq3dGEKR1kiZzLRHwjP5y6nxzUavgnB0DwlhvVz8KNP Usa17DqISfJI8NEqIU1vN0QfKCs/VEojnitbzy8WV/JpDdJzix4ErXM0AA8dvzNe7uCpuH kIA+eMvvEvvoq9S1bnD6wxMb9yAB1EU9t7nJsEQ/XvpI/JqLo+Lf1QJXhwIp/D7KbuTwJW 4muZLyjwdkcQlid3z250InE6MjmPi1FzMiUvPZNanIaoUVJn+XRedbZl4KgftA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0D29439731 for ; Sun, 14 Jan 2024 22:34:20 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rP87I-0004km-5A; Sun, 14 Jan 2024 16:34:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP87G-0004kV-Ue for guix-patches@gnu.org; Sun, 14 Jan 2024 16:34:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rP87G-0001Qe-Mk for guix-patches@gnu.org; Sun, 14 Jan 2024 16:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rP87G-0007iT-1i for guix-patches@gnu.org; Sun, 14 Jan 2024 16:34:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#68357] [PATCH] shepherd: service: fix `unload all` Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Jan 2024 21:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68357 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "zero@fedora" Cc: 68357@debbugs.gnu.org Received: via spool by 68357-submit@debbugs.gnu.org id=B68357.170526801129618 (code B ref 68357); Sun, 14 Jan 2024 21:34:02 +0000 Received: (at 68357) by debbugs.gnu.org; 14 Jan 2024 21:33:31 +0000 Received: from localhost ([127.0.0.1]:44160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP86k-0007he-LL for submit@debbugs.gnu.org; Sun, 14 Jan 2024 16:33:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rP86i-0007hO-4o for 68357@debbugs.gnu.org; Sun, 14 Jan 2024 16:33:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rP86d-00017k-2Z; Sun, 14 Jan 2024 16:33:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Rff2MoltPQFV0G4dTI0vFPAfs51ntIEe1dz+B7ZDHKo=; b=nf7ABi5IiZxWNX1bGkJL GyDL1918mQIhNFcnyv54dDFZIeY4N5NYz8Txnld3OLxDdlVEVFASjlinDfM7e2LGi9cJPohHiuSGj b2Jut6NNjf9Atr67k2XDySxUesiFY2GT5M+HSsIlwixJNae11gJzIbdC0Eg3mnhwz0H/neHsqzROI vxb7HQrKS7SPpngGlmVtB9IDONvb5aEt0ktXwBiSvwPKZm1xRUnH334Mw5/VpBerAbPNPwDaDnSbQ IsYXAuNuaa67oDKjaxjp4WhleotkT4CVN5LZY4/jCEnuIPAlK/HR8Y+tDPhMjMuopsBftFE7fHbZl ylGgzJVZUB1+VQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20240110013058.1822277-2-shinyzero0@tilde.club> (shinyzero0@tilde.club's message of "Wed, 10 Jan 2024 04:30:59 +0300") References: <20240110003016.1761645-2-shinyzero0@tilde.club> <20240110013058.1822277-2-shinyzero0@tilde.club> Date: Sun, 14 Jan 2024 22:33:18 +0100 Message-ID: <87v87vfvmp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.91 X-Migadu-Queue-Id: 0D29439731 X-Spam-Score: -6.91 X-Migadu-Scanner: mx11.migadu.com X-TUID: ua4/H43AnA8T Hi, "zero@fedora" skribis: > * modules/shepherd/service.scm: fix `unload all` Thanks for the patch! > - (('unregister-all) ;no reply > - (let ((root (cdr (vhash-assq 'root registered)))) > - (loop (fold (cut vhash-consq <> root <>) > - vlist-null > - (service-provision root))))) > (('lookup name reply) > ;; Look up NAME and return it, or #f, to REPLY. > (put-message reply > @@ -2638,8 +2633,11 @@ requested to be removed." > (let ((name (string->symbol service-name))) > (cond ((eq? name 'all) > ;; Special 'remove all' case. > - (put-message (current-registry-channel) `(unregister-all)) > - #t) > + (unregister-services > + (filter > + (lambda (sv) > + (not (eq? (service-canonical-name sv) 'root))) > + (service-list)))) Do I get it right that the problem with the current implementation is that services are removed from the registry but not actually stopped? Ludo=E2=80=99.